chore(avm): move proving key to avm files

[fcarreiro]

No description provided.

[fcarreiro]

• chore(avm): move proving key to avm files #8318 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[jeanmon]

LGTM but please have a look at my feedback.

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_poseidon_hash_ms (4): 47.0 (+38%)
• proof_construction_time_poseidon_hash_100_ms (16): 678 (-24%)
• proof_construction_time_poseidon_hash_30_ms (16): 203 (-29%)
• proof_construction_time_sha256_ms (16): 711 (-23%)
• protocol_circuit_simulation_time_in_ms (private-kernel-inner): 221 (+25%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,760	1,565 (-1%)	⚠️ 711 (-23%)	748 (-13%)	772 (-6%)
proof_construction_time_sha256_30_ms	11,471	3,090	1,381	1,417 (-1%)	1,474
proof_construction_time_sha256_100_ms	44,096	11,758 (-1%)	5,565 (+2%)	5,512 (-2%)	5,628 (+2%)
proof_construction_time_poseidon_hash_ms	78.0	⚠️ 47.0 (+38%)	34.0 (-21%)	58.0 (-11%)	88.0 (-2%)
proof_construction_time_poseidon_hash_30_ms	1,529	423	⚠️ 203 (-29%)	227 (-14%)	267 (-8%)
proof_construction_time_poseidon_hash_100_ms	5,655	1,517	⚠️ 678 (-24%)	723 (-12%)	747 (-4%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,244	92,962	178,204
l1_rollup_execution_gas	843,063	1,576,677	3,361,975
l2_block_processing_time_in_ms	255 (-6%)	461 (+1%)	821 (+1%)
l2_block_building_time_in_ms	11,677 (+2%)	22,521	44,985 (+1%)
l2_block_rollup_simulation_time_in_ms	11,676 (+2%)	22,521	44,984 (+1%)
l2_block_public_tx_process_time_in_ms	9,916 (+2%)	20,817	43,187 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,084 (+1%)	4,025
node_database_size_in_bytes	12,615,760	16,699,472
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	89.5 (-1%)	406 (+5%)	21,446	44,898	N/A
private-kernel-inner	⚠️ 221 (+25%)	703 (+4%)	72,411	45,020	N/A
private-kernel-reset-tiny	303 (-2%)	710 (+4%)	65,114	44,886	N/A
private-kernel-tail	168	135	50,608	52,921	N/A
base-parity	5.63	N/A	160	96.0	N/A
root-parity	35.3	N/A	73,948	96.0	N/A
base-rollup	3,215 (+8%)	N/A	189,207	664	N/A
block-root-rollup	41.3 (+1%)	N/A	58,205	2,448	N/A
public-kernel-setup	86.8	N/A	105,085	71,222	N/A
public-kernel-app-logic	97.5 (-1%)	N/A	104,899	71,222	N/A
public-kernel-tail	859	N/A	390,582	16,414	N/A
private-kernel-reset-small	307	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	674 (-13%)	615 (+4%)	455,400	1,825	N/A
public-kernel-teardown	83.3 (-1%)	N/A	105,349	71,222	N/A
merge-rollup	20.3	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	79,674 (-6%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	340 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.4 (+2%)
MultiCallEntrypoint:entrypoint	1,920	11,731	403
FeeJuice:deploy	1,376	11,731	388 (+1%)
SchnorrAccount:constructor	1,312	11,731	72.8
SchnorrAccount:entrypoint	2,336	11,731	385
FeeJuice:claim	1,344	11,731	36.5 (-1%)
Token:privately_mint_private_note	1,280	11,731	100 (-1%)
FPC:fee_entrypoint_public	1,344	11,731	25.3 (-8%)
Token:transfer	1,312	11,731	223
Benchmarking:create_note	1,344	11,731	86.3
SchnorrAccount:verify_private_authwit	1,280	11,731	31.8 (+20%)
Token:unshield	1,376	11,731	541 (+1%)
FPC:fee_entrypoint_private	1,376	11,731	708 (-4%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	49.5 (-1%)	8,174
FeeJuice:set_portal	13.8 (+22%)	4,055
Token:constructor	80.4 (+3%)	23,253
FPC:constructor	51.2	13,111
FeeJuice:check_balance	39.7 (+1%)	5,978
Token:mint_public	505 (+5%)	12,704
Token:assert_minter_and_mint	50.6 (+5%)	8,467
AuthRegistry:set_authorized	47.8	4,194
FPC:prepare_fee	207 (-8%)	6,747
Token:transfer_public	32.8 (+13%)	32,272
FPC:pay_refund	59.9 (+13%)	9,398
Benchmarking:increment_balance	1,231 (+1%)	7,263
Token:_increase_public_balance	40.2 (-4%)	8,686
FPC:pay_refund_with_shielded_rebate	59.4 (-3%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.146 (-5%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.19 (+2%)	3.99 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.114 (+2%)	0.113 (+4%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.5 (+4%)	18.1 (+2%)	30.7	61.8 (+2%)	114 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.110 (+4%)	0.105 (+3%)	0.0997	0.106 (+2%)	0.102 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.6 (+1%)	25.8	43.7	86.0 (+2%)	162 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	107 (-1%)	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.113 (+2%)	0.104	0.105	0.107 (+3%)	0.102 (-2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	17.0 (+2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.109 (+3%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,838	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[fcarreiro]

Merge activity

• Sep 2, 9:49 AM EDT: @fcarreiro merged this pull request with Graphite.