-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. #10487
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
This PR adds V2A-RCM specific request-response models and new optional properties. Since, all the examples have HyperV provider details, so adding these properties/models to examples is not required. |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
@imshashwataggarwal Please also add code owner for review. |
Adding @DevBaburaj, @anmolbhatia289 |
@NullMDR Could you take a look at the JS automation? |
@qiaozha Could you please help on this generation failure: [npmPack] src/models/mappers.ts(17143,3): error TS2300: Duplicate identifier ''ProviderSpecificFailoverInput.InMageRcm''. |
@NullMDR Can you please merge this pr, given JS automation isn't a required check? |
@imshashwataggarwal Could you ask the two people you mentioned to review first? |
Hey @ChenTanyi , internal review within the team is already done. |
@NullMDR @imshashwataggarwal The JS SDK generation failure is because the swagger have two different subclasses Lines 13429 to 13468 in 1be8f90
|
@jianyexi to add a new lint rule that don't allow same discriminator value |
@imshashwataggarwal Please fix the same discrinimator value problem |
@NullMDR We have separate classes for these subclasses: We plan to add that in the next api version. As for now, since JS automation is an optional check, so can you please approve this PR? |
@NullMDR Is it OK to merge? Or is it a serious problem in this change? |
@imshashwataggarwal I am confused, this swagger change is added by you only in this PR which shouldn't have been generated in the SDK, why would it cause other api-version's breaking change? |
Juat confirmed with other languages SDK owners, This the same discriminator value of different subclasses sharing the same parent class should also report error. Therefore, I don't think we should merge it. @NullMDR |
1be8f90
to
0af6fe6
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@NullMDR can you please review now. I have fixed the same discriminator value issue. |
SDK Net generation is successful, just authentication fail. |
@ChenTanyi Please merge. |
…A RCM. (Azure#10487) * Update swagger spec with latest V2A-Rcm changes * Fix spell check
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (21 commits) [Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.HealthcareApis-2020-03-15' to public (Azure#10757) added new api version (Azure#10784) updated apispec (Azure#10719) Bump up version number for "old" preview api (Azure#10768) [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (Azure#10699) [ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. (Azure#10487) Update provisioningStatus field name for assignment (Azure#10754) [Microsoft.ApiManagement][2019-12-01] Content management resources: Collapsed the reference to metadata. (Azure#10755) Add Metrics Advisor API Properties. (Azure#10722) Remove LiveVideoAnalytics Swagger and samples from Azure repo, as this should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796) Update keys.json (Azure#10495) Add new API version 2020-09-01 (Azure#10737) Corrected Examples for Resource Mover to generate documentation examp… (Azure#10791) Add support for filter by deviceId (Azure#10771) Update openapi-authoring-automated-guidelines.md (Azure#10606) Adding request body for listcredential for Microsoft.Kubernetes (Azure#10766) Add new resource to Microsoft.Sql "ServerTrustGroup". (Azure#10705) add alias for auto_rev_minor_version to fix az CLI linter error (Azure#10789) Update workbooks api to include sourceId (Azure#10781) [NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (Azure#10753) ...
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.