Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. #10487

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

imshashwataggarwal
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 17, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 910e0e4 with merge commit 7cf01c8. SDK Automation 13.0.17.20200909.5
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 62b21d8 with merge commit caf19f9c5229888e6e4fc7604d50af6b71acd9d0. SDK Automation 13.0.17.20200807.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 910e0e4 with merge commit 7cf01c8. SDK Automation 13.0.17.20200909.5
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/7800: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:05:21 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0402:49DA:12B4C7:3D6C71:5F6180F1","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4713","x-ratelimit-reset":"1600229025","x-ratelimit-used":"287","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/recoveryservices_mgmt_2018-01-10@10487","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/7801: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:05:22 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0412:13D22:5C10F97:6E65D27:5F6180F1","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4710","x-ratelimit-reset":"1600229025","x-ratelimit-used":"290","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/recoveryservices_mgmt_2018-07-10@10487","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
  • ⚠️recoveryservices/mgmt/2016-08-10 [View full logs
    No file is changed.
  • ️✔️recoveryservices/mgmt/2018-01-10 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:12:20 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:2D7A:7B3BCD:14539A4:5F618293","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️recoveryservices/mgmt/2018-07-10 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:12:33 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:2BD1:296E68A:310CAED:5F6182A0","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 910e0e4 with merge commit 7cf01c8. Schema Automation 13.0.17.20200909.5
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-resource-manager-schemas/pull/39: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:04:06 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"064C:4551:1C318D3:2226085:5F6180A6","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4913","x-ratelimit-reset":"1600229025","x-ratelimit-used":"87","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-resource-manager-schemas/git/refs/heads/sdkAutomation/recoveryservicessiterecovery@10487","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
  • ⚠️recoveryservicessiterecovery [View full logs]  [Release Schema Changes]
      AzureResourceSchema has no registered package commands.
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:07:02 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0703:454F:CF438B:10042F1:5F618156","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 17, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 17, 2020

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 910e0e4 with merge commit 7cf01c8. SDK Automation 13.0.17.20200909.5
    • ️✔️sdk/recoveryservices.siterecovery/mgmt-v2016_08_10 [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:14:40 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:0915:F31A39:282C8B1:5F618320","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    • ️✔️sdk/recoveryservices.siterecovery/mgmt-v2018_01_10 [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:14:52 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0405:4A21:3FC949F:6B29651:5F61832C","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 17, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 910e0e4 with merge commit 7cf01c8. SDK Automation 13.0.17.20200909.5
      Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-js/pull/1689: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:05:28 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0401:021B:3D8D490:67F939B:5F6180F8","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4704","x-ratelimit-reset":"1600229025","x-ratelimit-used":"296","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-js/git/refs/heads/sdkAutomation/@azure_arm-recoveryservices-siterecovery@10487","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    • ️✔️@azure/arm-recoveryservices-siterecovery [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/siteRecoveryManagementClient.js → ./dist/arm-recoveryservices-siterecovery.js...
      [npmPack] created ./dist/arm-recoveryservices-siterecovery.js in 1.3s
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-recoveryservices-siterecovery@3.2.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 1.2MB   dist/arm-recoveryservices-siterecovery.js                          
      [npmPack] npm notice 477.5kB dist/arm-recoveryservices-siterecovery.min.js                      
      [npmPack] npm notice 345B    esm/models/index.js                                                
      [npmPack] npm notice 1.5kB   esm/operations/index.js                                            
      [npmPack] npm notice 516.7kB esm/models/mappers.js                                              
      [npmPack] npm notice 4.8kB   esm/operations/migrationRecoveryPoints.js                          
      [npmPack] npm notice 5.1kB   esm/models/migrationRecoveryPointsMappers.js                       
      [npmPack] npm notice 2.4kB   esm/operations/operations.js                                       
      [npmPack] npm notice 482B    esm/models/operationsMappers.js                                    
      [npmPack] npm notice 7.3kB   esm/models/parameters.js                                           
      [npmPack] npm notice 4.7kB   esm/operations/recoveryPoints.js                                   
      [npmPack] npm notice 5.1kB   esm/models/recoveryPointsMappers.js                                
      [npmPack] npm notice 4.8kB   esm/operations/replicationAlertSettings.js                         
      [npmPack] npm notice 5.2kB   esm/models/replicationAlertSettingsMappers.js                      
      [npmPack] npm notice 3.2kB   esm/operations/replicationEligibilityResultsOperations.js          
      [npmPack] npm notice 603B    esm/models/replicationEligibilityResultsOperationsMappers.js       
      [npmPack] npm notice 3.5kB   esm/operations/replicationEvents.js                                
      [npmPack] npm notice 5.1kB   esm/models/replicationEventsMappers.js                             
      [npmPack] npm notice 17.3kB  esm/operations/replicationFabrics.js                               
      [npmPack] npm notice 5.4kB   esm/models/replicationFabricsMappers.js                            
      [npmPack] npm notice 10.9kB  esm/operations/replicationJobs.js                                  
      [npmPack] npm notice 5.2kB   esm/models/replicationJobsMappers.js                               
      [npmPack] npm notice 4.0kB   esm/operations/replicationLogicalNetworks.js                       
      [npmPack] npm notice 5.1kB   esm/models/replicationLogicalNetworksMappers.js                    
      [npmPack] npm notice 22.3kB  esm/operations/replicationMigrationItems.js                        
      [npmPack] npm notice 5.7kB   esm/models/replicationMigrationItemsMappers.js                     
      [npmPack] npm notice 13.3kB  esm/operations/replicationNetworkMappings.js                       
      [npmPack] npm notice 5.6kB   esm/models/replicationNetworkMappingsMappers.js                    
      [npmPack] npm notice 5.4kB   esm/operations/replicationNetworks.js                              
      [npmPack] npm notice 5.1kB   esm/models/replicationNetworksMappers.js                           
      [npmPack] npm notice 9.1kB   esm/operations/replicationPolicies.js                              
      [npmPack] npm notice 5.4kB   esm/models/replicationPoliciesMappers.js                           
      [npmPack] npm notice 4.5kB   esm/operations/replicationProtectableItems.js                      
      [npmPack] npm notice 5.1kB   esm/models/replicationProtectableItemsMappers.js                   
      [npmPack] npm notice 54.1kB  esm/operations/replicationProtectedItems.js                        
      [npmPack] npm notice 7.8kB   esm/models/replicationProtectedItemsMappers.js                     
      [npmPack] npm notice 17.1kB  esm/operations/replicationProtectionContainerMappings.js           
      [npmPack] npm notice 5.6kB   esm/models/replicationProtectionContainerMappingsMappers.js        
      [npmPack] npm notice 16.2kB  esm/operations/replicationProtectionContainers.js                  
      [npmPack] npm notice 5.6kB   esm/models/replicationProtectionContainersMappers.js               
      [npmPack] npm notice 22.3kB  esm/operations/replicationRecoveryPlans.js                         
      [npmPack] npm notice 5.9kB   esm/models/replicationRecoveryPlansMappers.js                      
      [npmPack] npm notice 15.2kB  esm/operations/replicationRecoveryServicesProviders.js             
      [npmPack] npm notice 5.2kB   esm/models/replicationRecoveryServicesProvidersMappers.js          
      [npmPack] npm notice 12.2kB  esm/operations/replicationStorageClassificationMappings.js         
      [npmPack] npm notice 5.2kB   esm/models/replicationStorageClassificationMappingsMappers.js      
      [npmPack] npm notice 5.8kB   esm/operations/replicationStorageClassifications.js                
      [npmPack] npm notice 5.1kB   esm/models/replicationStorageClassificationsMappers.js             
      [npmPack] npm notice 3.4kB   esm/operations/replicationVaultHealth.js                           
      [npmPack] npm notice 5.1kB   esm/models/replicationVaultHealthMappers.js                        
      [npmPack] npm notice 4.8kB   esm/operations/replicationVaultSetting.js                          
      [npmPack] npm notice 5.2kB   esm/models/replicationVaultSettingMappers.js                       
      [npmPack] npm notice 12.1kB  esm/operations/replicationvCenters.js                              
      [npmPack] npm notice 5.2kB   esm/models/replicationvCentersMappers.js                           
      [npmPack] npm notice 1.0kB   rollup.config.js                                                   
      [npmPack] npm notice 4.1kB   esm/siteRecoveryManagementClient.js                                
      [npmPack] npm notice 3.1kB   esm/siteRecoveryManagementClientContext.js                         
      [npmPack] npm notice 2.0kB   esm/operations/supportedOperatingSystemsOperations.js              
      [npmPack] npm notice 5.1kB   esm/models/supportedOperatingSystemsOperationsMappers.js           
      [npmPack] npm notice 3.3kB   esm/operations/targetComputeSizes.js                               
      [npmPack] npm notice 531B    esm/models/targetComputeSizesMappers.js                            
      [npmPack] npm notice 1.8kB   package.json                                                       
      [npmPack] npm notice 457B    tsconfig.json                                                      
      [npmPack] npm notice 1.8MB   dist/arm-recoveryservices-siterecovery.js.map                      
      [npmPack] npm notice 278.3kB dist/arm-recoveryservices-siterecovery.min.js.map                  
      [npmPack] npm notice 148.3kB esm/models/index.d.ts.map                                          
      [npmPack] npm notice 712B    esm/operations/index.d.ts.map                                      
      [npmPack] npm notice 126B    esm/models/index.js.map                                            
      [npmPack] npm notice 727B    esm/operations/index.js.map                                        
      [npmPack] npm notice 21.4kB  esm/models/mappers.d.ts.map                                        
      [npmPack] npm notice 272.7kB esm/models/mappers.js.map                                          
      [npmPack] npm notice 1.9kB   esm/operations/migrationRecoveryPoints.d.ts.map                    
      [npmPack] npm notice 2.4kB   esm/operations/migrationRecoveryPoints.js.map                      
      [npmPack] npm notice 2.6kB   esm/models/migrationRecoveryPointsMappers.d.ts.map                 
      [npmPack] npm notice 2.6kB   esm/models/migrationRecoveryPointsMappers.js.map                   
      [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                                 
      [npmPack] npm notice 1.5kB   esm/operations/operations.js.map                                   
      [npmPack] npm notice 225B    esm/models/operationsMappers.d.ts.map                              
      [npmPack] npm notice 238B    esm/models/operationsMappers.js.map                                
      [npmPack] npm notice 1.7kB   esm/models/parameters.d.ts.map                                     
      [npmPack] npm notice 5.5kB   esm/models/parameters.js.map                                       
      [npmPack] npm notice 1.8kB   esm/operations/recoveryPoints.d.ts.map                             
      [npmPack] npm notice 2.4kB   esm/operations/recoveryPoints.js.map                               
      [npmPack] npm notice 2.6kB   esm/models/recoveryPointsMappers.d.ts.map                          
      [npmPack] npm notice 2.6kB   esm/models/recoveryPointsMappers.js.map                            
      [npmPack] npm notice 1.9kB   esm/operations/replicationAlertSettings.d.ts.map                   
      [npmPack] npm notice 2.8kB   esm/operations/replicationAlertSettings.js.map                     

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 17, 2020

    azure-sdk-for-net - Release

    failed [Logs] [Expand Details]
    • Generate from 910e0e4 with merge commit 7cf01c8. SDK Automation 13.0.17.20200909.5
      Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-net/pull/1540: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:04:23 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"068E:8B08:B0240C:E00868:5F6180B6","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4836","x-ratelimit-reset":"1600229025","x-ratelimit-used":"164","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-net/git/refs/heads/sdkAutomation/Microsoft.Azure.Management.RecoveryServices.SiteRecovery@10487","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
    • Microsoft.Azure.Management.RecoveryServices.SiteRecovery [View full logs]  [Release SDK Changes]
        Failed to create the package Microsoft.Azure.Management.RecoveryServices.SiteRecovery.
        Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=recoveryservices-siterecovery /v:n /p:SkipTests=true , {} 
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:10:09 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C0:454E:98A047:BA7D90:5F618211","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @imshashwataggarwal
      Copy link
      Contributor Author

      This PR adds V2A-RCM specific request-response models and new optional properties. Since, all the examples have HyperV provider details, so adding these properties/models to examples is not required.

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      1 similar comment
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 17, 2020

      azure-sdk-for-python-track2 - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @ChenTanyi
      Copy link
      Contributor

      @imshashwataggarwal Please also add code owner for review.

      @imshashwataggarwal
      Copy link
      Contributor Author

      Adding @DevBaburaj, @anmolbhatia289

      @ChenTanyi
      Copy link
      Contributor

      @NullMDR Could you take a look at the JS automation?

      @PhoenixHe-NV
      Copy link
      Contributor

      @qiaozha Could you please help on this generation failure:

      [npmPack] src/models/mappers.ts(17143,3): error TS2300: Duplicate identifier ''ProviderSpecificFailoverInput.InMageRcm''.

      @imshashwataggarwal
      Copy link
      Contributor Author

      @NullMDR Can you please merge this pr, given JS automation isn't a required check?

      @ChenTanyi
      Copy link
      Contributor

      @imshashwataggarwal Could you ask the two people you mentioned to review first?

      @anmolbhatia289
      Copy link
      Contributor

      Hey @ChenTanyi , internal review within the team is already done.

      @qiaozha
      Copy link
      Member

      qiaozha commented Aug 20, 2020

      @NullMDR @imshashwataggarwal The JS SDK generation failure is because the swagger have two different subclasses InMageRcmTestFailoverInput, InMageRcmUnplannedFailoverInput of ProviderSpecificFailoverInput but with the same x-ms-discriminator-value InMageRcm. I don't think that's allowed.

      "InMageRcmTestFailoverInput": {
      "description": "InMageRcm provider specific input for test failover.",
      "type": "object",
      "allOf": [
      {
      "$ref": "#/definitions/ProviderSpecificFailoverInput"
      }
      ],
      "properties": {
      "networkId": {
      "description": "The test network Id.",
      "type": "string"
      },
      "recoveryPointId": {
      "description": "The recovery point id to be passed to test failover to a particular recovery point. In case of latest recovery point, null should be passed.",
      "type": "string"
      }
      },
      "x-ms-discriminator-value": "InMageRcm"
      },
      "InMageRcmUnplannedFailoverInput": {
      "description": "InMageRcm provider specific input for unplanned failover.",
      "type": "object",
      "allOf": [
      {
      "$ref": "#/definitions/ProviderSpecificFailoverInput"
      }
      ],
      "properties": {
      "performShutdown": {
      "description": "A value indicating whether VM is to be shutdown.",
      "type": "string"
      },
      "recoveryPointId": {
      "description": "The recovery point id to be passed to failover to a particular recovery point. In case of latest recovery point, null should be passed.",
      "type": "string"
      }
      },
      "x-ms-discriminator-value": "InMageRcm"
      },

      @PhoenixHe-NV PhoenixHe-NV added the LintRuleCandidate Lint Rule Candidate label Aug 20, 2020
      @PhoenixHe-NV
      Copy link
      Contributor

      @jianyexi to add a new lint rule that don't allow same discriminator value

      @PhoenixHe-NV
      Copy link
      Contributor

      @imshashwataggarwal Please fix the same discrinimator value problem

      @imshashwataggarwal
      Copy link
      Contributor Author

      @NullMDR We have separate classes for these subclasses: InMageRcmTestFailoverInput, InMageRcmUnplannedFailoverInput instead of a common class ProviderSpecificFailoverInput in rhe service code. However, if we add them to current swagger version, it will lead us to change it for all providers and that will be a breaking change (rename of properties).

      We plan to add that in the next api version. As for now, since JS automation is an optional check, so can you please approve this PR?

      @ChenTanyi
      Copy link
      Contributor

      @NullMDR Is it OK to merge? Or is it a serious problem in this change?

      @qiaozha
      Copy link
      Member

      qiaozha commented Aug 24, 2020

      @NullMDR We have separate classes for these subclasses: InMageRcmTestFailoverInput, InMageRcmUnplannedFailoverInput instead of a common class ProviderSpecificFailoverInput in rhe service code. However, if we add them to current swagger version, it will lead us to change it for all providers and that will be a breaking change (rename of properties).

      We plan to add that in the next api version. As for now, since JS automation is an optional check, so can you please approve this PR?

      @imshashwataggarwal I am confused, this swagger change is added by you only in this PR which shouldn't have been generated in the SDK, why would it cause other api-version's breaking change?

      @qiaozha
      Copy link
      Member

      qiaozha commented Aug 24, 2020

      Juat confirmed with other languages SDK owners, This the same discriminator value of different subclasses sharing the same parent class should also report error. Therefore, I don't think we should merge it. @NullMDR

      @PhoenixHe-NV PhoenixHe-NV added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Aug 24, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @imshashwataggarwal
      Copy link
      Contributor Author

      imshashwataggarwal commented Sep 15, 2020

      @NullMDR can you please review now. I have fixed the same discriminator value issue.

      @ChenTanyi
      Copy link
      Contributor

      SDK Net generation is successful, just authentication fail.
      @imshashwataggarwal It is OK to merge since all CI pass. Please let me know when you want to merge.

      image

      @imshashwataggarwal
      Copy link
      Contributor Author

      @ChenTanyi Please merge.

      @ChenTanyi ChenTanyi merged commit 7cf01c8 into Azure:master Sep 16, 2020
      nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
      …A RCM. (Azure#10487)
      
      * Update swagger spec with latest V2A-Rcm changes
      
      * Fix spell check
      iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 14, 2020
      …into formrecognizer_regeneration
      
      * 'master' of https://github.com/Azure/azure-rest-api-specs: (21 commits)
        [Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.HealthcareApis-2020-03-15' to public (Azure#10757)
        added new api version (Azure#10784)
        updated apispec (Azure#10719)
        Bump up version number for "old" preview api (Azure#10768)
        [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (Azure#10699)
        [ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. (Azure#10487)
        Update provisioningStatus field name for assignment (Azure#10754)
        [Microsoft.ApiManagement][2019-12-01] Content management resources: Collapsed the reference to metadata. (Azure#10755)
        Add Metrics Advisor API Properties. (Azure#10722)
        Remove LiveVideoAnalytics Swagger and samples from Azure repo, as this should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796)
        Update keys.json (Azure#10495)
        Add new API version 2020-09-01 (Azure#10737)
        Corrected Examples for Resource Mover to generate documentation examp… (Azure#10791)
        Add support for filter by deviceId (Azure#10771)
        Update openapi-authoring-automated-guidelines.md (Azure#10606)
        Adding request body for listcredential for Microsoft.Kubernetes (Azure#10766)
        Add new resource to Microsoft.Sql "ServerTrustGroup". (Azure#10705)
        add alias for auto_rev_minor_version to fix az CLI linter error (Azure#10789)
        Update workbooks api to include sourceId (Azure#10781)
        [NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (Azure#10753)
        ...
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      LintRuleCandidate Lint Rule Candidate Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      6 participants