-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update provisioningStatus field name for assignment #10754
Conversation
Merge from master
Merge from upstream Azure
Merge from upstream
Swagger pipeline can not start as the pull request has merge conflicts. |
Pull request contains merge conflicts. |
Swagger pipeline can not start as the pull request has merge conflicts. |
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'provisioningStatus' renamed or removed? New: Microsoft.Automanage/preview/2020-06-30-preview/automanage.json#L1084:7 Old: Microsoft.Automanage/preview/2020-06-30-preview/automanage.json#L1084:7 |
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'provisioningStatus' renamed or removed? New: Microsoft.Automanage/preview/2020-06-30-preview/automanage.json#L1084:7 Old: Microsoft.Automanage/preview/2020-06-30-preview/automanage.json#L1084:7 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
|
azure-resource-manager-schemas - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Breaking change is intended. This is not yet released to any customer. |
@abhinav-ghai Could you ask a code owner or someone in your team to review it? |
...manage/preview/2020-06-30-preview/examples/createOrUpdateConfigurationProfileAssignment.json
Show resolved
Hide resolved
Done, reviewed by Stephen Owen from Automanage team |
@abhinav-ghai please fix the merge conflict. |
Pull request contains merge conflicts. |
Azure Pipelines successfully started running 1 pipeline(s). |
* Add list and get software to GuestConfiguration * Use newer API version for software * Revert software Swagger spec since these are private preview only * Add Automanage resource provider * Address validation tool errors * spelling add antimalware * Address lint errors * Fix error response * Fix newline * Fix Operations API Lint * Fix operations example * Fix prettier and lint * Address lint and prettier errors * Use common definitions and correct pref enum * Fix parameter * Address comments * Fix update examples * Prettier fix * Fix python md * Change provisioningStatus field name * Fix config profile name in examples * resolve conflict * Address conflict Co-authored-by: Abhinav Ghai <abghai@microsoft.com> Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (21 commits) [Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.HealthcareApis-2020-03-15' to public (Azure#10757) added new api version (Azure#10784) updated apispec (Azure#10719) Bump up version number for "old" preview api (Azure#10768) [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (Azure#10699) [ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. (Azure#10487) Update provisioningStatus field name for assignment (Azure#10754) [Microsoft.ApiManagement][2019-12-01] Content management resources: Collapsed the reference to metadata. (Azure#10755) Add Metrics Advisor API Properties. (Azure#10722) Remove LiveVideoAnalytics Swagger and samples from Azure repo, as this should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796) Update keys.json (Azure#10495) Add new API version 2020-09-01 (Azure#10737) Corrected Examples for Resource Mover to generate documentation examp… (Azure#10791) Add support for filter by deviceId (Azure#10771) Update openapi-authoring-automated-guidelines.md (Azure#10606) Adding request body for listcredential for Microsoft.Kubernetes (Azure#10766) Add new resource to Microsoft.Sql "ServerTrustGroup". (Azure#10705) add alias for auto_rev_minor_version to fix az CLI linter error (Azure#10789) Update workbooks api to include sourceId (Azure#10781) [NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (Azure#10753) ...
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.