Add new API version 2020-09-01 #10737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Sep 9, 2020
Closed
Closed
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
bgklein
reviewed
Sep 9, 2020
| @@ -5951,7 +5951,7 @@ | |||
| }, | |||
| "description": "A response containing the Task counts for the specified Job.", | |||
| "schema": { | |||
| "$ref": "#/definitions/TaskCounts" | |||
| "$ref": "#/definitions/TaskCountsResult" | |||
| "requiredSlots": { | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "title": "The number of scheduling slots that the Task required to run.", |
There was a problem hiding this comment.
Suggested change
| "title": "The number of scheduling slots that the Task required to run.", | |
| "title": "The number of scheduling slots that the Task requires to run.", |
| } | ||
| }, | ||
| "title": "A reference to an Azure Virtual Machines Marketplace Image or a custom Azure Virtual Machine Image. To get the list of all Azure Marketplace Image references verified by Azure Batch, see the 'List supported Images' operation." | ||
| "title": "A reference to an Azure Virtual Machines Marketplace Image or a bring-your-own Shared Image Gallery Image. To get the list of all Azure Marketplace Image references verified by Azure Batch, see the 'List Supported Images' operation." |
There was a problem hiding this comment.
probably don't need bring-your-own here as its implied
| "requiredSlots": { | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "title": "The number of scheduling slots that the Task required to run.", |
chiragg4u
approved these changes
Sep 9, 2020
chiragg4u
added
ARMSignedOff
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@chiragg4u, I had updated the comments base on feedback. Please merge it when you are available. |
|
@xingwu1 are these APIs live? |
bgklein
approved these changes
Sep 15, 2020
|
@jhendrixMSFT , it is live on most regions. It is OK to let it merge, since we still need time to release SDK. |
jhendrixMSFT
approved these changes
Sep 15, 2020
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
* Add previous API version as baseline. * Add new data plane API version 2020-09-01 * Update management plane with new API 2020-09-01. * Update readme to add new API version. * Fix example errors. * Update comment based on feedback
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Oct 14, 2020
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (21 commits) [Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.HealthcareApis-2020-03-15' to public (Azure#10757) added new api version (Azure#10784) updated apispec (Azure#10719) Bump up version number for "old" preview api (Azure#10768) [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (Azure#10699) [ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. (Azure#10487) Update provisioningStatus field name for assignment (Azure#10754) [Microsoft.ApiManagement][2019-12-01] Content management resources: Collapsed the reference to metadata. (Azure#10755) Add Metrics Advisor API Properties. (Azure#10722) Remove LiveVideoAnalytics Swagger and samples from Azure repo, as this should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796) Update keys.json (Azure#10495) Add new API version 2020-09-01 (Azure#10737) Corrected Examples for Resource Mover to generate documentation examp… (Azure#10791) Add support for filter by deviceId (Azure#10771) Update openapi-authoring-automated-guidelines.md (Azure#10606) Adding request body for listcredential for Microsoft.Kubernetes (Azure#10766) Add new resource to Microsoft.Sql "ServerTrustGroup". (Azure#10705) add alias for auto_rev_minor_version to fix az CLI linter error (Azure#10789) Update workbooks api to include sourceId (Azure#10781) [NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (Azure#10753) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.