Add Red Hat OpenShift 2021-09-01-preview #15616
Conversation
mjudeikis
requested review from
00Kai0,
ArcturusZhang,
jsntcy,
msyyc and
RAY-316
as code owners
|
Hi, @mjudeikis Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @mjudeikis your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Generation Artifacts
|
|
Same PR as in https://github.com/Azure/azure-rest-api-specs-pr/pull/4459 because I can't get anybody to look into it. |
|
Hi @mjudeikis, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hey, On the failures - I would like some guidance whats needs to be changed in the swagger itself to be compliant. Especially with sytemData failure as it looks like we have everything in there what is required. Would be nice if somebody would help to identify what is wrong, and not just saying its wrong. |
|
I think the item is quite clear, you do not have |
|
@weidongxu-microsoft added it again, and now getting error: So what is different? |
|
The My idea is that your example JSON is wrong. Please double check whether service really need to read the |
Yes, this is right. Based on ARM requirement system data we inject from ARM headers.
It does not. But if we remove it - we get one error that we are missing one. If we add we get this error. So both ways failure. And example I pasted from I would gladly change either way and adjust our RP behavior, if I would know what is wrong here. (Don't get me wrong, If I would know what to change I would. We look to other APIs and read rest spec requirements and I think we did how it should be, but its still failing on both cases) |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
I don't know. I think mediaservices does not have And in this example, |
Got ya! I think I got this. Let me try to regenerate and see if this works. Thanks for helping here.. Really appreciate. |
|
@weidongxu-microsoft now looks like unrelated ci failures? |
|
@msyyc Would you or some other from Python SDK to have a look on the python build failure? The message seems not informative. |
...t/resource-manager/Microsoft.RedHatOpenShift/preview/2021-01-31-preview/redhatopenshift.json
Outdated
Show resolved
Hide resolved
| ], | ||
| "type": "string", | ||
| "x-ms-enum": { | ||
| "name": "SDNProvider", |
| "NetworkProfile": { | ||
| "description": "NetworkProfile represents a network profile.", | ||
| "properties": { | ||
| "sdnProvider": { |
There was a problem hiding this comment.
|
@weidongxu-microsoft good to merge |
…2020-04-30 to version 2021-01-31-preview
…1-preview' of github.com:mjudeikis/azure-rest-api-specs into dev-redhatopenshift-Microsoft.RedHatOpenShift-2021-01-31-preview
mjudeikis
force-pushed
the
dev-redhatopenshift-Microsoft.RedHatOpenShift-2021-01-31-preview
branch
from
6572b89 to
2538157
Compare
…into add_endpoint * 'main' of https://github.com/Azure/azure-rest-api-specs: (5079 commits) Add Microsoft.ExtendedLocation [CustomLocation] 2021-08-15 stable API Version (Azure#15967) Updated SKU property to be read only (Azure#15965) Add Microsoft.Communication.UserDisconnected Event (Azure#15870) Add collection APIs (Azure#15221) [Cognitive Services - Personalizer] v1.1-preview.2 (Azure#15699) Adding default error response & updating basePath (Azure#15784) Update readme and readme.python (Azure#15973) add synapse batch tag package-composite-v1 (Azure#15974) Microsoft.BareMetalInfrastructure: add stable API version 2021-08-09 (Azure#15680) change readme.go.md template to track 2 (Azure#15972) [CosmosDB] Adding apiVersion 2021-07-01-preview (Azure#14817) Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (Azure#15954) DiskRP swagger for 2021-04-01 (Azure#15665) Use IncidentSeverity in IncidentInfo (Azure#15762) Add stable API version "2021-09-01" (Azure#15897) add-purview-typescript-file (Azure#15948) Swagger Completeness for Microsoft.Authorization (Azure#15253) [Hub Generated] Review request for Microsoft.Aadiam to add version preview/2020-03-01-preview and stable/2020-03-01 (Azure#15861) Add swagger for missing CheckPolicyRestrictions API version (Azure#15888) Add Red Hat OpenShift 2021-09-01-preview (Azure#15616) ...
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:https://aka.ms/openapiportal
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.