Updated SKU property to be read only #15965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @shaileshsk94 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/stable/2021-07-01/purview.json#L672 |
|
The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/stable/2021-07-01/purview.json#L720 |
|
The response of operation:'Accounts_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L117 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L623 |
|
The response of operation:'Accounts_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L158 |
|
The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L671 |
|
The response of operation:'Accounts_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L260 |
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Purview/stable/2021-07-01/purview.json#L1414 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Purview/stable/2021-07-01/purview.json#L1766 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1374 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1714 |
|
| The summary and description values should not be same. Location: Microsoft.Purview/stable/2021-07-01/purview.json#L475 |
|
| The summary and description values should not be same. Location: Microsoft.Purview/stable/2021-07-01/purview.json#L518 |
|
| The summary and description values should not be same. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L426 |
|
| The summary and description values should not be same. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L469 |
|
| OperationId should contain the verb: 'setdefaultaccount' in:'DefaultAccounts_Set'. Consider updating the operationId Location: Microsoft.Purview/stable/2021-07-01/purview.json#L481 |
|
| OperationId should contain the verb: 'removedefaultaccount' in:'DefaultAccounts_Remove'. Consider updating the operationId Location: Microsoft.Purview/stable/2021-07-01/purview.json#L524 |
|
| OperationId should contain the verb: 'setdefaultaccount' in:'DefaultAccounts_Set'. Consider updating the operationId Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L432 |
|
| OperationId should contain the verb: 'removedefaultaccount' in:'DefaultAccounts_Remove'. Consider updating the operationId Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L475 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Purview/stable/2021-07-01/purview.json#L1525 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1473 |
|
| 'CloudConnectors' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Purview/stable/2021-07-01/purview.json#L1239 |
|
| 'CloudConnectors' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1141 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 2 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"purview/resource-manager/readme.md", "tag":"package-2020-12-01-preview", "details":"Error: Plugin pre-namer reported failure." |
|
"readme":"purview/resource-manager/readme.md", "tag":"package-2021-07-01", "details":"Error: Plugin pre-namer reported failure." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @shaileshsk94, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
JeffreyRichter
added
the
Approved-BreakingChange
|
Three checks failed. |
qwordy
approved these changes
Sep 9, 2021
@jianyexi @msyyc @ArcturusZhang please help check |
msyyc
requested review from
00Kai0,
jsntcy,
msyyc and
RAY-316
as code owners
|
python pipeline failure is fixed. |
|
please ignore the 'sdk track2 validation' failure , since there's no impact for SDK |
This was referenced Sep 10, 2021
Merged
Closed
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Sep 10, 2021
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Sep 10, 2021
…into add_endpoint * 'main' of https://github.com/Azure/azure-rest-api-specs: (5079 commits) Add Microsoft.ExtendedLocation [CustomLocation] 2021-08-15 stable API Version (Azure#15967) Updated SKU property to be read only (Azure#15965) Add Microsoft.Communication.UserDisconnected Event (Azure#15870) Add collection APIs (Azure#15221) [Cognitive Services - Personalizer] v1.1-preview.2 (Azure#15699) Adding default error response & updating basePath (Azure#15784) Update readme and readme.python (Azure#15973) add synapse batch tag package-composite-v1 (Azure#15974) Microsoft.BareMetalInfrastructure: add stable API version 2021-08-09 (Azure#15680) change readme.go.md template to track 2 (Azure#15972) [CosmosDB] Adding apiVersion 2021-07-01-preview (Azure#14817) Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (Azure#15954) DiskRP swagger for 2021-04-01 (Azure#15665) Use IncidentSeverity in IncidentInfo (Azure#15762) Add stable API version "2021-09-01" (Azure#15897) add-purview-typescript-file (Azure#15948) Swagger Completeness for Microsoft.Authorization (Azure#15253) [Hub Generated] Review request for Microsoft.Aadiam to add version preview/2020-03-01-preview and stable/2020-03-01 (Azure#15861) Add swagger for missing CheckPolicyRestrictions API version (Azure#15888) Add Red Hat OpenShift 2021-09-01-preview (Azure#15616) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.