-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CosmosDB] Adding apiVersion 2021-07-01-preview #14817
Conversation
Hi, @ajparule Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
Per the Noun_Verb convention for Operation Ids, the noun 'GraphResources' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L1568 |
|
Since operation 'LocationList' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5211 |
|
'GET' operation 'LocationList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5211 |
|
'GET' operation 'LocationGet' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5247 |
|
'PUT' operation 'CassandraResources_UpdateCassandraViewThroughput' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5489 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L9487 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DocumentDB/preview/2021-07-01-preview/managedCassandra.json#L781 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DocumentDB/preview/2021-07-01-preview/managedCassandra.json#L997 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DocumentDB/preview/2021-07-01-preview/managedCassandra.json#L1064 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5539 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5588 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/managedCassandra.json#L341 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'GraphResources_CreateUpdateGraph' Request Model: 'GraphResourceCreateUpdateParameters' Response Model: 'GraphResourceGetResults' Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L1520 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'CassandraResources_CreateUpdateCassandraView' Request Model: 'CassandraViewCreateUpdateParameters' Response Model: 'CassandraViewGetResults' Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5358 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'CassandraResources_UpdateCassandraViewThroughput' Request Model: 'ThroughputSettingsUpdateParameters' Response Model: 'ThroughputSettingsGetResults' Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5488 |
|
OperationId should contain the verb: 'migratetoautoscale' in:'CassandraResources_MigrateCassandraViewToAutoscale'. Consider updating the operationId Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5541 |
|
OperationId should contain the verb: 'migratetomanualthroughput' in:'CassandraResources_MigrateCassandraViewToManualThroughput'. Consider updating the operationId Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L5590 |
|
The child tracked resource, 'graphs' with immediate parent 'DatabaseAccountGetResults', must have a list by immediate parent operation. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L6123 |
|
The child tracked resource, 'views' with immediate parent 'CassandraKeyspaceGetResults', must have a list by immediate parent operation. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L6580 |
|
The child tracked resource, 'backups' with immediate parent 'ClusterResource', must have a list by immediate parent operation. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/managedCassandra.json#L988 |
|
The child tracked resource, 'dataCenters' with immediate parent 'ClusterResource', must have a list by immediate parent operation. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/managedCassandra.json#L1055 |
|
The child tracked resource, 'services' with immediate parent 'DatabaseAccountGetResults', must have a list by immediate parent operation. Location: Microsoft.DocumentDB/preview/2021-07-01-preview/services.json#L288 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: supportsAvailabilityZone Location: Microsoft.DocumentDB/preview/2021-07-01-preview/cosmos-db.json#L9508 |
The following errors/warnings exist before current PR submission:
Only 23 items are listed, please refer to log for more details.
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The JSON file has a circular reference. readme: specification/cosmos-db/resource-manager/readme.md json: Microsoft.DocumentDB/preview/2021-07-01-preview/privateEndpointConnection.json |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
Cross-Version Breaking Changes: 5 Errors, 25 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.0)
- current:preview/2021-07-01-preview/cosmos-db.json compared with base:stable/2021-06-15/cosmos-db.json
- current:preview/2021-07-01-preview/cosmos-db.json compared with base:preview/2021-04-01-preview/cosmos-db.json
- current:preview/2021-07-01-preview/managedCassandra.json compared with base:preview/2021-04-01-preview/managedCassandra.json
- current:preview/2021-07-01-preview/notebook.json compared with base:stable/2021-06-15/notebook.json
- current:preview/2021-07-01-preview/notebook.json compared with base:preview/2021-04-01-preview/notebook.json
- current:preview/2021-07-01-preview/privateEndpointConnection.json compared with base:stable/2021-06-15/privateEndpointConnection.json
- current:preview/2021-07-01-preview/privateEndpointConnection.json compared with base:preview/2021-04-01-preview/privateEndpointConnection.json
- current:preview/2021-07-01-preview/privateLinkResources.json compared with base:stable/2021-06-15/privateLinkResources.json
- current:preview/2021-07-01-preview/privateLinkResources.json compared with base:preview/2021-04-01-preview/privateLinkResources.json
- current:preview/2021-07-01-preview/rbac.json compared with base:stable/2021-06-15/rbac.json
- current:preview/2021-07-01-preview/rbac.json compared with base:preview/2021-04-01-preview/rbac.json
- current:preview/2021-07-01-preview/restorable.json compared with base:stable/2021-06-15/restorable.json
- current:preview/2021-07-01-preview/restorable.json compared with base:preview/2021-04-01-preview/restorable.json
- current:preview/2021-07-01-preview/services.json compared with base:preview/2021-04-01-preview/services.json
The following breaking changes are detected by comparison with latest preview version:
Only 23 items are listed, please refer to log for more details.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"cosmos-db/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'DatabaseAccountGetResults' has a property 'identity' that is already declared the parent schema 'ARMResourceProperties' but isn't significantly different. The property has been removed from DatabaseAccountGetResults" |
|
"readme":"cosmos-db/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'DatabaseAccountCreateUpdateParameters' has a property 'identity' that is already declared the parent schema 'ARMResourceProperties' but isn't significantly different. The property has been removed from DatabaseAccountCreateUpdateParameters" |
|
💬 AutorestCore/Exception | "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
💬 AutorestCore/Exception | "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Rule | Message |
---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=251969&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌
[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌
azure-sdk-for-python-track2 - track2_azure-mgmt-cosmosdb - Approved - 6.4.0+ Parameter create_mode of model DatabaseAccountCreateUpdateParameters is now required
️✔️
azure-sdk-for-go - cosmos-db/mgmt/2021-05-15/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - cosmos-db/mgmt/2021-04-15/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - cosmos-db/mgmt/2021-03-15/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - cosmos-db/mgmt/2021-01-15/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - cosmos-db/mgmt/2019-08-01/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - cosmos-db/mgmt/2015-04-08/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - preview/cosmos-db/mgmt/2021-04-01-preview/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - preview/cosmos-db/mgmt/2021-03-01-preview/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - preview/cosmos-db/mgmt/2020-09-01-preview/documentdb - Approved - v57.1.0❌
azure-sdk-for-go - preview/cosmos-db/mgmt/2020-06-01-preview/documentdb - Approved - v57.1.0+ Field `Identity` of struct `RestorableDatabaseAccountGetResult` has been removed + Field `Identity` of struct `RestorableMongodbCollectionGetResult` has been removed + Field `Identity` of struct `RestorableMongodbDatabaseGetResult` has been removed + Field `Identity` of struct `RestorableSQLContainerGetResult` has been removed + Field `Identity` of struct `RestorableSQLDatabaseGetResult` has been removed + Field `Location` of struct `RestorableMongodbCollectionGetResult` has been removed + Field `Location` of struct `RestorableMongodbDatabaseGetResult` has been removed + Field `Location` of struct `RestorableSQLContainerGetResult` has been removed + Field `Location` of struct `RestorableSQLDatabaseGetResult` has been removed + Field `Tags` of struct `RestorableDatabaseAccountGetResult` has been removed + Field `Tags` of struct `RestorableMongodbCollectionGetResult` has been removed + Field `Tags` of struct `RestorableMongodbDatabaseGetResult` has been removed + Field `Tags` of struct `RestorableSQLContainerGetResult` has been removed + Field `Tags` of struct `RestorableSQLDatabaseGetResult` has been removed + Struct `DefaultErrorResponse` has been removed
️✔️
azure-sdk-for-go - preview/cosmos-db/mgmt/2020-04-01-preview/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - preview/cosmos-db/mgmt/2020-03-01-preview/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - preview/cosmos-db/mgmt/2019-12-12-preview/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - preview/cosmos-db/mgmt/2019-08-01-preview/documentdb - Approved - v57.1.0️✔️
azure-sdk-for-go - cosmos-db/mgmt/2021-06-15/documentdb - Approved - v57.1.0❌
azure-sdk-for-go-track2 - armcosmos - 0.3.0+ Field `Identity` of struct `DatabaseAccountCreateUpdateParameters` has been removed + Field `Identity` of struct `DatabaseAccountGetResults` has been removed + Function `DatabaseAccountCreateUpdateProperties.MarshalJSON` has been removed + Type of `DatabaseAccountCreateUpdateParameters.Properties` has been changed from `*DatabaseAccountCreateUpdateProperties` to `DatabaseAccountCreateUpdatePropertiesClassification`
️✔️
azure-sdk-for-go - preview/cosmos-db/mgmt/2021-07-01-preview/documentdb - Approved - v57.1.0️⚠️
azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️
track2_azure-mgmt-cosmosdb [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model SqlTriggerCreateUpdateParameters has a new parameter identity info [Changelog] - Model CassandraTableGetResults has a new parameter identity info [Changelog] - Model SqlContainerCreateUpdateParameters has a new parameter identity info [Changelog] - Model ARMResourceProperties has a new parameter identity info [Changelog] - Model GremlinGraphGetResults has a new parameter identity info [Changelog] - Model TableGetResults has a new parameter identity info [Changelog] - Model DatabaseAccountUpdateParameters has a new parameter diagnostic_log_settings info [Changelog] - Model CassandraTableCreateUpdateParameters has a new parameter identity info [Changelog] - Model CassandraKeyspaceCreateUpdateParameters has a new parameter identity info [Changelog] - Model TableCreateUpdateParameters has a new parameter identity info [Changelog] - Model SqlDatabaseGetResults has a new parameter identity info [Changelog] - Model MongoDBDatabaseGetResults has a new parameter identity info [Changelog] - Model GremlinGraphCreateUpdateParameters has a new parameter identity info [Changelog] - Model DatabaseAccountGetResults has a new parameter diagnostic_log_settings info [Changelog] - Model PeriodicModeProperties has a new parameter backup_storage_redundancy info [Changelog] - Model DatabaseAccountCreateUpdateParameters has a new parameter diagnostic_log_settings info [Changelog] - Model SqlUserDefinedFunctionGetResults has a new parameter identity info [Changelog] - Model SqlStoredProcedureCreateUpdateParameters has a new parameter identity info [Changelog] - Model MongoDBCollectionCreateUpdateParameters has a new parameter identity info [Changelog] - Model SqlDatabaseCreateUpdateParameters has a new parameter identity info [Changelog] - Model GremlinDatabaseGetResults has a new parameter identity info [Changelog] - Model MongoDBCollectionGetResults has a new parameter identity info [Changelog] - Model SqlContainerGetResults has a new parameter identity info [Changelog] - Model SqlStoredProcedureGetResults has a new parameter identity info [Changelog] - Model ThroughputSettingsGetResults has a new parameter identity info [Changelog] - Model ThroughputSettingsUpdateParameters has a new parameter identity info [Changelog] - Model SqlUserDefinedFunctionCreateUpdateParameters has a new parameter identity info [Changelog] - Model GremlinDatabaseCreateUpdateParameters has a new parameter identity info [Changelog] - Model CassandraKeyspaceGetResults has a new parameter identity info [Changelog] - Model MongoDBDatabaseCreateUpdateParameters has a new parameter identity info [Changelog] - Model SqlTriggerGetResults has a new parameter identity info [Changelog] - Added operation CassandraResourcesOperations.get_cassandra_view_throughput info [Changelog] - Added operation CassandraResourcesOperations.begin_migrate_cassandra_view_to_manual_throughput info [Changelog] - Added operation CassandraResourcesOperations.begin_update_cassandra_view_throughput info [Changelog] - Added operation CassandraResourcesOperations.begin_create_update_cassandra_view info [Changelog] - Added operation CassandraResourcesOperations.list_cassandra_views info [Changelog] - Added operation CassandraResourcesOperations.get_cassandra_view info [Changelog] - Added operation CassandraResourcesOperations.begin_delete_cassandra_view info [Changelog] - Added operation CassandraResourcesOperations.begin_migrate_cassandra_view_to_autoscale info [Changelog] - Added operation group CosmosDBManagementClientOperationsMixin info [Changelog] - Added operation group CassandraDataCentersOperations info [Changelog] - Added operation group CassandraClustersOperations info [Changelog] - Added operation group ServiceOperations info [Changelog] - Added operation group GraphResourcesOperations info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Parameter create_mode of model DatabaseAccountCreateUpdateParameters is now required
️️✔️
azure-sdk-for-net-track2 succeeded [Detail] [Expand]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn File azure-sdk-for-net_tmp/initOutput.json not found to read command pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️
Azure.ResourceManager.CosmosDB [View full logs] [Release SDK Changes]- Azure.ResourceManager.CosmosDB.1.0.0-alpha.20210909.1.nupkg
- Azure.ResourceManager.CosmosDB.1.0.0-alpha.20210909.1.symbols.nupkg
info [Changelog]
️⚠️
azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-09-09 03:11:28 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-cosmos-generated" cmderr [generate.py] 2021-09-09 03:11:28 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-09-09 03:11:28 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.36 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/cosmos/azure-resourcemanager-cosmos-generated --java.namespace=com.azure.resourcemanager.cosmos.generated --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md cmderr [generate.py] 2021-09-09 03:12:16 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-09-09 03:12:16 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-09-09 03:12:16 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-09-09 03:12:16 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-09-09 03:12:16 INFO [POM][Skip] pom already has module sdk/cosmos cmderr [generate.py] 2021-09-09 03:12:16 INFO [POM][Success] Write to root pom
️✔️
azure-resourcemanager-cosmos-generated [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-cosmos-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-cosmos-generated-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
cmderr [Inst] 2021-09-09 03:14:54 DEBUG Got artifact_id: azure-resourcemanager-cosmos-generated cmderr [Inst] 2021-09-09 03:14:54 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-09-09 03:14:54 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-sources.jar cmderr [Inst] 2021-09-09 03:14:54 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-javadoc.jar cmderr [Inst] 2021-09-09 03:14:54 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-09-09 03:14:54 DEBUG Match jar package: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-09-09 03:14:54 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14817/azure-sdk-for-java/azure-resourcemanager-cosmos-generated/azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-cosmos-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️
cosmos-db/mgmt/2021-06-15/documentdb [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️
cosmos-db/mgmt/2021-05-15/documentdb [View full logs]info [Changelog] No exported changes
️✔️
cosmos-db/mgmt/2021-04-15/documentdb [View full logs]info [Changelog] This is a new package
️✔️
cosmos-db/mgmt/2021-03-15/documentdb [View full logs]info [Changelog] No exported changes
️✔️
cosmos-db/mgmt/2021-01-15/documentdb [View full logs]info [Changelog] No exported changes
️✔️
cosmos-db/mgmt/2019-08-01/documentdb [View full logs]info [Changelog] No exported changes
️✔️
cosmos-db/mgmt/2015-04-08/documentdb [View full logs]info [Changelog] No exported changes
️✔️
preview/cosmos-db/mgmt/2021-07-01-preview/documentdb [View full logs]info [Changelog] This is a new package
️✔️
preview/cosmos-db/mgmt/2021-04-01-preview/documentdb [View full logs]info [Changelog] No exported changes
️✔️
preview/cosmos-db/mgmt/2021-03-01-preview/documentdb [View full logs]info [Changelog] No exported changes
️✔️
preview/cosmos-db/mgmt/2020-09-01-preview/documentdb [View full logs]info [Changelog] No exported changes
- Only show 8 items here, please refer to log for details.
️✔️
preview/cosmos-db/mgmt/2020-06-01-preview/documentdb [View full logs] Breaking Change Detectedinfo [Changelog] - New const `Zone` info [Changelog] - New const `Geo` info [Changelog] - New function `PossibleBackupStorageRedundancyValues() []BackupStorageRedundancy` info [Changelog] - New struct `CloudError` info [Changelog] - New field `BackupStorageRedundancy` in struct `PeriodicModeProperties` info [Changelog] info [Changelog] Total 7 breaking change(s), 7 additive change(s). info [Changelog]
️✔️
preview/cosmos-db/mgmt/2020-04-01-preview/documentdb [View full logs]info [Changelog] No exported changes
️✔️
preview/cosmos-db/mgmt/2020-03-01-preview/documentdb [View full logs]info [Changelog] No exported changes
️✔️
preview/cosmos-db/mgmt/2019-12-12-preview/documentdb [View full logs]info [Changelog] No exported changes
️✔️
preview/cosmos-db/mgmt/2019-08-01-preview/documentdb [View full logs]info [Changelog] No exported changes
️️✔️
azure-sdk-for-go-track2 succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️
armcosmos [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - New struct `CassandraResourcesCreateUpdateCassandraViewPollerResponse` info [Changelog] - New struct `CassandraResourcesCreateUpdateCassandraViewResponse` info [Changelog] - New struct `CassandraResourcesCreateUpdateCassandraViewResult` info [Changelog] - New struct `CassandraResourcesDeleteCassandraViewPoller` info [Changelog] - New struct `CassandraResourcesDeleteCassandraViewPollerResponse` info [Changelog] - New struct `CassandraResourcesDeleteCassandraViewResponse` info [Changelog] - New struct `CassandraResourcesGetCassandraViewOptions` info [Changelog] - New struct `CassandraResourcesGetCassandraViewResponse` info [Changelog] - New struct `CassandraResourcesGetCassandraViewResult` info [Changelog] - New struct `CassandraResourcesGetCassandraViewThroughputOptions` info [Changelog] - New struct `CassandraResourcesGetCassandraViewThroughputResponse` info [Changelog] - New struct `CassandraResourcesGetCassandraViewThroughputResult` info [Changelog] - New struct `CassandraResourcesListCassandraViewsOptions` info [Changelog] - New struct `CassandraResourcesListCassandraViewsResponse` info [Changelog] - New struct `CassandraResourcesListCassandraViewsResult` info [Changelog] - New struct `CassandraResourcesMigrateCassandraViewToAutoscalePoller` info [Changelog] - New struct `CassandraResourcesMigrateCassandraViewToAutoscalePollerResponse` info [Changelog] - New struct `CassandraResourcesMigrateCassandraViewToAutoscaleResponse` info [Changelog] - New struct `CassandraResourcesMigrateCassandraViewToAutoscaleResult` info [Changelog] - New struct `CassandraResourcesMigrateCassandraViewToManualThroughputPoller` info [Changelog] - New struct `CassandraResourcesMigrateCassandraViewToManualThroughputPollerResponse` info [Changelog] - New struct `CassandraResourcesMigrateCassandraViewToManualThroughputResponse` info [Changelog] - New struct `CassandraResourcesMigrateCassandraViewToManualThroughputResult` info [Changelog] - New struct `CassandraResourcesUpdateCassandraViewThroughputPoller` info [Changelog] - New struct `CassandraResourcesUpdateCassandraViewThroughputPollerResponse` info [Changelog] - New struct `CassandraResourcesUpdateCassandraViewThroughputResponse` info [Changelog] - New struct `CassandraResourcesUpdateCassandraViewThroughputResult` info [Changelog] - New struct `CassandraViewCreateUpdateParameters` info [Changelog] - New struct `CassandraViewCreateUpdateProperties` info [Changelog] - New struct `CassandraViewGetProperties` info [Changelog] - New struct `CassandraViewGetPropertiesOptions` info [Changelog] - New struct `CassandraViewGetPropertiesResource` info [Changelog] - New struct `CassandraViewGetResults` info [Changelog] - New struct `CassandraViewListResult` info [Changelog] - New struct `CassandraViewResource` info [Changelog] - New struct `Certificate` info [Changelog] - New struct `ClusterNodeStatus` info [Changelog] - New struct `ClusterNodeStatusNodesItem` info [Changelog] - New struct `ClusterResource` info [Changelog] - New struct `ClusterResourceProperties` info [Changelog] - New struct `CosmosDBManagementClient` info [Changelog] - New struct `CosmosDBManagementClientLocationGetOptions` info [Changelog] - New struct `CosmosDBManagementClientLocationGetResponse` info [Changelog] - New struct `CosmosDBManagementClientLocationGetResult` info [Changelog] - New struct `CosmosDBManagementClientLocationListOptions` info [Changelog] - New struct `CosmosDBManagementClientLocationListResponse` info [Changelog] - New struct `CosmosDBManagementClientLocationListResult` info [Changelog] - New struct `DataCenterResource` info [Changelog] - New struct `DataCenterResourceProperties` info [Changelog] - New struct `DataTransferRegionalServiceResource` info [Changelog] - New struct `DataTransferServiceResource` info [Changelog] - New struct `DataTransferServiceResourceProperties` info [Changelog] - New struct `DefaultRequestDatabaseAccountCreateUpdateProperties` info [Changelog] - New struct `DiagnosticLogSettings` info [Changelog] - New struct `GraphAPIComputeRegionalServiceResource` info [Changelog] - New struct `GraphAPIComputeServiceResource` info [Changelog] - New struct `GraphAPIComputeServiceResourceProperties` info [Changelog] - New struct `GraphResource` info [Changelog] - New struct `GraphResourceCreateUpdateParameters` info [Changelog] - New struct `GraphResourceCreateUpdateProperties` info [Changelog] - New struct `GraphResourceGetProperties` info [Changelog] - New struct `GraphResourceGetPropertiesOptions` info [Changelog] - New struct `GraphResourceGetPropertiesResource` info [Changelog] - New struct `GraphResourceGetResults` info [Changelog] - New struct `GraphResourcesBeginCreateUpdateGraphOptions` info [Changelog] - New struct `GraphResourcesBeginDeleteGraphResourceOptions` info [Changelog] - New struct `GraphResourcesClient` info [Changelog] - New struct `GraphResourcesCreateUpdateGraphPoller` info [Changelog] - New struct `GraphResourcesCreateUpdateGraphPollerResponse` info [Changelog] - New struct `GraphResourcesCreateUpdateGraphResponse` info [Changelog] - New struct `GraphResourcesCreateUpdateGraphResult` info [Changelog] - New struct `GraphResourcesDeleteGraphResourcePoller` info [Changelog] - New struct `GraphResourcesDeleteGraphResourcePollerResponse` info [Changelog] - New struct `GraphResourcesDeleteGraphResourceResponse` info [Changelog] - New struct `GraphResourcesGetGraphOptions` info [Changelog] - New struct `GraphResourcesGetGraphResponse` info [Changelog] - New struct `GraphResourcesGetGraphResult` info [Changelog] - New struct `GraphResourcesListGraphsOptions` info [Changelog] - New struct `GraphResourcesListGraphsResponse` info [Changelog] - New struct `GraphResourcesListGraphsResult` info [Changelog] - New struct `GraphResourcesListResult` info [Changelog] - New struct `ListBackups` info [Changelog] - New struct `ListClusters` info [Changelog] - New struct `ListDataCenters` info [Changelog] - New struct `LocationGetResult` info [Changelog] - New struct `LocationListResult` info [Changelog] - New struct `LocationProperties` info [Changelog] - New struct `RegionalServiceResource` info [Changelog] - New struct `RepairPostBody` info [Changelog] - New struct `SQLDedicatedGatewayRegionalServiceResource` info [Changelog] - New struct `SQLDedicatedGatewayServiceResource` info [Changelog] - New struct `SQLDedicatedGatewayServiceResourceProperties` info [Changelog] - New struct `SeedNode` info [Changelog] - New struct `ServiceBeginCreateOptions` info [Changelog] - New struct `ServiceBeginDeleteOptions` info [Changelog] - New struct `ServiceClient` info [Changelog] - New struct `ServiceCreatePoller` info [Changelog] - New struct `ServiceCreatePollerResponse` info [Changelog] - New struct `ServiceCreateResponse` info [Changelog] - New struct `ServiceCreateResult` info [Changelog] - New struct `ServiceDeletePoller` info [Changelog] - New struct `ServiceDeletePollerResponse` info [Changelog] - New struct `ServiceDeleteResponse` info [Changelog] - New struct `ServiceGetOptions` info [Changelog] - New struct `ServiceGetResponse` info [Changelog] - New struct `ServiceGetResult` info [Changelog] - New struct `ServiceListOptions` info [Changelog] - New struct `ServiceListResponse` info [Changelog] - New struct `ServiceListResult` info [Changelog] - New struct `ServiceResource` info [Changelog] - New struct `ServiceResourceListResult` info [Changelog] - New struct `ServiceResourceProperties` info [Changelog] - New field `DiagnosticLogSettings` in struct `DatabaseAccountGetProperties` info [Changelog] - New field `BackupStorageRedundancy` in struct `PeriodicModeProperties` info [Changelog] - New field `DiagnosticLogSettings` in struct `DatabaseAccountUpdateProperties` info [Changelog] - New field `DiagnosticLogSettings` in struct `DatabaseAccountCreateUpdateProperties` info [Changelog] - New field `Identity` in struct `ARMResourceProperties` info [Changelog] info [Changelog] Total 4 breaking change(s), 640 additive change(s). info [Changelog]
️️✔️
azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
️✔️
@azure/arm-cosmosdb [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/cosmosDBManagementClient.js → ./dist/arm-cosmosdb.js... cmderr [npmPack] created ./dist/arm-cosmosdb.js in 949ms
️⚠️
azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️
cosmos-db [View full logs] [Release Schema Changes]
Hi, @ajparule. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @ajparule. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi @ajparule, Your PR has some issues. Please fix the CI sequentially by following the order of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side with some minor comments and/or questions.
@ArcturusZhang please help check the go sdk generation failure. |
@ajparule @MehaKaushik is the service ready for the new apiVersion? |
@msyyc please help check the python sdk breaking changes. |
yes it is |
The breaking changes are because of differences in preview and stable apiVersion. Going forward our team plans to release only preview apiVersion SDKs, that will prevent such breaking cases. The same holds for Go Sdk. |
approve for python breaking change |
…into add_endpoint * 'main' of https://github.com/Azure/azure-rest-api-specs: (5079 commits) Add Microsoft.ExtendedLocation [CustomLocation] 2021-08-15 stable API Version (Azure#15967) Updated SKU property to be read only (Azure#15965) Add Microsoft.Communication.UserDisconnected Event (Azure#15870) Add collection APIs (Azure#15221) [Cognitive Services - Personalizer] v1.1-preview.2 (Azure#15699) Adding default error response & updating basePath (Azure#15784) Update readme and readme.python (Azure#15973) add synapse batch tag package-composite-v1 (Azure#15974) Microsoft.BareMetalInfrastructure: add stable API version 2021-08-09 (Azure#15680) change readme.go.md template to track 2 (Azure#15972) [CosmosDB] Adding apiVersion 2021-07-01-preview (Azure#14817) Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (Azure#15954) DiskRP swagger for 2021-04-01 (Azure#15665) Use IncidentSeverity in IncidentInfo (Azure#15762) Add stable API version "2021-09-01" (Azure#15897) add-purview-typescript-file (Azure#15948) Swagger Completeness for Microsoft.Authorization (Azure#15253) [Hub Generated] Review request for Microsoft.Aadiam to add version preview/2020-03-01-preview and stable/2020-03-01 (Azure#15861) Add swagger for missing CheckPolicyRestrictions API version (Azure#15888) Add Red Hat OpenShift 2021-09-01-preview (Azure#15616) ...
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.