Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial #3102

mohanishpenta · 2018-05-18T17:29:23Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-05-18T17:40:35Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-05-18T17:44:23Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2653

AutorestCI · 2018-05-18T18:07:30Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpbq5yqyub/sdk', '--use=@microsoft.azure/autorest.python@2.1.40', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4279/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4279)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (2.1.40->2.1.40)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:95:4 ($.definitions.Job)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1859:4 ($.definitions.Job)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:114:4 ($.definitions.JobProperties)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2065:4 ($.definitions.JobProperties)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2160:4 ($.definitions.JobStreamProperties)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:1703:4 ($.definitions.JobCreateProperties)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1873:4 ($.definitions.JobCreateProperties)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2160:4 ($.definitions.JobStreamProperties)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:114:4 ($.definitions.JobProperties)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2065:4 ($.definitions.JobProperties)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:95:4 ($.definitions.Job)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1859:4 ($.definitions.Job)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:1703:4 ($.definitions.JobCreateProperties)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1873:4 ($.definitions.JobCreateProperties)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNode.json:946:4 ($.definitions.AgentRegistrationRegenerateKeyParameter)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:273:4 ($.definitions.AgentRegistrationRegenerateKeyParameter)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNode.json:966:4 ($.definitions.DscNodeUpdateParameters)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1533:4 ($.definitions.DscNodeUpdateParameters)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscCompilationJob.json:546:4 ($.definitions.JobStreamProperties)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2160:4 ($.definitions.JobStreamProperties)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNodeConfiguration.json:415:4 ($.definitions.DscNodeConfigurationCreateOrUpdateParameters)
    - file:///tmp/tmpbq5yqyub/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1485:4 ($.definitions.DscNodeConfigurationCreateOrUpdateParameters)
Process() cancelled due to exception : Cancellation requested.
  Cancellation requested.

AutorestCI · 2018-05-18T20:17:54Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpkiv0r3yq/rest/specification/automation/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpkiv0r3yq/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.98', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.98->2.1.98)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2015-10"} .
Processing batch task - {"tag":"package-2017-05-preview"} .
Processing batch task - {"tag":"package-2018-01-preview"} .
FATAL: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: startIndex
   at System.String.LastIndexOf(Char value, Int32 startIndex, Int32 count)
   at AutoRest.Go.Model.CodeModelGo.PackageVerDir() in /opt/vsts/work/1/s/src/Model/CodeModelGo.cs:line 64
   at AutoRest.Go.Model.CodeModelGo.get_DefaultUserAgent() in /opt/vsts/work/1/s/src/Model/CodeModelGo.cs:line 83
   at AutoRest.Go.Model.CodeModelGo.get_UserAgent() in /opt/vsts/work/1/s/src/Model/CodeModelGo.cs:line 31
   at AutoRest.Go.Templates.VersionTemplate.<ExecuteAsync>d__1.MoveNext() in /opt/vsts/work/1/s/src/obj/Razor/Templates/VersionTemplate.cshtml:line 28
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.CodeGeneratorGo.<Generate>d__6.MoveNext() in /opt/vsts/work/1/s/src/CodeGeneratorGo.cs:line 91
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2018-01-preview"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

mohanishpenta · 2018-05-21T22:03:18Z

@ravbhatnagar - Can you please take a look at this whenever you get a chance ? thanks.

ravbhatnagar

Just one comment. Looks like name is updatable in the request body. it should be marked as readonly. Other than that looks fine. Signing off from ARM side based on fixing this one comment

ravbhatnagar · 2018-05-24T22:47:19Z

...fication/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json

+  },
+  "WatcherCreateOrUpdateParameters": {
+    "properties": {
+      "name": {


name should not be updatable through the request body. read-only?

Thanks for reviewing Gaurav. As discussed, using the same Watcher model for get/put and also using the same model of input and output of the put request. Marking fields in the watcher model as readonly as required. using a different model for input for patch.

ravbhatnagar · 2018-05-29T20:51:57Z

Looks good!

lmazuel

Merging, since PR content itself passes CI, even if global automation does not.

AutorestCI · 2018-05-29T21:08:17Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

* Use common Resource & Sku definitions in all Sql specs (#3134) * Use common Resource & Sku definitions * Don't use common Sku definition * Just use common SQL definitions * Fixed syntax error * Fixed another syntax error * Fixed sku ref error * Fixed syntax error in example * Fix Python conf of servermanager (#3140) * Fix ServerManager Py Conf (#3141) * Plug SwaggerToSdk to LogAnalyticsMgmt (#3142) * [Storage] Support Management policy on new api version 2018-03-01-preview (#3137) * [Storage] Add new API version 2018-03-01-preview * [Storage] Update rest version 2018-03-01-preview * [Storage] Support Management Policy * [Storage] Update since code review comments * Add Python conf * [Storage] Add managment policy doc link to policy description. * [Storage] modify as review comments * RSA key size examples, ECC descriptions (#3136) * RSA key size examples, ECC descriptions * remove preview changes for now * Added GroupType property in HybridWorkerGroup (#3132) * Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102) * Watcher specs * using the same model for get/put input and output. * Fix storage Python conf (#3148) * Fix for Azure Networking swagger 2018-04-01 version (#3146)

…resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102) * Watcher specs * using the same model for get/put input and output.

* One file for server and db apis Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json * Add extended server auditing settings API * Fixed operation id. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Fixing examples of existing APIs and modifying blobAuditing Swagger file storageAccountAccessKey was removed from requests response, and examples were modified accordingly. * Remove description of predicateExpression related exceptions from old APIs description. Fixing a small issue for client readability. AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs. After this fix, predicateExpression related exceptions will not be mentioned on old APIs. * Moving files to preview/stable as appropriate. * Modifying swagger and examples of 2017 BlobAuditing APIs (#421) * 2017 Blob Auditing APIs - Swagger and examples. Modifying swagger and examples of 2017 blob auditing APIs. * Resetting examples of DatabaseBlobAuditing API to 2017 Resetting examples of DatabaseBlobAuditing API to 2017 * Fixing follwing comments Fixing follwing comments * Fixing build errors Fixing build errors * Fix build errors Fix build errors * Fixing comments fixing comments * Removed 2017 database API Removed 2017 database API * Revert "Fixing comments" This reverts commit c09f9f6. * Modifying description of APIs Modifying description of APIs after generating new swagger. * Modifying readme.md. Modifying readme.md. * Updating blobAuditing Json files. Updating blobAuditing Json files. * Temp change Temp change * Final commit Final commit * Fix Duplicated model name with non-identical definitions build error Fix Duplicated model name with non-identical definitions * Fix Duplicated model name with non-identical definitions build error This reverts commit 616851d and commits fixes. * Fix Automation Duplicated model name with non-identical definitions Fix Automation Duplicated model name with non-identical definitions * One file for server and db apis Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json * Add extended server auditing settings API * Fixed operation id. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Fixing examples of existing APIs and modifying blobAuditing Swagger file storageAccountAccessKey was removed from requests response, and examples were modified accordingly. * Remove description of predicateExpression related exceptions from old APIs description. Fixing a small issue for client readability. AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs. After this fix, predicateExpression related exceptions will not be mentioned on old APIs. * Moving files to preview/stable as appropriate. * Modifying swagger and examples of 2017 BlobAuditing APIs (#421) * 2017 Blob Auditing APIs - Swagger and examples. Modifying swagger and examples of 2017 blob auditing APIs. * Resetting examples of DatabaseBlobAuditing API to 2017 Resetting examples of DatabaseBlobAuditing API to 2017 * Fixing follwing comments Fixing follwing comments * Fixing build errors Fixing build errors * Fixing comments fixing comments * Removed 2017 database API Removed 2017 database API * Revert "Fixing comments" This reverts commit c09f9f6. * Modifying description of APIs Modifying description of APIs after generating new swagger. * Modifying readme.md. Modifying readme.md. * Updating blobAuditing Json files. Updating blobAuditing Json files. * Temp change Temp change * Final commit Final commit * Fix Python conf of servermanager (#3140) * Fix ServerManager Py Conf (#3141) * Plug SwaggerToSdk to LogAnalyticsMgmt (#3142) * [Storage] Support Management policy on new api version 2018-03-01-preview (#3137) * [Storage] Add new API version 2018-03-01-preview * [Storage] Update rest version 2018-03-01-preview * [Storage] Support Management Policy * [Storage] Update since code review comments * Add Python conf * [Storage] Add managment policy doc link to policy description. * [Storage] modify as review comments * RSA key size examples, ECC descriptions (#3136) * RSA key size examples, ECC descriptions * remove preview changes for now * Added GroupType property in HybridWorkerGroup (#3132) * Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102) * Watcher specs * using the same model for get/put input and output. * Fix storage Python conf (#3148) * Fix for Azure Networking swagger 2018-04-01 version (#3146) * Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger (#3114) * Forecast Api swagger * consumption readme file update for the new swagger version * addressing review comment on adding nextLink * fixing build error * Addressed feedback on enum and fixed a typo * Stop using unobscured credentials * Fix Duplicated model name with non-identical definitions build error Fix Duplicated model name with non-identical definitions * Fix go tag for storage management plane 2018-03-02 api version (#3156) * Refactoring Job Definitions (#3116) * MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. (#3138) * Fix Python conf * Adding the VNET Rest APIs to 2017-12-01 version. Adding the VNET Rest APIs to 2017-12-01 version. * Add specs for machine learning services provider (#3135) * Add specs for machine learning services provider * Added python config to readme * Added repo generation for Python * Addressed feedback * Address more comments * Adding Security RP API swagger (#3144) * Reverted methods in vpn gateways. (#3163) * Fix Duplicated model name with non-identical definitions build error This reverts commit 616851d and commits fixes. * Fix Automation Duplicated model name with non-identical definitions Fix Automation Duplicated model name with non-identical definitions * Revert "Fix Duplicated model name with non-identical definitions build error" This reverts commit d1c40f7. * Revert "Fix Duplicated model name with non-identical definitions build error" This reverts commit 2c1261e. * Update readme.md file Update readme.md file

* Fix ASE instance metrics url * Add java multi-api sections in select readme files * Add java multi api to network (temporary) * Add Java multi api to resources * Fix readme for Java in media * Add web app multiapi * Add multi api for web app and network * sync with master (#3153) * Use common Resource & Sku definitions in all Sql specs (#3134) * Use common Resource & Sku definitions * Don't use common Sku definition * Just use common SQL definitions * Fixed syntax error * Fixed another syntax error * Fixed sku ref error * Fixed syntax error in example * Fix Python conf of servermanager (#3140) * Fix ServerManager Py Conf (#3141) * Plug SwaggerToSdk to LogAnalyticsMgmt (#3142) * [Storage] Support Management policy on new api version 2018-03-01-preview (#3137) * [Storage] Add new API version 2018-03-01-preview * [Storage] Update rest version 2018-03-01-preview * [Storage] Support Management Policy * [Storage] Update since code review comments * Add Python conf * [Storage] Add managment policy doc link to policy description. * [Storage] modify as review comments * RSA key size examples, ECC descriptions (#3136) * RSA key size examples, ECC descriptions * remove preview changes for now * Added GroupType property in HybridWorkerGroup (#3132) * Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102) * Watcher specs * using the same model for get/put input and output. * Fix storage Python conf (#3148) * Fix for Azure Networking swagger 2018-04-01 version (#3146) * Adding storage 2018-03-01-preview to java multi-api section (#3155) * readme for resource,keyvault,web * Fix keyvault namespace * Fix keyvault,dns, add storage 2016-01-01 * Fix web and storage multi api config * Add java multi api for authorization, iotcentral, keyvault, resources * Add policyinsights and fconfig to resources * Fix web app output path * Multiapibatch (#3205) * Change all existing ##Java sections * Add java multi api sections * Use azure-sdk-for-java repo * Fix typo in batch readme

Watcher specs

e82246a

azuresdkci assigned lmazuel May 18, 2018

azuresdkci requested a review from lmazuel May 18, 2018 17:30

mohanishpenta changed the title ~~Watcher resource swagger specs~~ Watcher resource swagger specs. May 18, 2018

mohanishpenta changed the title ~~Watcher resource swagger specs.~~ Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial May 18, 2018

AutorestCI mentioned this pull request May 18, 2018

[AutoPR automation/resource-manager] Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial Azure/azure-sdk-for-node#2878

Closed

AutorestCI mentioned this pull request May 18, 2018

[AutoPR automation/resource-manager] Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial Azure/azure-sdk-for-python#2585

Closed

lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 21, 2018

ravbhatnagar reviewed May 24, 2018

View reviewed changes

using the same model for get/put input and output.

ae94532

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 29, 2018

lmazuel approved these changes May 29, 2018

View reviewed changes

lmazuel merged commit e6f31c0 into Azure:master May 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial #3102

Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial #3102

mohanishpenta commented May 18, 2018 •

edited

Loading

AutorestCI commented May 18, 2018 •

edited

Loading

AutorestCI commented May 18, 2018 •

edited

Loading

AutorestCI commented May 18, 2018 •

edited

Loading

AutorestCI commented May 18, 2018 •

edited

Loading

mohanishpenta commented May 21, 2018

ravbhatnagar left a comment

ravbhatnagar May 24, 2018

mohanishpenta May 25, 2018

ravbhatnagar commented May 29, 2018

lmazuel left a comment

AutorestCI commented May 29, 2018 •

edited

Loading

Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial #3102

Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial #3102

Conversation

mohanishpenta commented May 18, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented May 18, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented May 18, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 18, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 18, 2018 • edited Loading

Automation for azure-sdk-for-go

mohanishpenta commented May 21, 2018

ravbhatnagar left a comment

Choose a reason for hiding this comment

ravbhatnagar May 24, 2018

Choose a reason for hiding this comment

mohanishpenta May 25, 2018

Choose a reason for hiding this comment

ravbhatnagar commented May 29, 2018

lmazuel left a comment

Choose a reason for hiding this comment

AutorestCI commented May 29, 2018 • edited Loading

Automation for azure-sdk-for-ruby

mohanishpenta commented May 18, 2018 •

edited

Loading

AutorestCI commented May 18, 2018 •

edited

Loading

AutorestCI commented May 18, 2018 •

edited

Loading

AutorestCI commented May 18, 2018 •

edited

Loading

AutorestCI commented May 18, 2018 •

edited

Loading

AutorestCI commented May 29, 2018 •

edited

Loading