Add specs for machine learning services provider #3135

ragargms · 2018-05-24T21:45:06Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-05-24T21:46:04Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

ragargms · 2018-05-24T21:46:55Z

@sergey-shandar This is the PR which I now moved to public repo

AutorestCI · 2018-05-24T21:49:53Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2663

annatisch · 2018-05-24T22:37:56Z

@ragargms - Has this PR already been reviewed in the private repo? If so - could you please link to that PR here?

Additionally - I will go ahead and add the Python SDK generation to the readme.

ragargms · 2018-05-24T22:41:10Z

@sergey-shandar already started to look at the private repo PR. Since this is not a secret service, we decided to create PR against the public repo. Also, do you have references as to how I can add Python SDK generation to the readme? @annatisch

Here is the private repo PR link https://github.com/Azure/azure-rest-api-specs-pr/pull/480

ragargms · 2018-05-24T23:49:01Z

@ravbhatnagar for ARM review. I think we reviewed most of this already offline when we were getting started with the service.

AutorestCI · 2018-05-25T13:24:14Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-05-25T18:25:08Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

ravbhatnagar · 2018-05-29T17:43:08Z

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json

+            "$ref": "#/parameters/ComputeDefinitionParameter"
+          }
+        ],
+        "responses": {


200 OK response to differentiate between created or updated

ravbhatnagar · 2018-05-29T17:43:25Z

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json

+          }
+        ],
+        "responses": {
+          "202": {


200 response

ravbhatnagar · 2018-05-29T17:47:07Z

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json

+          }
+        }
+      },
+      "post": {


POST on this URL will not work. the action segment is missing.

ravbhatnagar · 2018-05-29T17:51:30Z

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json

+          "readOnly": true,
+          "type": "string"
+        },
+        "userStorageArmId": {


lets not use short forms like ARM for property names. ResourceId works?

AutorestCI · 2018-05-29T18:44:15Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1925

ravbhatnagar · 2018-05-29T20:50:36Z

Looks good. Signing off!

annatisch · 2018-05-29T21:54:21Z

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json

+          "201": {
+            "description": "Compute creation or update initiated.",
+            "headers": {
+              "Azure-AsyncOperation": {


If this operation is a polling/async operation - then it should use the long-running-operation extension.

annatisch · 2018-05-29T21:55:13Z

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json

+          "202": {
+            "description": "Compute deletion initiated.",
+            "headers": {
+              "Azure-AsyncOperation": {


If this operation is a polling/async operation - then it should use the long-running-operation extension.

annatisch · 2018-05-29T21:58:16Z

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json

+          "OperationalizationClusters",
+          "MachineLearningComputes"
+        ],
+        "operationId": "MachineLearningCompute_ListKeys",


The operation ID could be renamed to MachineLearningCompute_GetKeys - as it's not really a list operation.

We already have clients using this contract. Is it ok to keep it this way? We got this reviewed with ARM. Changing this will require us significant work to update all our clients and first party services.

Ah. Sorry. You are just asking to change the operation id not the route, that can be done. Fixed

annatisch · 2018-05-29T22:05:59Z

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json

+          "default": {
+            "description": "Error response describing why the operation failed",
+            "schema": {
+              "$ref": "#/definitions/ErrorResponseWrapper"


Is it possible to rename this ErrorResponseWrapper to something like MachineLearningServiceError?
It's not blocking - but the naming is a little non-intuitive for a client development experience. Though it's up to you :)

annatisch · 2018-05-30T00:46:19Z

This looks okay to me. @sergey-shandar - do you have any further comments?

sergey-shandar

LGTM

* Add specs for machine learning services provider * Added python config to readme * Added repo generation for Python * Addressed feedback * Address more comments

* One file for server and db apis Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json * Add extended server auditing settings API * Fixed operation id. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Fixing examples of existing APIs and modifying blobAuditing Swagger file storageAccountAccessKey was removed from requests response, and examples were modified accordingly. * Remove description of predicateExpression related exceptions from old APIs description. Fixing a small issue for client readability. AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs. After this fix, predicateExpression related exceptions will not be mentioned on old APIs. * Moving files to preview/stable as appropriate. * Modifying swagger and examples of 2017 BlobAuditing APIs (#421) * 2017 Blob Auditing APIs - Swagger and examples. Modifying swagger and examples of 2017 blob auditing APIs. * Resetting examples of DatabaseBlobAuditing API to 2017 Resetting examples of DatabaseBlobAuditing API to 2017 * Fixing follwing comments Fixing follwing comments * Fixing build errors Fixing build errors * Fix build errors Fix build errors * Fixing comments fixing comments * Removed 2017 database API Removed 2017 database API * Revert "Fixing comments" This reverts commit c09f9f6. * Modifying description of APIs Modifying description of APIs after generating new swagger. * Modifying readme.md. Modifying readme.md. * Updating blobAuditing Json files. Updating blobAuditing Json files. * Temp change Temp change * Final commit Final commit * Fix Duplicated model name with non-identical definitions build error Fix Duplicated model name with non-identical definitions * Fix Duplicated model name with non-identical definitions build error This reverts commit 616851d and commits fixes. * Fix Automation Duplicated model name with non-identical definitions Fix Automation Duplicated model name with non-identical definitions * One file for server and db apis Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json * Add extended server auditing settings API * Fixed operation id. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Fixing examples of existing APIs and modifying blobAuditing Swagger file storageAccountAccessKey was removed from requests response, and examples were modified accordingly. * Remove description of predicateExpression related exceptions from old APIs description. Fixing a small issue for client readability. AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs. After this fix, predicateExpression related exceptions will not be mentioned on old APIs. * Moving files to preview/stable as appropriate. * Modifying swagger and examples of 2017 BlobAuditing APIs (#421) * 2017 Blob Auditing APIs - Swagger and examples. Modifying swagger and examples of 2017 blob auditing APIs. * Resetting examples of DatabaseBlobAuditing API to 2017 Resetting examples of DatabaseBlobAuditing API to 2017 * Fixing follwing comments Fixing follwing comments * Fixing build errors Fixing build errors * Fixing comments fixing comments * Removed 2017 database API Removed 2017 database API * Revert "Fixing comments" This reverts commit c09f9f6. * Modifying description of APIs Modifying description of APIs after generating new swagger. * Modifying readme.md. Modifying readme.md. * Updating blobAuditing Json files. Updating blobAuditing Json files. * Temp change Temp change * Final commit Final commit * Fix Python conf of servermanager (#3140) * Fix ServerManager Py Conf (#3141) * Plug SwaggerToSdk to LogAnalyticsMgmt (#3142) * [Storage] Support Management policy on new api version 2018-03-01-preview (#3137) * [Storage] Add new API version 2018-03-01-preview * [Storage] Update rest version 2018-03-01-preview * [Storage] Support Management Policy * [Storage] Update since code review comments * Add Python conf * [Storage] Add managment policy doc link to policy description. * [Storage] modify as review comments * RSA key size examples, ECC descriptions (#3136) * RSA key size examples, ECC descriptions * remove preview changes for now * Added GroupType property in HybridWorkerGroup (#3132) * Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102) * Watcher specs * using the same model for get/put input and output. * Fix storage Python conf (#3148) * Fix for Azure Networking swagger 2018-04-01 version (#3146) * Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger (#3114) * Forecast Api swagger * consumption readme file update for the new swagger version * addressing review comment on adding nextLink * fixing build error * Addressed feedback on enum and fixed a typo * Stop using unobscured credentials * Fix Duplicated model name with non-identical definitions build error Fix Duplicated model name with non-identical definitions * Fix go tag for storage management plane 2018-03-02 api version (#3156) * Refactoring Job Definitions (#3116) * MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. (#3138) * Fix Python conf * Adding the VNET Rest APIs to 2017-12-01 version. Adding the VNET Rest APIs to 2017-12-01 version. * Add specs for machine learning services provider (#3135) * Add specs for machine learning services provider * Added python config to readme * Added repo generation for Python * Addressed feedback * Address more comments * Adding Security RP API swagger (#3144) * Reverted methods in vpn gateways. (#3163) * Fix Duplicated model name with non-identical definitions build error This reverts commit 616851d and commits fixes. * Fix Automation Duplicated model name with non-identical definitions Fix Automation Duplicated model name with non-identical definitions * Revert "Fix Duplicated model name with non-identical definitions build error" This reverts commit d1c40f7. * Revert "Fix Duplicated model name with non-identical definitions build error" This reverts commit 2c1261e. * Update readme.md file Update readme.md file

Add specs for machine learning services provider

0fe2d53

sarangan12 added the review label May 24, 2018

azuresdkci assigned annatisch May 24, 2018

azuresdkci requested a review from annatisch May 24, 2018 21:49

sergey-shandar self-assigned this May 24, 2018

Added python config to readme

e7760b1

annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 24, 2018

Added repo generation for Python

98b7713

ravbhatnagar reviewed May 29, 2018

View reviewed changes

ragargms added 2 commits May 29, 2018 14:40

Addressed feedback

c6828a5

Merge branch 'master' into mlservicesSwagger

731ac51

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 29, 2018

annatisch reviewed May 29, 2018

View reviewed changes

annatisch requested changes May 29, 2018

View reviewed changes

Address more comments

9462bec

annatisch approved these changes May 30, 2018

View reviewed changes

sergey-shandar approved these changes May 30, 2018

View reviewed changes

sergey-shandar merged commit f0d8a6b into Azure:master May 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add specs for machine learning services provider #3135

Add specs for machine learning services provider #3135

ragargms commented May 24, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 24, 2018 •

edited

Loading

ragargms commented May 24, 2018

AutorestCI commented May 24, 2018 •

edited

Loading

annatisch commented May 24, 2018

ragargms commented May 24, 2018 •

edited

Loading

ragargms commented May 24, 2018

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

ravbhatnagar May 29, 2018

ragargms May 29, 2018

ravbhatnagar May 29, 2018

ragargms May 29, 2018

ravbhatnagar May 29, 2018

ragargms May 29, 2018

ravbhatnagar May 29, 2018

ragargms May 29, 2018

AutorestCI commented May 29, 2018 •

edited

Loading

ravbhatnagar commented May 29, 2018

annatisch May 29, 2018

ragargms May 29, 2018

annatisch May 29, 2018

ragargms May 29, 2018

annatisch May 29, 2018

ragargms May 29, 2018

ragargms May 29, 2018

annatisch May 29, 2018

annatisch commented May 30, 2018

sergey-shandar left a comment

Add specs for machine learning services provider #3135

Add specs for machine learning services provider #3135

Conversation

ragargms commented May 24, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented May 24, 2018 • edited Loading

Automation for azure-libraries-for-java

ragargms commented May 24, 2018

AutorestCI commented May 24, 2018 • edited Loading

Automation for azure-sdk-for-python

annatisch commented May 24, 2018

ragargms commented May 24, 2018 • edited Loading

ragargms commented May 24, 2018

AutorestCI commented May 25, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 25, 2018 • edited Loading

Automation for azure-sdk-for-ruby

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented May 29, 2018 • edited Loading

Automation for azure-sdk-for-go

ravbhatnagar commented May 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annatisch commented May 30, 2018

sergey-shandar left a comment

Choose a reason for hiding this comment

ragargms commented May 24, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 24, 2018 •

edited

Loading

AutorestCI commented May 24, 2018 •

edited

Loading

ragargms commented May 24, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 29, 2018 •

edited

Loading