Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Security RP API swagger #3144

Merged
merged 1 commit into from
May 30, 2018
Merged

Adding Security RP API swagger #3144

merged 1 commit into from
May 30, 2018

Conversation

chlahav
Copy link
Contributor

@chlahav chlahav commented May 28, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented May 28, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented May 28, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@chlahav
Copy link
Contributor Author

chlahav commented May 28, 2018

@sergey-shandar continuation of #3087 since it was closed by mistake and cannot be opened again

@AutorestCI
Copy link

AutorestCI commented May 28, 2018 •
edited
Loading

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented May 28, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented May 28, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@azuresdkci azuresdkci requested a review from annatisch May 28, 2018 17:14
@chlahav
Copy link
Contributor Author

chlahav commented May 28, 2018

@sergey-shandar for the tasks and alerts missing fields, it will be quite impossible to correctly document these with the current data structure, but we are working on a new API version that will solve this issue.
is it possible to mark these as dynamic objects somehow for now?

@chlahav chlahav force-pushed the master branch 9 times, most recently from daf9ad5 to f9c7a75 Compare May 28, 2018 20:27
@sergey-shandar sergey-shandar self-assigned this May 29, 2018
@sergey-shandar
Copy link
Contributor

@chlahav you can either fix examples or set additionalProperties: true.

@chlahav chlahav force-pushed the master branch 2 times, most recently from 98367a0 to 4ecfcaa Compare May 29, 2018 18:47
@annatisch annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 29, 2018
@sergey-shandar sergey-shandar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 29, 2018
@sergey-shandar
Copy link
Contributor

ARM approval is here #2753

@chlahav chlahav force-pushed the master branch 4 times, most recently from f7aa047 to 2e90f23 Compare May 29, 2018 21:58
@chlahav chlahav force-pushed the master branch 3 times, most recently from 107f4e3 to 424340e Compare May 30, 2018 12:36
@sergey-shandar sergey-shandar merged commit b112be5 into Azure:master May 30, 2018
bashahee pushed a commit that referenced this pull request Jun 3, 2018
@chlahav @bashahee
Adding Security RP API swagger (#3144)
623f1b2
hovsepm pushed a commit that referenced this pull request Jun 8, 2018
@marstr @hovsepm
Sql/blob auditing (#3076)
74c3323 
* One file for server and db apis

Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json

* Add extended server auditing settings API

* Fixed operation id.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.
In addition, existing related APIs swaggers were unified under same Public API name.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.
In addition, existing related APIs swaggers were unified under same Public API name.

* Fixing examples of existing APIs and modifying blobAuditing Swagger file

storageAccountAccessKey was removed from requests response, and examples were modified accordingly.

* Remove description of predicateExpression related exceptions from old APIs description.

Fixing a small issue for client readability.
AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs.
After this fix, predicateExpression related exceptions will not be mentioned on old APIs.

* Moving files to preview/stable as appropriate.

* Modifying swagger and examples of 2017 BlobAuditing APIs (#421)

* 2017 Blob Auditing APIs - Swagger and examples.

Modifying swagger and examples of 2017 blob auditing APIs.

* Resetting examples of DatabaseBlobAuditing API to 2017

Resetting examples of DatabaseBlobAuditing API to 2017

* Fixing follwing comments

Fixing follwing comments

* Fixing build errors

Fixing build errors

* Fix build errors

Fix build errors

* Fixing comments

fixing comments

* Removed 2017 database API

Removed 2017 database API

* Revert "Fixing comments"

This reverts commit c09f9f6.

* Modifying description of APIs

Modifying description of APIs after generating new swagger.

* Modifying readme.md.

Modifying readme.md.

* Updating blobAuditing Json files.

Updating blobAuditing Json files.

* Temp change

Temp change

* Final commit

Final commit

* Fix Duplicated model name with non-identical definitions build error

Fix Duplicated model name with non-identical definitions

* Fix Duplicated model name with non-identical definitions build error

This reverts commit 616851d and commits fixes.

* Fix Automation Duplicated model name with non-identical definitions

Fix Automation Duplicated model name with non-identical definitions

* One file for server and db apis

Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json

* Add extended server auditing settings API

* Fixed operation id.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.
In addition, existing related APIs swaggers were unified under same Public API name.

* Enable Database Auditing Filtiring With a Predicate Expression

New API which enables database auditing filtering by a where clause.
In addition, existing related APIs swaggers were unified under same Public API name.

* Fixing examples of existing APIs and modifying blobAuditing Swagger file

storageAccountAccessKey was removed from requests response, and examples were modified accordingly.

* Remove description of predicateExpression related exceptions from old APIs description.

Fixing a small issue for client readability.
AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs.
After this fix, predicateExpression related exceptions will not be mentioned on old APIs.

* Moving files to preview/stable as appropriate.

* Modifying swagger and examples of 2017 BlobAuditing APIs (#421)

* 2017 Blob Auditing APIs - Swagger and examples.

Modifying swagger and examples of 2017 blob auditing APIs.

* Resetting examples of DatabaseBlobAuditing API to 2017

Resetting examples of DatabaseBlobAuditing API to 2017

* Fixing follwing comments

Fixing follwing comments

* Fixing build errors

Fixing build errors

* Fixing comments

fixing comments

* Removed 2017 database API

Removed 2017 database API

* Revert "Fixing comments"

This reverts commit c09f9f6.

* Modifying description of APIs

Modifying description of APIs after generating new swagger.

* Modifying readme.md.

Modifying readme.md.

* Updating blobAuditing Json files.

Updating blobAuditing Json files.

* Temp change

Temp change

* Final commit

Final commit

* Fix Python conf of servermanager (#3140)

* Fix ServerManager Py Conf (#3141)

* Plug SwaggerToSdk to LogAnalyticsMgmt (#3142)

* [Storage] Support Management policy on new api version 2018-03-01-preview (#3137)

* [Storage] Add new API version 2018-03-01-preview

* [Storage] Update rest version 2018-03-01-preview

* [Storage] Support Management Policy

* [Storage] Update since code review comments

* Add Python conf

* [Storage] Add managment policy doc link to policy description.

* [Storage] modify as review comments

* RSA key size examples, ECC descriptions (#3136)

* RSA key size examples, ECC descriptions

* remove preview changes for now

* Added GroupType property in HybridWorkerGroup (#3132)

* Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102)

* Watcher specs

* using the same model for get/put input and output.

* Fix storage Python conf (#3148)

* Fix for Azure Networking swagger 2018-04-01 version (#3146)

* Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger (#3114)

* Forecast Api swagger

* consumption readme file update for the new swagger version

* addressing review comment on adding nextLink

* fixing build error

* Addressed feedback on enum and fixed a typo

* Stop using unobscured credentials

* Fix Duplicated model name with non-identical definitions build error

Fix Duplicated model name with non-identical definitions

* Fix go tag for storage management plane 2018-03-02 api version (#3156)

* Refactoring Job Definitions (#3116)

* MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. (#3138)

* Fix Python conf

* Adding the VNET Rest APIs to 2017-12-01 version.

Adding the VNET Rest APIs to 2017-12-01 version.

* Add specs for machine learning services provider (#3135)

* Add specs for machine learning services provider

* Added python config to readme

* Added repo generation for Python

* Addressed feedback

* Address more comments

* Adding Security RP API swagger (#3144)

* Reverted methods in vpn gateways. (#3163)

* Fix Duplicated model name with non-identical definitions build error

This reverts commit 616851d and commits fixes.

* Fix Automation Duplicated model name with non-identical definitions

Fix Automation Duplicated model name with non-identical definitions

* Revert "Fix Duplicated model name with non-identical definitions build error"

This reverts commit d1c40f7.

* Revert "Fix Duplicated model name with non-identical definitions build error"

This reverts commit 2c1261e.

* Update readme.md file

Update readme.md file
@chlahav chlahav mentioned this pull request Jul 16, 2018
Merged
9 tasks
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@raych1
Merge pull request #3144 from Azure/alexbat/master-common-types-2
4dc6f21 
Renamed lastModifiedByAt to lastModifiedAt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@annatisch annatisch Awaiting requested review from annatisch

Assignees

@sergey-shandar sergey-shandar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chlahav @AutorestCI @sergey-shandar @annatisch