change appgw custom error status code enum and fix a typo of customErrorConfigurations #4050

KaiChiLin · 2018-10-01T22:17:07Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…ure-rest-api-specs into network-october-release

…rorConfiguration

AutorestCI · 2018-10-01T22:19:04Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-10-01T22:25:05Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmpqjnmygro/rest/specification/network/resource-manager/readme.md', '--multiapi', '--ruby', '--ruby-sdks-folder=/tmp/tmpqjnmygro/sdk', '--use=@microsoft.azure/autorest.ruby@3.0.20', '--version=preview']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Loading AutoRest extension '@microsoft.azure/autorest.ruby' (3.0.20->3.0.20)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.1.22->2.1.22)
Processing batch task - {"tag":"package-2015-05-preview"} .
Processing batch task - {"tag":"package-2015-06split"} .
Processing batch task - {"tag":"package-2016-03"} .
Processing batch task - {"tag":"package-2016-06"} .
Processing batch task - {"tag":"package-2016-09"} .
Processing batch task - {"tag":"package-2016-12"} .
Processing batch task - {"tag":"package-2017-03-only"} .
Processing batch task - {"tag":"package-2017-03-30-only"} .
Processing batch task - {"tag":"package-2017-09-only"} .
Processing batch task - {"tag":"package-2017-10-only"} .
Processing batch task - {"tag":"package-2017-11-only"} .
Processing batch task - {"tag":"package-2018-01-only"} .

AutorestCI · 2018-10-01T22:29:40Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3478

AutorestCI · 2018-10-01T22:46:31Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

azuresdkci · 2018-10-01T22:51:44Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-01T22:53:47Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp02j0ncic/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp02j0ncic/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.114', '--use-onever', '--verbose']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.4]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Including configuration file 'file:///tmp/tmp02j0ncic/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.114->2.1.114)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-08"} .
   Including configuration file 'file:///tmp/tmp02j0ncic/rest/specification/network/resource-manager/readme.go.md'

AutorestCI · 2018-10-01T22:55:27Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmp4w8wx_h5/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp4w8wx_h5/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.1.103']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.103->2.1.103)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

MikhailTryakhov · 2018-10-02T04:21:20Z

@lmazuel can you please take a look at the job attached? looks like no job instances started

MikhailTryakhov

Ran job
https://azuresdkci.westus2.cloudapp.azure.com/job/NetworkTesting/69/

MikhailTryakhov

Passed, LGTM

* Updated NetworkConfigurationDiagnostic API + example (#3905) * Fix incorrect API versions in Network's examples (#3954) * Fixed incorrect API versions in 2018-08-01's examples Added missing example for serviceEndpointPolicy.json * Fixed incorrect API version in 2018-07-01 example * swagger change for application gateway waf global config and exclusion list (#3972) * swagger change for application gateway waf global config and exclusion list * address the comments * add customer error spec for Application Gateway (#3985) * add customer error spec for Application Gateway * fix property name issue * Add ICMP to the list of supported protocols (#3993) * change appgw custom error status code enum and fix a typo of customErrorConfigurations (#4050) * add customer error spec for Application Gateway * fix property name issue * change appgw custom error status code enum and fix a typo of customErrorConfiguration * Add ExpressRoutePort swagger (#4104) * Add ExpressRoutePort details to readme.md * ExpressRoutePort swagger * Refer SubscriptionIdParameter and ApiVersionParameter from network.json * Cherry pick NRP's changes from master to October branch (#4251) * Remove error code from swagger (#4103) * Modifying example templates : enabling Ipv6 support for Private Peering (#4232) * Modifying example templates : enabling Ipv6 support for Private Peering * Resolving oav validation error * Changes to add operation id for outbound rules (#4320) * Changes to add operation id for outbound rules * Changes to make outbound rule similar to load balancing rule * fix failures - add example json files * fix failures * Fixed line endings, specs, examples * Change one parameter (#4339) * Change parameter in most recent version * Fix example * New SKU for ER (#4342)

KaiChiLin added 4 commits September 19, 2018 13:47

add customer error spec for Application Gateway

d9a3af3

fix property name issue

26299b4

Merge branch 'network-october-release' of https://github.com/Azure/az…

189b620

…ure-rest-api-specs into network-october-release

change appgw custom error status code enum and fix a typo of customEr…

7d9b9a9

…rorConfiguration

KaiChiLin requested a review from MikhailTryakhov as a code owner October 1, 2018 22:17

AutorestCI mentioned this pull request Oct 1, 2018

[AutoPR network/resource-manager] change appgw custom error status code enum and fix a typo of customErrorConfigurations Azure/azure-sdk-for-python#3478

Merged

AutorestCI mentioned this pull request Oct 1, 2018

[AutoPR network/resource-manager] change appgw custom error status code enum and fix a typo of customErrorConfigurations Azure/azure-sdk-for-go#2881

Merged

AutorestCI mentioned this pull request Oct 1, 2018

[AutoPR network/resource-manager] change appgw custom error status code enum and fix a typo of customErrorConfigurations Azure/azure-sdk-for-node#3745

Closed

azuresdkci assigned jianghaolu Oct 1, 2018

azuresdkci requested a review from jianghaolu October 1, 2018 23:01

jianghaolu approved these changes Oct 1, 2018

View reviewed changes

MikhailTryakhov suggested changes Oct 2, 2018

View reviewed changes

MikhailTryakhov approved these changes Oct 3, 2018

View reviewed changes

jianghaolu merged commit a6ea587 into Azure:network-october-release Oct 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change appgw custom error status code enum and fix a typo of customErrorConfigurations #4050

change appgw custom error status code enum and fix a typo of customErrorConfigurations #4050

KaiChiLin commented Oct 1, 2018

AutorestCI commented Oct 1, 2018 •

edited

Loading

AutorestCI commented Oct 1, 2018 •

edited

Loading

AutorestCI commented Oct 1, 2018 •

edited

Loading

AutorestCI commented Oct 1, 2018 •

edited

Loading

azuresdkci commented Oct 1, 2018

AutorestCI commented Oct 1, 2018 •

edited

Loading

AutorestCI commented Oct 1, 2018 •

edited

Loading

MikhailTryakhov commented Oct 2, 2018

MikhailTryakhov left a comment •

edited

Loading

MikhailTryakhov left a comment

change appgw custom error status code enum and fix a typo of customErrorConfigurations #4050

change appgw custom error status code enum and fix a typo of customErrorConfigurations #4050

Conversation

KaiChiLin commented Oct 1, 2018

PR information

Quality of Swagger

AutorestCI commented Oct 1, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Oct 1, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Oct 1, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Oct 1, 2018 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Oct 1, 2018

AutorestCI commented Oct 1, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Oct 1, 2018 • edited Loading

Automation for azure-sdk-for-node

MikhailTryakhov commented Oct 2, 2018

MikhailTryakhov left a comment • edited Loading

Choose a reason for hiding this comment

MikhailTryakhov left a comment

Choose a reason for hiding this comment

AutorestCI commented Oct 1, 2018 •

edited

Loading

AutorestCI commented Oct 1, 2018 •

edited

Loading

AutorestCI commented Oct 1, 2018 •

edited

Loading

AutorestCI commented Oct 1, 2018 •

edited

Loading

AutorestCI commented Oct 1, 2018 •

edited

Loading

AutorestCI commented Oct 1, 2018 •

edited

Loading

MikhailTryakhov left a comment •

edited

Loading