Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying example templates : enabling Ipv6 support for Private Peering #4232

Merged
merged 2 commits into from
Oct 15, 2018

Conversation

wiz0kraft-zz
Copy link

@wiz0kraft-zz wiz0kraft-zz commented Oct 13, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 13, 2018

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 13, 2018

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 13, 2018

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 13, 2018

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 9f34cb6 into Azure:master Oct 15, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Oct 15, 2018

@wiz0kraft please open a PR to merge these changes into the October branch as well

anton-evseev pushed a commit to anton-evseev/azure-rest-api-specs that referenced this pull request Oct 17, 2018
…ng (Azure#4232)

* Modifying example templates : enabling Ipv6 support for Private Peering

* Resolving oav validation error
dsgouda pushed a commit that referenced this pull request Oct 18, 2018
* Remove error code from swagger (#4103)

* Modifying example templates : enabling Ipv6 support for Private Peering (#4232)

* Modifying example templates : enabling Ipv6 support for Private Peering

* Resolving oav validation error
lmazuel added a commit that referenced this pull request Oct 30, 2018
* Updated NetworkConfigurationDiagnostic API + example (#3905)

* Fix incorrect API versions in Network's examples (#3954)

* Fixed incorrect API versions in 2018-08-01's examples Added missing example for serviceEndpointPolicy.json

* Fixed incorrect API version in 2018-07-01 example

* swagger change for application gateway waf global config and exclusion list (#3972)

* swagger change for application gateway waf global config and exclusion list

* address the comments

* add customer error spec for Application Gateway (#3985)

* add customer error spec for Application Gateway

* fix property name issue

* Add ICMP to the list of supported protocols (#3993)

* change appgw custom error status code enum and fix a typo of customErrorConfigurations (#4050)

* add customer error spec for Application Gateway

* fix property name issue

* change appgw custom error status code enum and fix a typo of customErrorConfiguration

* Add ExpressRoutePort swagger (#4104)

* Add ExpressRoutePort details to readme.md

* ExpressRoutePort swagger

* Refer SubscriptionIdParameter and ApiVersionParameter from network.json

* Cherry pick NRP's changes from master to October branch (#4251)

* Remove error code from swagger (#4103)

* Modifying example templates : enabling Ipv6 support for Private Peering (#4232)

* Modifying example templates : enabling Ipv6 support for Private Peering

* Resolving oav validation error

* Changes to add operation id for outbound rules (#4320)

* Changes to add operation id for outbound rules

* Changes to make outbound rule similar to load balancing rule

* fix failures - add example json files

* fix failures

* Fixed line endings, specs, examples

* Change one parameter (#4339)

* Change parameter in most recent version

* Fix example

* New SKU for ER (#4342)
@wiz0kraft-zz
Copy link
Author

wiz0kraft-zz commented Nov 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants