-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying example templates : enabling Ipv6 support for Private Peering #4232
Modifying example templates : enabling Ipv6 support for Private Peering #4232
Conversation
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-nodeUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-jsUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wiz0kraft please open a PR to merge these changes into the October branch as well |
…ng (Azure#4232) * Modifying example templates : enabling Ipv6 support for Private Peering * Resolving oav validation error
* Updated NetworkConfigurationDiagnostic API + example (#3905) * Fix incorrect API versions in Network's examples (#3954) * Fixed incorrect API versions in 2018-08-01's examples Added missing example for serviceEndpointPolicy.json * Fixed incorrect API version in 2018-07-01 example * swagger change for application gateway waf global config and exclusion list (#3972) * swagger change for application gateway waf global config and exclusion list * address the comments * add customer error spec for Application Gateway (#3985) * add customer error spec for Application Gateway * fix property name issue * Add ICMP to the list of supported protocols (#3993) * change appgw custom error status code enum and fix a typo of customErrorConfigurations (#4050) * add customer error spec for Application Gateway * fix property name issue * change appgw custom error status code enum and fix a typo of customErrorConfiguration * Add ExpressRoutePort swagger (#4104) * Add ExpressRoutePort details to readme.md * ExpressRoutePort swagger * Refer SubscriptionIdParameter and ApiVersionParameter from network.json * Cherry pick NRP's changes from master to October branch (#4251) * Remove error code from swagger (#4103) * Modifying example templates : enabling Ipv6 support for Private Peering (#4232) * Modifying example templates : enabling Ipv6 support for Private Peering * Resolving oav validation error * Changes to add operation id for outbound rules (#4320) * Changes to add operation id for outbound rules * Changes to make outbound rule similar to load balancing rule * fix failures - add example json files * fix failures * Fixed line endings, specs, examples * Change one parameter (#4339) * Change parameter in most recent version * Fix example * New SKU for ER (#4342)
I don't see an October branch as of now.
Regards,
Abhinav
…On Tue, Oct 16, 2018 at 2:40 AM Deepak Shankargouda < ***@***.***> wrote:
@wiz0kraft <https://github.com/wiz0kraft> please open a PR to merge these
changes into the October
<https://github.com/Azure/azure-rest-api-specs/tree/network-october-release>
branch as well
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4232 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVVNjlJQATtTwmqDX3jutDlpqX--MFT1ks5ulPnXgaJpZM4XajPp>
.
|
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger