Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NetworkConfigurationDiagnostic API + example #3905

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Updated NetworkConfigurationDiagnostic API + example #3905

merged 1 commit into from
Sep 14, 2018

Conversation

irrogozh
Copy link
Member

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1642

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_network-october-release
  stderr: 'To https://github.com/Azure/azure-sdk-for-python.git
 ! [rejected]            restapi_auto_network-october-release -> restapi_auto_network-october-release (fetch first)
error: failed to push some refs to 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-python.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2391

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpxiexvdsx/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpxiexvdsx/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.110', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.4]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Including configuration file 'file:///tmp/tmpxiexvdsx/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.110->2.1.110)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-07"} .
   Including configuration file 'file:///tmp/tmpxiexvdsx/rest/specification/network/resource-manager/readme.go.md'
Shutting Down
Shutting Down
FATAL: go/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Failure during batch task - {"tag":"package-2018-07"} -- false.

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpdbbd_9mv/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpdbbd_9mv/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.1.103']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.103->2.1.103)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.

@lmazuel
Copy link
Member

lmazuel commented Sep 14, 2018

@jianghaolu I'm stealing this PR from you, since I have context from @irrogozh . Let me know if you have any concerns. Thanks!

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmazuel lmazuel merged commit 4b3ae81 into Azure:network-october-release Sep 14, 2018
lmazuel added a commit that referenced this pull request Oct 30, 2018
* Updated NetworkConfigurationDiagnostic API + example (#3905)

* Fix incorrect API versions in Network's examples (#3954)

* Fixed incorrect API versions in 2018-08-01's examples Added missing example for serviceEndpointPolicy.json

* Fixed incorrect API version in 2018-07-01 example

* swagger change for application gateway waf global config and exclusion list (#3972)

* swagger change for application gateway waf global config and exclusion list

* address the comments

* add customer error spec for Application Gateway (#3985)

* add customer error spec for Application Gateway

* fix property name issue

* Add ICMP to the list of supported protocols (#3993)

* change appgw custom error status code enum and fix a typo of customErrorConfigurations (#4050)

* add customer error spec for Application Gateway

* fix property name issue

* change appgw custom error status code enum and fix a typo of customErrorConfiguration

* Add ExpressRoutePort swagger (#4104)

* Add ExpressRoutePort details to readme.md

* ExpressRoutePort swagger

* Refer SubscriptionIdParameter and ApiVersionParameter from network.json

* Cherry pick NRP's changes from master to October branch (#4251)

* Remove error code from swagger (#4103)

* Modifying example templates : enabling Ipv6 support for Private Peering (#4232)

* Modifying example templates : enabling Ipv6 support for Private Peering

* Resolving oav validation error

* Changes to add operation id for outbound rules (#4320)

* Changes to add operation id for outbound rules

* Changes to make outbound rule similar to load balancing rule

* fix failures - add example json files

* fix failures

* Fixed line endings, specs, examples

* Change one parameter (#4339)

* Change parameter in most recent version

* Fix example

* New SKU for ER (#4342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants