-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated NetworkConfigurationDiagnostic API + example #3905
Updated NetworkConfigurationDiagnostic API + example #3905
Conversation
Automation for azure-sdk-for-rubyA PR has been created for you: |
Automation for azure-sdk-for-pythonEncountered an unknown error: (azure-sdk-for-python)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
sdk_repo.git.push('origin', base_branch, set_upstream=True)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
return self.execute(call, **exec_kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
cmdline: git push --set-upstream origin restapi_auto_network-october-release
stderr: 'To https://github.com/Azure/azure-sdk-for-python.git
! [rejected] restapi_auto_network-october-release -> restapi_auto_network-october-release (fetch first)
error: failed to push some refs to 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-python.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.' |
Automation for azure-sdk-for-javaA PR has been created for you: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: ['/usr/local/bin/autorest', '/tmp/tmpxiexvdsx/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpxiexvdsx/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.110', '--use-onever', '--verbose'] AutoRest code generation utility [version: 2.0.4283; node: v8.11.4]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
Including configuration file 'file:///tmp/tmpxiexvdsx/rest/specification/network/resource-manager/readme.go.md'
Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.110->2.1.110)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-07"} .
Including configuration file 'file:///tmp/tmpxiexvdsx/rest/specification/network/resource-manager/readme.go.md'
Shutting Down
Shutting Down
FATAL: go/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Failure during batch task - {"tag":"package-2018-07"} -- false. |
Automation for azure-sdk-for-nodeEncountered a Subprocess error: (azure-sdk-for-node)
Command: ['/usr/local/bin/autorest', '/tmp/tmpdbbd_9mv/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpdbbd_9mv/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.1.103'] AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.103->2.1.103)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated. |
@jianghaolu I'm stealing this PR from you, since I have context from @irrogozh . Let me know if you have any concerns. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Updated NetworkConfigurationDiagnostic API + example (#3905) * Fix incorrect API versions in Network's examples (#3954) * Fixed incorrect API versions in 2018-08-01's examples Added missing example for serviceEndpointPolicy.json * Fixed incorrect API version in 2018-07-01 example * swagger change for application gateway waf global config and exclusion list (#3972) * swagger change for application gateway waf global config and exclusion list * address the comments * add customer error spec for Application Gateway (#3985) * add customer error spec for Application Gateway * fix property name issue * Add ICMP to the list of supported protocols (#3993) * change appgw custom error status code enum and fix a typo of customErrorConfigurations (#4050) * add customer error spec for Application Gateway * fix property name issue * change appgw custom error status code enum and fix a typo of customErrorConfiguration * Add ExpressRoutePort swagger (#4104) * Add ExpressRoutePort details to readme.md * ExpressRoutePort swagger * Refer SubscriptionIdParameter and ApiVersionParameter from network.json * Cherry pick NRP's changes from master to October branch (#4251) * Remove error code from swagger (#4103) * Modifying example templates : enabling Ipv6 support for Private Peering (#4232) * Modifying example templates : enabling Ipv6 support for Private Peering * Resolving oav validation error * Changes to add operation id for outbound rules (#4320) * Changes to add operation id for outbound rules * Changes to make outbound rule similar to load balancing rule * fix failures - add example json files * fix failures * Fixed line endings, specs, examples * Change one parameter (#4339) * Change parameter in most recent version * Fix example * New SKU for ER (#4342)
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger