Microsoft.ContainerService API Version 2020-02-01 #8388

gtxistxgao · 2020-02-13T06:43:06Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing properties.
- Added "Spot" option for ScaleSetPriority enum.
- Added "SpotMaxPrice" property to support customize Spot Pool max price setting.
- Added "networkMode" property for Network mode used for building Kubernetes network.
- Added "autoScalerProfile" property to be applied to the cluster-autoscaler when enabled.
adding/removing API-version.
- Added 2020-02-01 API Version

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…/2020-01-01 to version 2020-02-01

* Spot Pool Change * type has to be number * ref example

* Add properties for networkMode * rm the empty enum

* add autoScalerProfile to spec * add example for put MC * add to custom words * add list of accepted params * disable linting for profile * update example

azure-pipelines · 2020-02-13T06:43:21Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-13T06:44:44Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-13T06:44:45Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from fe24e32 with merge commit a737593. SDK Automation 13.0.17.20191226.1
⚠️containerservice/mgmt/2017-07-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2017-08-31 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2017-09-30 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2018-03-31 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-02-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-04-30 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-10-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-11-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2020-01-01 [Logs]
```
No file is changed.
```
️✔️containerservice/mgmt/2020-02-01 [Logs] [Release SDK Changes]
- containerservice.mgmt.2020-02-01.zip
⚠️preview/containerservice/mgmt/2018-08-01-preview [Logs]
```
No file is changed.
```
⚠️preview/containerservice/mgmt/2018-09-30-preview [Logs]
```
No file is changed.
```
⚠️preview/containerservice/mgmt/2019-09-30-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-02-13T06:44:47Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fe24e32 with merge commit a737593. SDK Automation 13.0.17.20191226.1
️✔️sdk/containerservice/mgmt-v2019_06_01 [Logs] [Release SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_08_01 [Logs] [Release SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_10_01 [Logs] [Release SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_11_01 [Logs] [Release SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_01_01 [Logs] [Release SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_02_01 [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-02-13T06:44:48Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fe24e32 with merge commit a737593. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-containerservice [Logs] [Release SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-07-01', '2019-04-01'} in label v2017_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2020-02-13T06:44:48Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fe24e32 with merge commit a737593. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ContainerService [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.ContainerService.1.0.0.nupkg
- Microsoft.Azure.Management.ContainerService.1.0.0.snupkg

openapi-sdkautomation · 2020-02-13T06:44:51Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fe24e32 with merge commit a737593. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-containerservice [Logs] [Release SDK Changes]

azure-arm-containerservice-10.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
[npmPack] created ./dist/arm-containerservice.js in 481ms

andyzhangx · 2020-02-13T07:53:03Z

@gtxistxgao could you give a detailed list about what's this version change compared to 2020-01-01? and also there is test failure.

azure-pipelines · 2020-02-13T07:58:45Z

Azure Pipelines successfully started running 1 pipeline(s).

andyzhangx · 2020-02-13T08:07:23Z

...rce-manager/Microsoft.ContainerService/stable/2020-02-01/examples/AgentPoolsCreate_Spot.json

@@ -0,0 +1,84 @@
+{


new parameters are added into a new file( AgentPoolsCreate_Spot.json) other than AgentPoolsCreate_Update.json, I am not sure whether this is the right way.
@zikalino could you take a look? Thanks.

It's reviewed earlier. #8342

this is just the example spec and its linked to here

andyzhangx

/lgtm

yungezz · 2020-02-13T08:47:21Z

...erservice/resource-manager/Microsoft.ContainerService/stable/2020-02-01/managedClusters.json

+            }
+          }
+        },
+        "x-ms-long-running-operation": true,


just confirm, updating tag is long running operation either.

It doesn't seems to be a long running operation. But this value is not related to the changes happens in this API version and is the same with previous version 2020-01-01 as it is copied automatically by OpenAPI.

majastrz · 2020-02-13T23:22:08Z

...erservice/resource-manager/Microsoft.ContainerService/stable/2020-02-01/managedClusters.json

+          "description": "(PREVIEW) Whether to enable Kubernetes Pod security policy."
+        },
+        "networkProfile": {
+          "$ref": "#/definitions/


scan-interval [](start = 13, length = 13)

I discussed this on another PR. Generally the naming convention is lowerCaseCamelCase for property names, but since these are passed through to a Kubernetes extension, I think there's value in keeping them as-is. Otherwise, the users will have to create a mental mapping between scanInterval becoming scan-interval and some for all others.

Yup, for instance the Python SDK would show it as "scanInterval" in the GET MC response. But for serializing and deserializing, they'd do the conversion to/from "scan-interval" properly. I think it's a tradeoff here to achieve recognizable parameters.

majastrz

Signed off from ARM side.

yungezz · 2020-02-14T01:20:14Z

HI @marwanad is the PR ready to merge? that means, service change is on Prod already. thanks.

gtxistxgao · 2020-02-14T01:51:29Z

HI @marwanad is the PR ready to merge? that means, service change is on Prod already. thanks.

@yungezz Yes. it's ready to merge. Server side code is ready and manifest has been released.

Xiaofang Zhang and others added 6 commits February 7, 2020 18:37

Adds base for updating Microsoft.ContainerService from version stable…

b41fea4

…/2020-01-01 to version 2020-02-01

Updates readme

1c9c569

Updates API version in new specs and examples

073369f

Spot Pool Change (#8342)

570c01c

* Spot Pool Change * type has to be number * ref example

Add networkMode to AKS 20200201 API (#8343)

4c1552b

* Add properties for networkMode * rm the empty enum

AutoScaler Profile Change (#8350)

fe24e32

* add autoScalerProfile to spec * add example for put MC * add to custom words * add list of accepted params * disable linting for profile * update example

openapi-assignment-bot bot assigned yungezz Feb 13, 2020

gtxistxgao requested a review from andyzhangx February 13, 2020 07:33

andyzhangx reviewed Feb 13, 2020

View reviewed changes

andyzhangx approved these changes Feb 13, 2020

View reviewed changes

yungezz reviewed Feb 13, 2020

View reviewed changes

yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 13, 2020

majastrz reviewed Feb 13, 2020

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 13, 2020

majastrz approved these changes Feb 13, 2020

View reviewed changes

yungezz merged commit a737593 into master Feb 14, 2020

ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020

Microsoft.ContainerService API Version 2020-02-01 (Azure#8388)

6b6755b

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Microsoft.ContainerService API Version 2020-02-01 (Azure#8388)

0fa9148

FumingZhang deleted the dev-containerservice-Microsoft.ContainerService-2020-02-01 branch February 26, 2024 05:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsoft.ContainerService API Version 2020-02-01 #8388

Microsoft.ContainerService API Version 2020-02-01 #8388

gtxistxgao commented Feb 13, 2020 •

edited

Loading

azure-pipelines bot commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

openapi-sdkautomation bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 13, 2020 •

edited

Loading

andyzhangx commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

andyzhangx Feb 13, 2020

gtxistxgao Feb 13, 2020

marwanad Feb 13, 2020

andyzhangx left a comment

yungezz Feb 13, 2020

gtxistxgao Feb 13, 2020

majastrz Feb 13, 2020

marwanad Feb 13, 2020

majastrz left a comment

yungezz commented Feb 14, 2020

gtxistxgao commented Feb 14, 2020 •

edited

Loading

Microsoft.ContainerService API Version 2020-02-01 #8388

Microsoft.ContainerService API Version 2020-02-01 #8388

Conversation

gtxistxgao commented Feb 13, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

openapi-sdkautomation bot commented Feb 13, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Feb 13, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Feb 13, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Feb 13, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Feb 13, 2020 • edited Loading

azure-sdk-for-js - Release

andyzhangx commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

andyzhangx Feb 13, 2020

Choose a reason for hiding this comment

gtxistxgao Feb 13, 2020

Choose a reason for hiding this comment

marwanad Feb 13, 2020

Choose a reason for hiding this comment

andyzhangx left a comment

Choose a reason for hiding this comment

yungezz Feb 13, 2020

Choose a reason for hiding this comment

gtxistxgao Feb 13, 2020

Choose a reason for hiding this comment

majastrz Feb 13, 2020

Choose a reason for hiding this comment

marwanad Feb 13, 2020

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

yungezz commented Feb 14, 2020

gtxistxgao commented Feb 14, 2020 • edited Loading

gtxistxgao commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 13, 2020 •

edited

Loading

gtxistxgao commented Feb 14, 2020 •

edited

Loading