Add IpAllocation resource for Hypernet IP management. #8701

liuh-80 · 2020-03-13T02:53:57Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

liuh-80 · 2020-03-13T02:54:41Z

Change reviewed in private repo, here is link: https://github.com/Azure/azure-rest-api-specs-pr/pull/1121

azure-pipelines · 2020-03-13T02:59:01Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-13T03:00:17Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ede1338 with merge commit 836d8385dcb532796df6664a735cd987ca5feeb2. SDK Automation 13.0.17.20200326.3
⚠️network/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-03-30 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-06-01 [Logs]
```
No file is changed.
```
️✔️network/mgmt/2016-09-01 [Logs] [Preview SDK Changes]
- network.mgmt.2016-09-01.zip
️✔️network/mgmt/2016-12-01 [Logs] [Preview SDK Changes]
- network.mgmt.2016-12-01.zip
⚠️network/mgmt/2017-03-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-09-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-01-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-04-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-10-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-12-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-02-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-07-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-09-01 [Logs]
```
No file is changed.
```
️✔️network/mgmt/2019-11-01 [Logs] [Preview SDK Changes]
- network.mgmt.2019-11-01.zip
⚠️preview/network/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-03-13T03:00:21Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ede1338 with merge commit 836d8385dcb532796df6664a735cd987ca5feeb2. SDK Automation 13.0.17.20200326.3

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Network [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Network.19.19.0-preview.nupkg
- Microsoft.Azure.Management.Network.19.19.0-preview.snupkg

openapi-sdkautomation · 2020-03-13T03:00:22Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ede1338 with merge commit 836d8385dcb532796df6664a735cd987ca5feeb2. SDK Automation 13.0.17.20200326.3
️✔️sdk/network/mgmt-v2019_02_01 [Logs] [Preview SDK Changes]

⚠️sdk/network/mgmt-v2019_04_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
[mvn]   symbol:   method serviceName()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
[mvn]   symbol:   method serviceName()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
[mvn]   symbol:   method availableResourceGroupPrivateEndpointTypes()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
[mvn] [ERROR]   symbol:   method serviceName()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
[mvn] [ERROR]   symbol:   method serviceName()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
[mvn] [ERROR]   symbol:   method availableResourceGroupPrivateEndpointTypes()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

️✔️sdk/network/mgmt-v2019_06_01 [Logs] [Preview SDK Changes]
️✔️sdk/network/mgmt-v2019_07_01 [Logs] [Preview SDK Changes]
️✔️sdk/network/mgmt-v2019_08_01 [Logs] [Preview SDK Changes]

⚠️sdk/network/mgmt-v2019_09_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
[mvn]   symbol:   class ResourceNavigationLinkInner
[mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
[mvn]   symbol:   class ServiceAssociationLinkInner
[mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
[mvn] [ERROR]   symbol:   class ResourceNavigationLinkInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
[mvn] [ERROR]   symbol:   class ServiceAssociationLinkInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-03-13T03:00:24Z

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ede1338 with merge commit 836d8385dcb532796df6664a735cd987ca5feeb2. SDK Automation 13.0.17.20200326.3
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-03-13T03:00:26Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ede1338 with merge commit 836d8385dcb532796df6664a735cd987ca5feeb2. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-network [Logs] [Preview SDK Changes]

azure-arm-network-20.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
[npmPack] created ./dist/arm-network.js in 2.7s

azuresdkci · 2020-03-13T03:10:07Z

Can one of the admins verify this patch?

anton-evseev

LGTM except a few minor comments

specification/network/resource-manager/readme.md

specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/ipAllocation.json

azure-pipelines · 2020-03-13T13:34:52Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-03-16T04:14:48Z

@raych1 Shall we dismiss breaking change in this case?

liuh-80 · 2020-03-16T05:50:31Z

@raych1 Shall we dismiss breaking change in this case?

This PR will add new property to VirtualNetwork and Subnet resource, this is by design.

raych1 · 2020-03-16T11:41:54Z

@raych1 Shall we dismiss breaking change in this case?

@NullMDR , we synced up on this and pls label this PR instead.

specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/ipAllocation.json

specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/virtualNetwork.json

pilor

Comments above

azure-pipelines · 2020-03-24T03:10:39Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-25T03:35:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-25T05:36:58Z

Azure Pipelines successfully started running 1 pipeline(s).

pilor

1 unresolved issue

azure-pipelines · 2020-03-26T01:50:01Z

Azure Pipelines successfully started running 1 pipeline(s).

pilor

azure-pipelines · 2020-03-27T03:37:42Z

Azure Pipelines successfully started running 1 pipeline(s).

liuh-80 · 2020-03-27T05:14:24Z

@NullMDR , could you please help to merge this PR? because this is a break change so the 'public.rest-api-specs (BreakingChange) ' UT can't pass.

* Adds base for updating Microsoft.Network from version stable/2019-12-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix… (#8708) * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix documentation issues * Fix readme file Co-authored-by: Vinaya Damle <vinayada@microsoft.com> * Adding SecurityPartnerProvider Resource (#8721) * Adding securityPartnerProvider resource * Adding securityPartnerProvider resource : 2 * Added Definition for SecurityPartnerProviderListResult * Updated Readme.md with securityPartnerProvider * fixing zone.. * Fixing using Prettier * desc fix * Fixing enum conflict * RequiredPropertiesMissingInResourceModel Fix * capitalizing alphabets * renaming list/listall * Updated Tags to Caps Co-authored-by: Ishani Gupta <isgu@microsoft.com> * AzureFirewall User Tags Update (#8748) * AzureFirewall User Tags Update * Prettier Fixes Co-authored-by: Ishani Gupta <isgu@microsoft.com> * Add IpAllocation resource for Hypernet IP management. (#8701) * Add IpAllocation resource for Hypernet IP management. * Fix path issue. * Fix some issues by PR comments. * Fix document issue. * Fix reference with SubResource. * Fix IpAllocation tags name issue. * Add patch operation to IpAllocation resource. * Fix spell issue with pretter. * Introducing force policy association feature (#8738) * Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. (#8704) * Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint * Adding endzone keyword for build * Adding reference to 2020 private endpoint in readme for validation purposes * Misspelled reference to Get file fixed * Ran prettier fix on files * Removing reference in readme * Added some needed capitilization and punctuation, will be a pt2 to this commit * Added descriptions * Rerunning tests. * Updated definitions for customdnsconfig and record set * Rebuilding for pr * Changing word back to original sentence for PR. * Changed name in example file for create, as well as added List operation and fixed pr comments * resolved comments based on pr * Added changes based on PRcomments * Added integer tag to ttl * getting rid of type in private endpoint json * Changed type attribute in privateendpointdnszonegroupget * Added read only attribute to record set array Co-authored-by: Shane Baden <shbaden@microsoft.com> * Adding intrusionSystemMode property to firewallPolicy (#8885) * Add intrusionSystemMode to firewallPolicy * Change intrusionSystemMode to be either Enabled or Disabled * fix pretier * remove white space * remove the examples as this is a preview feature Co-authored-by: Shany Pozin <shanyp@microsoft.com> * DPDTimeout Multiple Radius for VPN Gateways (Network) (#8707) * DPDTimeout Multiple Radius changes * PR feedback, resource changes * PR feedback, example changes * examples fix * PR feedback * CI fix * prettier fix attempt Co-authored-by: Mikhail <mitryakh@microsoft.com> Co-authored-by: vinayada1 <vinayadamle@gmail.com> Co-authored-by: Vinaya Damle <vinayada@microsoft.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: liuh-80 <58683130+liuh-80@users.noreply.github.com> Co-authored-by: Venkata Krishnan Anantha Raman <venkatakrishnansvpr@gmail.com> Co-authored-by: Shane Baden <naruto.shane@gmail.com> Co-authored-by: Shane Baden <shbaden@microsoft.com> Co-authored-by: Shany Pozin <shanyp@gmail.com> Co-authored-by: Shany Pozin <shanyp@microsoft.com> Co-authored-by: Henry Chen <henche@microsoft.com>

* Adds base for updating Microsoft.Network from version stable/2019-12-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix… (Azure#8708) * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix documentation issues * Fix readme file Co-authored-by: Vinaya Damle <vinayada@microsoft.com> * Adding SecurityPartnerProvider Resource (Azure#8721) * Adding securityPartnerProvider resource * Adding securityPartnerProvider resource : 2 * Added Definition for SecurityPartnerProviderListResult * Updated Readme.md with securityPartnerProvider * fixing zone.. * Fixing using Prettier * desc fix * Fixing enum conflict * RequiredPropertiesMissingInResourceModel Fix * capitalizing alphabets * renaming list/listall * Updated Tags to Caps Co-authored-by: Ishani Gupta <isgu@microsoft.com> * AzureFirewall User Tags Update (Azure#8748) * AzureFirewall User Tags Update * Prettier Fixes Co-authored-by: Ishani Gupta <isgu@microsoft.com> * Add IpAllocation resource for Hypernet IP management. (Azure#8701) * Add IpAllocation resource for Hypernet IP management. * Fix path issue. * Fix some issues by PR comments. * Fix document issue. * Fix reference with SubResource. * Fix IpAllocation tags name issue. * Add patch operation to IpAllocation resource. * Fix spell issue with pretter. * Introducing force policy association feature (Azure#8738) * Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. (Azure#8704) * Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint * Adding endzone keyword for build * Adding reference to 2020 private endpoint in readme for validation purposes * Misspelled reference to Get file fixed * Ran prettier fix on files * Removing reference in readme * Added some needed capitilization and punctuation, will be a pt2 to this commit * Added descriptions * Rerunning tests. * Updated definitions for customdnsconfig and record set * Rebuilding for pr * Changing word back to original sentence for PR. * Changed name in example file for create, as well as added List operation and fixed pr comments * resolved comments based on pr * Added changes based on PRcomments * Added integer tag to ttl * getting rid of type in private endpoint json * Changed type attribute in privateendpointdnszonegroupget * Added read only attribute to record set array Co-authored-by: Shane Baden <shbaden@microsoft.com> * Adding intrusionSystemMode property to firewallPolicy (Azure#8885) * Add intrusionSystemMode to firewallPolicy * Change intrusionSystemMode to be either Enabled or Disabled * fix pretier * remove white space * remove the examples as this is a preview feature Co-authored-by: Shany Pozin <shanyp@microsoft.com> * DPDTimeout Multiple Radius for VPN Gateways (Network) (Azure#8707) * DPDTimeout Multiple Radius changes * PR feedback, resource changes * PR feedback, example changes * examples fix * PR feedback * CI fix * prettier fix attempt Co-authored-by: Mikhail <mitryakh@microsoft.com> Co-authored-by: vinayada1 <vinayadamle@gmail.com> Co-authored-by: Vinaya Damle <vinayada@microsoft.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: liuh-80 <58683130+liuh-80@users.noreply.github.com> Co-authored-by: Venkata Krishnan Anantha Raman <venkatakrishnansvpr@gmail.com> Co-authored-by: Shane Baden <naruto.shane@gmail.com> Co-authored-by: Shane Baden <shbaden@microsoft.com> Co-authored-by: Shany Pozin <shanyp@gmail.com> Co-authored-by: Shany Pozin <shanyp@microsoft.com> Co-authored-by: Henry Chen <henche@microsoft.com>

Add IpAllocation resource for Hypernet IP management.

889929c

liuh-80 requested review from MikhailTryakhov, anton-evseev and v-shhatt as code owners March 13, 2020 02:53

openapi-assignment-bot bot assigned PhoenixHe-NV Mar 13, 2020

Fix path issue.

fbe7b96

This was referenced Mar 13, 2020

[AutoPR azure-mgmt-network] Add IpAllocation resource for Hypernet IP management. AzureSDKAutomation/azure-sdk-for-python#587

Open

[AutoPR @azure/arm-network] Add IpAllocation resource for Hypernet IP management. AzureSDKAutomation/azure-sdk-for-js#786

Open

PhoenixHe-NV added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 13, 2020

anton-evseev suggested changes Mar 13, 2020

View reviewed changes

Fix some issues by PR comments.

3803dc1

anton-evseev approved these changes Mar 13, 2020

View reviewed changes