Adding SecurityPartnerProvider Resource #8721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaniGupta27
requested review from
MikhailTryakhov,
anton-evseev and
v-shhatt
as code owners
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ishaniGupta27
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go
|
azure-sdk-for-java
|
azure-sdk-for-js
|
azure-sdk-for-python
|
azure-sdk-for-net
|
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 16, 2020
leni-msft
added
the
WaitForARMFeedback
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Addressed the comments:
|
anthony-c-martin
added
ARMSignedOff
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anton-evseev
suggested changes
Mar 19, 2020
| "tags": [ | ||
| "securityPartnerProviders" | ||
| ], | ||
| "operationId": "securityPartnerProviders_Delete", |
There was a problem hiding this comment.
Suggested change
| "operationId": "securityPartnerProviders_Delete", | |
| "operationId": "SecurityPartnerProviders_Delete", |
Please do this change in other parts of the spec
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/securityPartnerProviders/{securityPartnerProviderName}": { | ||
| "delete": { | ||
| "tags": [ | ||
| "securityPartnerProviders" |
There was a problem hiding this comment.
Suggested change
| "securityPartnerProviders" | |
| "SecurityPartnerProviders" |
Please do this change in other parts of the spec
| "tags": [ | ||
| "securityPartnerProviders" | ||
| ], | ||
| "operationId": "securityPartnerProviders_List", |
There was a problem hiding this comment.
Suggested change
| "operationId": "securityPartnerProviders_List", | |
| "operationId": "SecurityPartnerProviders_ListByResourceGroup", |
| "tags": [ | ||
| "securityPartnerProviders" | ||
| ], | ||
| "operationId": "securityPartnerProviders_ListAll", |
There was a problem hiding this comment.
Suggested change
| "operationId": "securityPartnerProviders_ListAll", | |
| "operationId": "SecurityPartnerProviders_List", |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lirenhe
removed
the
Reviewed-ChangesRequested
lirenhe
approved these changes
Mar 20, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
anton-evseev
approved these changes
Mar 23, 2020
mmyyrroonn
pushed a commit
that referenced
this pull request
Apr 8, 2020
* Adds base for updating Microsoft.Network from version stable/2019-12-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix… (#8708) * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix documentation issues * Fix readme file Co-authored-by: Vinaya Damle <vinayada@microsoft.com> * Adding SecurityPartnerProvider Resource (#8721) * Adding securityPartnerProvider resource * Adding securityPartnerProvider resource : 2 * Added Definition for SecurityPartnerProviderListResult * Updated Readme.md with securityPartnerProvider * fixing zone.. * Fixing using Prettier * desc fix * Fixing enum conflict * RequiredPropertiesMissingInResourceModel Fix * capitalizing alphabets * renaming list/listall * Updated Tags to Caps Co-authored-by: Ishani Gupta <isgu@microsoft.com> * AzureFirewall User Tags Update (#8748) * AzureFirewall User Tags Update * Prettier Fixes Co-authored-by: Ishani Gupta <isgu@microsoft.com> * Add IpAllocation resource for Hypernet IP management. (#8701) * Add IpAllocation resource for Hypernet IP management. * Fix path issue. * Fix some issues by PR comments. * Fix document issue. * Fix reference with SubResource. * Fix IpAllocation tags name issue. * Add patch operation to IpAllocation resource. * Fix spell issue with pretter. * Introducing force policy association feature (#8738) * Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. (#8704) * Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint * Adding endzone keyword for build * Adding reference to 2020 private endpoint in readme for validation purposes * Misspelled reference to Get file fixed * Ran prettier fix on files * Removing reference in readme * Added some needed capitilization and punctuation, will be a pt2 to this commit * Added descriptions * Rerunning tests. * Updated definitions for customdnsconfig and record set * Rebuilding for pr * Changing word back to original sentence for PR. * Changed name in example file for create, as well as added List operation and fixed pr comments * resolved comments based on pr * Added changes based on PRcomments * Added integer tag to ttl * getting rid of type in private endpoint json * Changed type attribute in privateendpointdnszonegroupget * Added read only attribute to record set array Co-authored-by: Shane Baden <shbaden@microsoft.com> * Adding intrusionSystemMode property to firewallPolicy (#8885) * Add intrusionSystemMode to firewallPolicy * Change intrusionSystemMode to be either Enabled or Disabled * fix pretier * remove white space * remove the examples as this is a preview feature Co-authored-by: Shany Pozin <shanyp@microsoft.com> * DPDTimeout Multiple Radius for VPN Gateways (Network) (#8707) * DPDTimeout Multiple Radius changes * PR feedback, resource changes * PR feedback, example changes * examples fix * PR feedback * CI fix * prettier fix attempt Co-authored-by: Mikhail <mitryakh@microsoft.com> Co-authored-by: vinayada1 <vinayadamle@gmail.com> Co-authored-by: Vinaya Damle <vinayada@microsoft.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: liuh-80 <58683130+liuh-80@users.noreply.github.com> Co-authored-by: Venkata Krishnan Anantha Raman <venkatakrishnansvpr@gmail.com> Co-authored-by: Shane Baden <naruto.shane@gmail.com> Co-authored-by: Shane Baden <shbaden@microsoft.com> Co-authored-by: Shany Pozin <shanyp@gmail.com> Co-authored-by: Shany Pozin <shanyp@microsoft.com> Co-authored-by: Henry Chen <henche@microsoft.com>
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Adds base for updating Microsoft.Network from version stable/2019-12-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix… (Azure#8708) * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix documentation issues * Fix readme file Co-authored-by: Vinaya Damle <vinayada@microsoft.com> * Adding SecurityPartnerProvider Resource (Azure#8721) * Adding securityPartnerProvider resource * Adding securityPartnerProvider resource : 2 * Added Definition for SecurityPartnerProviderListResult * Updated Readme.md with securityPartnerProvider * fixing zone.. * Fixing using Prettier * desc fix * Fixing enum conflict * RequiredPropertiesMissingInResourceModel Fix * capitalizing alphabets * renaming list/listall * Updated Tags to Caps Co-authored-by: Ishani Gupta <isgu@microsoft.com> * AzureFirewall User Tags Update (Azure#8748) * AzureFirewall User Tags Update * Prettier Fixes Co-authored-by: Ishani Gupta <isgu@microsoft.com> * Add IpAllocation resource for Hypernet IP management. (Azure#8701) * Add IpAllocation resource for Hypernet IP management. * Fix path issue. * Fix some issues by PR comments. * Fix document issue. * Fix reference with SubResource. * Fix IpAllocation tags name issue. * Add patch operation to IpAllocation resource. * Fix spell issue with pretter. * Introducing force policy association feature (Azure#8738) * Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. (Azure#8704) * Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint * Adding endzone keyword for build * Adding reference to 2020 private endpoint in readme for validation purposes * Misspelled reference to Get file fixed * Ran prettier fix on files * Removing reference in readme * Added some needed capitilization and punctuation, will be a pt2 to this commit * Added descriptions * Rerunning tests. * Updated definitions for customdnsconfig and record set * Rebuilding for pr * Changing word back to original sentence for PR. * Changed name in example file for create, as well as added List operation and fixed pr comments * resolved comments based on pr * Added changes based on PRcomments * Added integer tag to ttl * getting rid of type in private endpoint json * Changed type attribute in privateendpointdnszonegroupget * Added read only attribute to record set array Co-authored-by: Shane Baden <shbaden@microsoft.com> * Adding intrusionSystemMode property to firewallPolicy (Azure#8885) * Add intrusionSystemMode to firewallPolicy * Change intrusionSystemMode to be either Enabled or Disabled * fix pretier * remove white space * remove the examples as this is a preview feature Co-authored-by: Shany Pozin <shanyp@microsoft.com> * DPDTimeout Multiple Radius for VPN Gateways (Network) (Azure#8707) * DPDTimeout Multiple Radius changes * PR feedback, resource changes * PR feedback, example changes * examples fix * PR feedback * CI fix * prettier fix attempt Co-authored-by: Mikhail <mitryakh@microsoft.com> Co-authored-by: vinayada1 <vinayadamle@gmail.com> Co-authored-by: Vinaya Damle <vinayada@microsoft.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: liuh-80 <58683130+liuh-80@users.noreply.github.com> Co-authored-by: Venkata Krishnan Anantha Raman <venkatakrishnansvpr@gmail.com> Co-authored-by: Shane Baden <naruto.shane@gmail.com> Co-authored-by: Shane Baden <shbaden@microsoft.com> Co-authored-by: Shany Pozin <shanyp@gmail.com> Co-authored-by: Shany Pozin <shanyp@microsoft.com> Co-authored-by: Henry Chen <henche@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.