DPDTimeout Multiple Radius for VPN Gateways (Network) #8707

henry416 · 2020-03-13T18:06:15Z

Adding DPDTimeout and Multiple Radius Servers for VPN Gateways
DPDTimeout is an integer field in connection resources.
Multiple Radius is a subobject containing radius sever address/score/secret in gateway resources.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

henry416 · 2020-03-13T18:07:32Z

#8697 Was told to create PR targeting this branch

azuresdkci · 2020-03-13T18:12:26Z

Can one of the admins verify this patch?

henry416 · 2020-03-18T20:11:15Z

@lirenhe / @zikalino Can you please review this PR?

anton-evseev · 2020-03-19T15:18:53Z

/azp run

azure-pipelines · 2020-03-19T15:19:14Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-03-19T15:20:34Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 97e464a with merge commit 571c418614c326dc304460a2a7509740a1798710. SDK Automation 13.0.17.20200326.3
️✔️sdk/network/mgmt-v2019_02_01 [Logs] [Preview SDK Changes]

⚠️sdk/network/mgmt-v2019_04_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
[mvn]   symbol:   method serviceName()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
[mvn]   symbol:   method serviceName()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
[mvn]   symbol:   method availableResourceGroupPrivateEndpointTypes()
[mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
[mvn] [ERROR]   symbol:   method serviceName()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
[mvn] [ERROR]   symbol:   method serviceName()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
[mvn] [ERROR]   symbol:   method availableResourceGroupPrivateEndpointTypes()
[mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

️✔️sdk/network/mgmt-v2019_06_01 [Logs] [Preview SDK Changes]
️✔️sdk/network/mgmt-v2019_07_01 [Logs] [Preview SDK Changes]
️✔️sdk/network/mgmt-v2019_08_01 [Logs] [Preview SDK Changes]

⚠️sdk/network/mgmt-v2019_09_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
[mvn]   symbol:   class ResourceNavigationLinkInner
[mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
[mvn]   symbol:   class ServiceAssociationLinkInner
[mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
[mvn] [ERROR]   symbol:   class ResourceNavigationLinkInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
[mvn] [ERROR]   symbol:   class ServiceAssociationLinkInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-03-19T15:20:34Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 97e464a with merge commit 571c418614c326dc304460a2a7509740a1798710. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-network [Logs] [Preview SDK Changes]

azure-arm-network-20.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
[npmPack] created ./dist/arm-network.js in 2.3s

openapi-sdkautomation · 2020-03-19T15:21:20Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 97e464a with merge commit 571c418614c326dc304460a2a7509740a1798710. SDK Automation 13.0.17.20200326.3
⚠️network/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-03-30 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-06-01 [Logs]
```
No file is changed.
```
️✔️network/mgmt/2016-09-01 [Logs] [Preview SDK Changes]
- network.mgmt.2016-09-01.zip
️✔️network/mgmt/2016-12-01 [Logs] [Preview SDK Changes]
- network.mgmt.2016-12-01.zip
⚠️network/mgmt/2017-03-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-09-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-01-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-04-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-10-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-12-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-02-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-07-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-09-01 [Logs]
```
No file is changed.
```
️✔️network/mgmt/2019-11-01 [Logs] [Preview SDK Changes]
- network.mgmt.2019-11-01.zip
⚠️preview/network/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-03-19T15:21:22Z

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 97e464a with merge commit 571c418614c326dc304460a2a7509740a1798710. SDK Automation 13.0.17.20200326.3
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-03-19T15:23:58Z

azure-sdk-for-net

🔄 inProgress [Logs] [Expand Details]

🔄 Generate from 97e464a with merge commit 571c418614c326dc304460a2a7509740a1798710. SDK Automation 13.0.17.20200326.3

henry416 · 2020-03-20T19:57:32Z

@number213 Can I get a review of this PR please?

henry416 · 2020-03-24T18:01:55Z

@MikhailTryakhov / @v-shhatt Please review this PR, thanks!

azure-pipelines · 2020-03-27T20:30:21Z

Azure Pipelines successfully started running 1 pipeline(s).

...esource-manager/Microsoft.Network/stable/2020-03-01/examples/VpnServerConfigurationList.json

pilor

1 previous comment still open and 1 minor new comment

azure-pipelines · 2020-03-27T21:23:31Z

Azure Pipelines successfully started running 1 pipeline(s).

henry416 · 2020-03-30T17:24:14Z

@pilor Comments addressed in latest commits

azure-pipelines · 2020-03-30T17:48:44Z

Azure Pipelines successfully started running 1 pipeline(s).

anton-evseev · 2020-04-01T16:41:24Z

@henry416 please resolve CI errors

azure-pipelines · 2020-04-01T17:52:38Z

Azure Pipelines successfully started running 1 pipeline(s).

henry416 · 2020-04-02T05:42:25Z

@number213 I have fixed the CI errors in examples jsons. The remaining checks don't display any actionable error that I can find. My local autorest validation doesn't show any error for the changes I made.

henry416 · 2020-04-03T06:49:26Z

@number213 could you please advise on what the CI errors are? I'm a bit stuck. The pipelines don't show a descriptive error, and autorest/linter validations don't show anything off.

anton-evseev · 2020-04-03T12:58:51Z

@henry416 PrettierCheck is throwing errors due to JSON files not being prettified correctly

prettier -c specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/VirtualNetworkGatewayList.json
Checking formatting...
specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/VirtualNetworkGatewayList.json
Code style issues found in the above file(s). Forgot to run Prettier?

prettier -c specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/VirtualNetworkGatewayUpdate.json
Checking formatting...
specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/VirtualNetworkGatewayUpdate.json
Code style issues found in the above file(s). Forgot to run Prettier?

prettier -c specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/VpnServerConfigurationGet.json
Checking formatting...
specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/VpnServerConfigurationGet.json
Code style issues found in the above file(s). Forgot to run Prettier?

prettier -c specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/VpnServerConfigurationPut.json
Checking formatting...
specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/examples/VpnServerConfigurationPut.json
Code style issues found in the above file(s). Forgot to run Prettier?

prettier -c specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/virtualNetworkGateway.json
Checking formatting...
specification/network/resource-manager/Microsoft.Network/stable/2020-03-01/virtualNetworkGateway.json
Code style issues found in the above file(s). Forgot to run Prettier?

azure-pipelines · 2020-04-03T18:25:15Z

Azure Pipelines successfully started running 1 pipeline(s).

henry416 · 2020-04-03T21:18:03Z

@number213 I have fixed the prettier output. Is there any way I can run the prettier check on files in local? I cannot find documentation in the repo on how to run it.
Looks like the remaining checks are about breaking changes, which should be okay since the new fields added are optional fields and do not alter existing scenarios.

henry416 · 2020-04-06T06:29:30Z

@number213 Ping for visibility

anton-evseev · 2020-04-06T11:43:55Z

@zikalino @akning-ms could you please merge this PR? Breaking change job can be ignored since this is a PR for Network's dev branch

@henry416 you can run prettier locally with npm run-script prettier-check

* Adds base for updating Microsoft.Network from version stable/2019-12-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix… (#8708) * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix documentation issues * Fix readme file Co-authored-by: Vinaya Damle <vinayada@microsoft.com> * Adding SecurityPartnerProvider Resource (#8721) * Adding securityPartnerProvider resource * Adding securityPartnerProvider resource : 2 * Added Definition for SecurityPartnerProviderListResult * Updated Readme.md with securityPartnerProvider * fixing zone.. * Fixing using Prettier * desc fix * Fixing enum conflict * RequiredPropertiesMissingInResourceModel Fix * capitalizing alphabets * renaming list/listall * Updated Tags to Caps Co-authored-by: Ishani Gupta <isgu@microsoft.com> * AzureFirewall User Tags Update (#8748) * AzureFirewall User Tags Update * Prettier Fixes Co-authored-by: Ishani Gupta <isgu@microsoft.com> * Add IpAllocation resource for Hypernet IP management. (#8701) * Add IpAllocation resource for Hypernet IP management. * Fix path issue. * Fix some issues by PR comments. * Fix document issue. * Fix reference with SubResource. * Fix IpAllocation tags name issue. * Add patch operation to IpAllocation resource. * Fix spell issue with pretter. * Introducing force policy association feature (#8738) * Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. (#8704) * Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint * Adding endzone keyword for build * Adding reference to 2020 private endpoint in readme for validation purposes * Misspelled reference to Get file fixed * Ran prettier fix on files * Removing reference in readme * Added some needed capitilization and punctuation, will be a pt2 to this commit * Added descriptions * Rerunning tests. * Updated definitions for customdnsconfig and record set * Rebuilding for pr * Changing word back to original sentence for PR. * Changed name in example file for create, as well as added List operation and fixed pr comments * resolved comments based on pr * Added changes based on PRcomments * Added integer tag to ttl * getting rid of type in private endpoint json * Changed type attribute in privateendpointdnszonegroupget * Added read only attribute to record set array Co-authored-by: Shane Baden <shbaden@microsoft.com> * Adding intrusionSystemMode property to firewallPolicy (#8885) * Add intrusionSystemMode to firewallPolicy * Change intrusionSystemMode to be either Enabled or Disabled * fix pretier * remove white space * remove the examples as this is a preview feature Co-authored-by: Shany Pozin <shanyp@microsoft.com> * DPDTimeout Multiple Radius for VPN Gateways (Network) (#8707) * DPDTimeout Multiple Radius changes * PR feedback, resource changes * PR feedback, example changes * examples fix * PR feedback * CI fix * prettier fix attempt Co-authored-by: Mikhail <mitryakh@microsoft.com> Co-authored-by: vinayada1 <vinayadamle@gmail.com> Co-authored-by: Vinaya Damle <vinayada@microsoft.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: liuh-80 <58683130+liuh-80@users.noreply.github.com> Co-authored-by: Venkata Krishnan Anantha Raman <venkatakrishnansvpr@gmail.com> Co-authored-by: Shane Baden <naruto.shane@gmail.com> Co-authored-by: Shane Baden <shbaden@microsoft.com> Co-authored-by: Shany Pozin <shanyp@gmail.com> Co-authored-by: Shany Pozin <shanyp@microsoft.com> Co-authored-by: Henry Chen <henche@microsoft.com>

* Adds base for updating Microsoft.Network from version stable/2019-12-01 to version 2020-03-01 * Updates readme * Updates API version in new specs and examples * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix… (Azure#8708) * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix documentation issues * Fix readme file Co-authored-by: Vinaya Damle <vinayada@microsoft.com> * Adding SecurityPartnerProvider Resource (Azure#8721) * Adding securityPartnerProvider resource * Adding securityPartnerProvider resource : 2 * Added Definition for SecurityPartnerProviderListResult * Updated Readme.md with securityPartnerProvider * fixing zone.. * Fixing using Prettier * desc fix * Fixing enum conflict * RequiredPropertiesMissingInResourceModel Fix * capitalizing alphabets * renaming list/listall * Updated Tags to Caps Co-authored-by: Ishani Gupta <isgu@microsoft.com> * AzureFirewall User Tags Update (Azure#8748) * AzureFirewall User Tags Update * Prettier Fixes Co-authored-by: Ishani Gupta <isgu@microsoft.com> * Add IpAllocation resource for Hypernet IP management. (Azure#8701) * Add IpAllocation resource for Hypernet IP management. * Fix path issue. * Fix some issues by PR comments. * Fix document issue. * Fix reference with SubResource. * Fix IpAllocation tags name issue. * Add patch operation to IpAllocation resource. * Fix spell issue with pretter. * Introducing force policy association feature (Azure#8738) * Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. (Azure#8704) * Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint * Adding endzone keyword for build * Adding reference to 2020 private endpoint in readme for validation purposes * Misspelled reference to Get file fixed * Ran prettier fix on files * Removing reference in readme * Added some needed capitilization and punctuation, will be a pt2 to this commit * Added descriptions * Rerunning tests. * Updated definitions for customdnsconfig and record set * Rebuilding for pr * Changing word back to original sentence for PR. * Changed name in example file for create, as well as added List operation and fixed pr comments * resolved comments based on pr * Added changes based on PRcomments * Added integer tag to ttl * getting rid of type in private endpoint json * Changed type attribute in privateendpointdnszonegroupget * Added read only attribute to record set array Co-authored-by: Shane Baden <shbaden@microsoft.com> * Adding intrusionSystemMode property to firewallPolicy (Azure#8885) * Add intrusionSystemMode to firewallPolicy * Change intrusionSystemMode to be either Enabled or Disabled * fix pretier * remove white space * remove the examples as this is a preview feature Co-authored-by: Shany Pozin <shanyp@microsoft.com> * DPDTimeout Multiple Radius for VPN Gateways (Network) (Azure#8707) * DPDTimeout Multiple Radius changes * PR feedback, resource changes * PR feedback, example changes * examples fix * PR feedback * CI fix * prettier fix attempt Co-authored-by: Mikhail <mitryakh@microsoft.com> Co-authored-by: vinayada1 <vinayadamle@gmail.com> Co-authored-by: Vinaya Damle <vinayada@microsoft.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: liuh-80 <58683130+liuh-80@users.noreply.github.com> Co-authored-by: Venkata Krishnan Anantha Raman <venkatakrishnansvpr@gmail.com> Co-authored-by: Shane Baden <naruto.shane@gmail.com> Co-authored-by: Shane Baden <shbaden@microsoft.com> Co-authored-by: Shany Pozin <shanyp@gmail.com> Co-authored-by: Shany Pozin <shanyp@microsoft.com> Co-authored-by: Henry Chen <henche@microsoft.com>

DPDTimeout Multiple Radius changes

486d034

henry416 requested review from MikhailTryakhov, anton-evseev and v-shhatt as code owners March 13, 2020 18:06

openapi-assignment-bot bot assigned zikalino Mar 13, 2020

henry416 mentioned this pull request Mar 13, 2020

DPDTimeout Multiple Radius Server for VPN Gateways #8697

Closed

5 tasks

henry416 changed the title ~~DPDTimeout Multiple Radius changes~~ DPDTimeout Multiple Radius for VPN Gateways (Network) Mar 13, 2020

anton-evseev added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 23, 2020

anton-evseev approved these changes Mar 23, 2020

View reviewed changes

pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 27, 2020

henry416 added 2 commits March 27, 2020 12:21

PR feedback, resource changes

79273c2

PR feedback, example changes

4656ba7

pilor reviewed Mar 27, 2020

View reviewed changes

...esource-manager/Microsoft.Network/stable/2020-03-01/examples/VpnServerConfigurationList.json Outdated Show resolved Hide resolved

pilor suggested changes Mar 27, 2020

View reviewed changes

examples fix

0b36643

PR feedback

89b41fd

pilor approved these changes Mar 30, 2020

View reviewed changes

CI fix

18c834c

prettier fix attempt

97e464a

anton-evseev mentioned this pull request Apr 7, 2020

Network March release #8968

Merged

5 tasks

akning-ms merged commit 249377f into Azure:network-march-release Apr 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DPDTimeout Multiple Radius for VPN Gateways (Network) #8707

DPDTimeout Multiple Radius for VPN Gateways (Network) #8707

henry416 commented Mar 13, 2020 •

edited

Loading

henry416 commented Mar 13, 2020

azuresdkci commented Mar 13, 2020

henry416 commented Mar 18, 2020

anton-evseev commented Mar 19, 2020

azure-pipelines bot commented Mar 19, 2020

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

henry416 commented Mar 20, 2020 •

edited

Loading

henry416 commented Mar 24, 2020

azure-pipelines bot commented Mar 27, 2020

pilor left a comment

azure-pipelines bot commented Mar 27, 2020

henry416 commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

anton-evseev commented Apr 1, 2020

azure-pipelines bot commented Apr 1, 2020

henry416 commented Apr 2, 2020

henry416 commented Apr 3, 2020

anton-evseev commented Apr 3, 2020

azure-pipelines bot commented Apr 3, 2020

henry416 commented Apr 3, 2020

henry416 commented Apr 6, 2020

anton-evseev commented Apr 6, 2020

DPDTimeout Multiple Radius for VPN Gateways (Network) #8707

DPDTimeout Multiple Radius for VPN Gateways (Network) #8707

Conversation

henry416 commented Mar 13, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

henry416 commented Mar 13, 2020

azuresdkci commented Mar 13, 2020

henry416 commented Mar 18, 2020

anton-evseev commented Mar 19, 2020

azure-pipelines bot commented Mar 19, 2020

openapi-sdkautomation bot commented Mar 19, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Mar 19, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Mar 19, 2020 • edited Loading

azure-sdk-for-go

openapi-sdkautomation bot commented Mar 19, 2020 • edited Loading

azure-sdk-for-python

openapi-sdkautomation bot commented Mar 19, 2020 • edited Loading

azure-sdk-for-net

henry416 commented Mar 20, 2020 • edited Loading

henry416 commented Mar 24, 2020

azure-pipelines bot commented Mar 27, 2020

pilor left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Mar 27, 2020

henry416 commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

anton-evseev commented Apr 1, 2020

azure-pipelines bot commented Apr 1, 2020

henry416 commented Apr 2, 2020

henry416 commented Apr 3, 2020

anton-evseev commented Apr 3, 2020

azure-pipelines bot commented Apr 3, 2020

henry416 commented Apr 3, 2020

henry416 commented Apr 6, 2020

anton-evseev commented Apr 6, 2020

henry416 commented Mar 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 19, 2020 •

edited

Loading

henry416 commented Mar 20, 2020 •

edited

Loading