ServiceBus - cross entity transaction feature #19863

hemanttanwar · 2021-03-15T21:28:31Z

Enable Cross Entity Transaction feature.

Use "same AMQP session" to create Coordinator, Senders and receivers who are part of same transaction across different entities.

The first sender/receiver created will be treated as sendVia on server side.

Design Choices and Explanation:

Since a Coordinator should exists before a Receiver/sender AMQP link is created. Thus When we are creating AMQPSession for "cross entity transaction", we will create "Coordinator link", So it is available before a Sender or Receiver is created.
To support this , creating an API AmqpConnection : createSession(String sessionName, boolean coordinatorRequired) : This will allow a Coordinator link to be created when a AMQP Session is setup for "cross Entity transaction"
Coordinator is a concept defined in AMQP Spec, So adding it in core-amqp library should be fine.

check-enforcer · 2021-03-15T21:45:02Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorSession.java

conniey · 2021-03-15T22:54:24Z

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/AmqpConnection.java

+     * @param coordinatorRequired If coordinator is required for this session.
+     * @return The AMQP session that was created.
+     *
+     * @see <a href="http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transactions-v1.0-os.html#section-coordination">Transactions-Coordinator</a>


Transaction Coordinator instead of the hyphen

This is a very specific API that is only used to support transactions. As an end user, I don't care about how transactions are coordinated or that there is even a coordinator.

Mono<AmqpSession> createTransaction(String name);

We are not exposing this API to SB user. But as far as core-amqp library is concerned, this concept Coordinator is part of AMQP spec. So the api createSession(sessoinName, boolean coordinatorRequired) is added.

The AMQP Session is created in core-amqp library and AMQP Coordinator needs to be setup as first link under this Session. So when we create AMQP Session, we setup this session with Coordinator link.

conniey · 2021-03-15T22:59:29Z

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorSession.java

@@ -80,10 +80,31 @@
     *     operations on the message broker.
     * @param retryOptions for the session operations.
     */
+    public ReactorSession(Session session, SessionHandler sessionHandler, String sessionName, ReactorProvider provider,


Do we need another ctor overload for this? I think this is overkill because only we use this. Can we bag this into CreateSessionOptions that only we use?

I thought about that, but did not wanted to introduce another class for it but it will help us in future to add more properties to it. So I will add CreateSessionOptions.

Looks the same still?

I added CreateSessionOptions based on first comment.

I meant to include parameters like MessageSerializer and AmqpRetryOptions so we don't need two new overloads.

More generally, does this transaction logic need to be in here? It is very specific to service bus and we already extend from the class in SB. Can you use a combination of the existing methods to perform this?

azure-core-amqp should be common logic between all the services.

eng/code-quality-reports/src/main/resources/revapi/revapi.json

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/AmqpConnection.java

...e/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/CreateSessionOptions.java

...azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/TransactionCoordinator.java

...ssaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusClientBuilder.java

…tead added as protected API

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/AmqpConnection.java

...e/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/CreateSessionOptions.java

conniey · 2021-03-19T02:13:40Z

...core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorConnection.java

+     *
+     * @see <a href="http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transactions-v1.0-os.html#section-coordination">Distributed Transactions</a>
+     */
+    protected Mono<AmqpSession> createSession(String sessionName, boolean distributedTransactionsSupport) {


You have createSessionOptions but this just uses a boolean

Removed this API need.

conniey · 2021-03-19T02:14:02Z

...core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorConnection.java

+     *
+     * @return A new instance of AMQP session.
+     */
+    protected AmqpSession createSession(String sessionName, Session session, SessionHandler handler,


Do we need another protected constructor?

conniey · 2021-03-19T02:14:30Z

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorSession.java

@@ -80,10 +80,31 @@
     *     operations on the message broker.
     * @param retryOptions for the session operations.
     */
+    public ReactorSession(Session session, SessionHandler sessionHandler, String sessionName, ReactorProvider provider,


Looks the same still?

sdk/servicebus/azure-messaging-servicebus/pom.xml

hemanttanwar · 2021-03-25T17:29:11Z

/azp run java - servicebus - ci

azure-pipelines · 2021-03-25T17:29:18Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

hemanttanwar · 2021-03-25T21:46:47Z

/check-enforcer reset

hemanttanwar · 2021-03-25T21:58:31Z

/check-enforcer override

…- into feature branch - preparation for April release. (#20356) * ServiceBus - cross entity transaction feature (#19863) New Feature: Cross entity transaction API

* Service bus adding max auto lock renew duration in processor client (#20317) * Added API in builder for "adding max auto lock renew duration in processor client" * Service Bus - Merging previously approved -cross transaction feature - into feature branch - preparation for April release. (#20356) * ServiceBus - cross entity transaction feature (#19863) New Feature: Cross entity transaction API * Service bus : Amqp Types SEQUENCE and VALUE (#20285) * Adding feature AMQP SEQUENCE/VALUE data type implementation * Merge master into branch * beta version change * getting ready to release beta * Updating beta version for event hubs * Fixing unit test case * Removing unwanted import * Fixing test subscriber name (#20666) Co-authored-by: hemanttanwar <hetanwar@users.noreply.github.com> * SB april beta release updates (#20672) * SB april beta release updates * Increment package version after release of com.azure azure-messaging-servicebus (#20690) * Use multiple subscribers for `maxConcurrentCalls` in ServiceBusProcessorClient (#21085) * Merge feature branch into release branch * Updated core-amqp version to release as beta

…22426) * Service bus adding max auto lock renew duration in processor client (#20317) * Added API in builder for "adding max auto lock renew duration in processor client" * Service Bus - Merging previously approved -cross transaction feature - into feature branch - preparation for April release. (#20356) * ServiceBus - cross entity transaction feature (#19863) New Feature: Cross entity transaction API * Service bus : Amqp Types SEQUENCE and VALUE (#20285) * Adding feature AMQP SEQUENCE/VALUE data type implementation * added subQueue API

Release microsoft.sql 2021-11-01 Stable API version (Azure#19863) * Adds base for updating Microsoft.Sql from version preview/2021-11-01-preview to version 2021-11-01 * Updates readme * Updates API version in new specs and examples * add the latest generated stable 2021-11-01 * update readme.md with latest stable api list * update swaggers * update swagger format * address lintdiff pipeline * address lint error * add "x-ms-identifiers": []

Initial draft implementation

7103672

ghost added Azure.Core azure-core Service Bus labels Mar 15, 2021

Initial draft implementation

bde87d9

Initial draft implementation

2c559d5

hemanttanwar commented Mar 15, 2021

View reviewed changes

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorSession.java Outdated Show resolved Hide resolved

hemanttanwar requested review from conniey and srnagar March 15, 2021 22:00

Initial draft implementation

6f2ce44

conniey reviewed Mar 15, 2021

View reviewed changes

hemanttanwar marked this pull request as ready for review March 16, 2021 05:16

hemanttanwar requested review from alzimmermsft, anuchandy, jianghaolu, YijunXieMS and yvgopal as code owners March 16, 2021 05:16

hemanttanwar requested a review from conniey March 16, 2021 05:16

Incorporated Review comments

d379a53

hemanttanwar requested review from JonathanGiles and mssfang as code owners March 18, 2021 22:26

Incorporated Review comments

cb7a5aa

srnagar reviewed Mar 18, 2021

View reviewed changes

hemanttanwar added 2 commits March 18, 2021 17:07

Incorporated review comments

7e800b8

Incorporated review comments and removed adding API in interface, ins…

585afe5

…tead added as protected API

conniey reviewed Mar 19, 2021

View reviewed changes

Reorganized API to avoid revapi changes

5b7209c

hemanttanwar requested review from conniey and srnagar March 19, 2021 08:08

Incorporated more review comments

9b07714

hemanttanwar requested review from backwind1233, chenrujun, ChenTanyi, jialindai, saragluna, stliu, weidongxu-microsoft, yiliuTo and yungezz as code owners March 25, 2021 07:32

conniey reviewed Mar 25, 2021

View reviewed changes

sdk/servicebus/azure-messaging-servicebus/pom.xml Show resolved Hide resolved

conniey approved these changes Mar 25, 2021

View reviewed changes

hemanttanwar added 3 commits March 25, 2021 09:59

updated readme, changelog and version for beta release.

e556088

updated readme, changelog and version for beta release.

1135e2f

Updated version script tags

4b4e14c

hemanttanwar added 2 commits March 25, 2021 11:07

fix spotbug error

f189f89

Fixing spot bug error

8a55273

hemanttanwar merged commit 65105c1 into hemant/feature/sb-cross-entity-transaction-19137-off-V7-1-0 Mar 25, 2021

hemanttanwar deleted the hemant/feature/1-sb-cross-entity-transaction-19137-off-V7-1-0 branch March 25, 2021 22:02

hemanttanwar mentioned this pull request Mar 25, 2021

[Service Bus] [FEATURE Cross entity transaction] Support cross entity transaction feature #19137

Closed

hemanttanwar mentioned this pull request Apr 3, 2021

Service Bus - Merging previously approved -cross transaction feature - into feature branch - preparation for April release. #20356

Merged

richardpark-msft mentioned this pull request Oct 27, 2023

First pass at adding in transactions Azure/go-amqp#312

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ServiceBus - cross entity transaction feature #19863

ServiceBus - cross entity transaction feature #19863

hemanttanwar commented Mar 15, 2021 •

edited

Loading

check-enforcer bot commented Mar 15, 2021

conniey Mar 15, 2021

conniey Mar 15, 2021

hemanttanwar Mar 16, 2021 •

edited

Loading

conniey Mar 15, 2021

hemanttanwar Mar 16, 2021 •

edited

Loading

conniey Mar 19, 2021

hemanttanwar Mar 19, 2021

conniey Mar 19, 2021

conniey Mar 19, 2021 •

edited

Loading

conniey Mar 19, 2021

hemanttanwar Mar 19, 2021

conniey Mar 19, 2021

conniey Mar 19, 2021

hemanttanwar commented Mar 25, 2021

azure-pipelines bot commented Mar 25, 2021

hemanttanwar commented Mar 25, 2021

hemanttanwar commented Mar 25, 2021

ServiceBus - cross entity transaction feature #19863

ServiceBus - cross entity transaction feature #19863

Conversation

hemanttanwar commented Mar 15, 2021 • edited Loading

check-enforcer bot commented Mar 15, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hemanttanwar Mar 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hemanttanwar Mar 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conniey Mar 19, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hemanttanwar commented Mar 25, 2021

azure-pipelines bot commented Mar 25, 2021

hemanttanwar commented Mar 25, 2021

hemanttanwar commented Mar 25, 2021

hemanttanwar commented Mar 15, 2021 •

edited

Loading

hemanttanwar Mar 16, 2021 •

edited

Loading

hemanttanwar Mar 16, 2021 •

edited

Loading

conniey Mar 19, 2021 •

edited

Loading