Service bus adding max auto lock renew duration in processor client #20317

hemanttanwar · 2021-04-01T07:15:07Z

We missed this API earlier in processor client, so adding this.

maxAutoLockRenewDuration()
Also adding live test for Processor client to send and receive message.
Links : [FEATURE REQ] Provide the ability to configure maxAutoRenewDuration for ServiceBusProcessorClient #19929
PS: April beta release will be from branch "feature/servicebus-support-amqp-data-types-17614" : This I am merging this feature in this branch.

srnagar · 2021-04-01T19:05:03Z

...aging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusProcessorClient.java

+    ReceiverOptions getReceiverOptions() {
+        ReceiverOptions receiverOptions = null;
+        final ServiceBusReceiverAsyncClient client = asyncClient.get();
+        if (client != null) {
+            receiverOptions = client.getReceiverOptions();
+        }
+        return receiverOptions;
+    }


Don't think this method is required. This is added just to test if the value is set. Instead, we should test that the maxLockRenewDuration is honored if it is set in the builder.

...ssaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusClientBuilder.java

srnagar · 2021-04-02T05:59:56Z

...s/src/test/java/com/azure/messaging/servicebus/ServiceBusProcessorClientIntegrationTest.java

+        }
+
+        // Assert & Act
+        System.out.println("Starting the processor");


Remove all System.out.print* statements.

Some output help to debug if any issue.
I have changed them to use logger.

srnagar · 2021-04-02T06:06:01Z

...s/src/test/java/com/azure/messaging/servicebus/ServiceBusProcessorClientIntegrationTest.java

+        ServiceBusReceivedMessage message = context.getMessage();
+        if (message.getMessageId().equals(expectedMessageId)) {
+            System.out.printf("Processing message. Session: %s, Sequence #: %s. Contents: %s%n", message.getMessageId(),
+                message.getSequenceNumber(), message.getBody());
+            countDownLatch.countDown();
+        } else {
+            System.out.printf("Received message, message id did not match. Session: %s, Sequence #: %s. Contents: %s%n", message.getMessageId(),
+                message.getSequenceNumber(), message.getBody());
+        }


How does this ensure that the lock is renewed until maxAutoLockRenewalDuration and stops after? This will count down the latch immediately after the message is received resulting in the test passing without verifying the lock duration.

Before this change, the default message lock is set to 5 minute. And user was not able to overwrite it.
Now user set it to 15 seconds.

The message has to be received twice, first time we lock the message and we do not complete it, the message goes back to the queue and received again. The count down has to count twice for same message id.
This ensure that we honor, user's maxAutoLockRenewalDuration instead of 5 minutes.

The fact that lock is released and message come back, that shows that the lock renew operation stops .

...ing-servicebus/src/main/java/com/azure/messaging/servicebus/implementation/MessageUtils.java

srnagar · 2021-04-02T22:32:18Z

...s/src/test/java/com/azure/messaging/servicebus/ServiceBusProcessorClientIntegrationTest.java

+        MessagingEntityType entityType, int entityIndex, boolean sharedConnection, AmqpRetryOptions amqpRetryOptions) {
+
+        ServiceBusClientBuilder builder = getBuilder(useCredentials, sharedConnection);
+        builder.retryOptions(amqpRetryOptions);


Why do we need to override the default retry options?

yes, we need to set this test case. The default value is 1 minute. For this test setting it to 30 seconds.

srnagar · 2021-04-02T22:35:05Z

...s/src/test/java/com/azure/messaging/servicebus/ServiceBusProcessorClientIntegrationTest.java

+    void receiveMessage(MessagingEntityType entityType, boolean isSessionEnabled) throws InterruptedException {
+        // Arrange
+        // The message is locked for this duration at a time.
+        final int lockTimeoutDurationSeconds = 15;


This is set as the tryTimeoutDuration. Why do we need to configure this?

'tryTimeoutDuration' is used as 'inactivity time' : means if there is no activity on link (no message arriving in this time), It will close the link. The is defaulted to 60 seconds for my test, so I am setting it to 30 seconds.

https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusClientBuilder.java#L104

srnagar · 2021-04-03T06:25:26Z

...ure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/FluxAutoLockRenew.java

+                if (isAutoCompleteEnabled) {
+                    lockCleanup.accept(messageContext);
+                }


Why do we need to check isAutoCompleteEnabled to clean up the auto-renew lock?

isAutoCompleteEnabled : If user has disabled autoComplete, we need lock renew to continue , we do not want to clean up in this case. When lock renew expire, it will be cleaned at that time.

* Service bus adding max auto lock renew duration in processor client (#20317) * Added API in builder for "adding max auto lock renew duration in processor client" * Service Bus - Merging previously approved -cross transaction feature - into feature branch - preparation for April release. (#20356) * ServiceBus - cross entity transaction feature (#19863) New Feature: Cross entity transaction API * Service bus : Amqp Types SEQUENCE and VALUE (#20285) * Adding feature AMQP SEQUENCE/VALUE data type implementation * Merge master into branch * beta version change * getting ready to release beta * Updating beta version for event hubs * Fixing unit test case * Removing unwanted import * Fixing test subscriber name (#20666) Co-authored-by: hemanttanwar <hetanwar@users.noreply.github.com> * SB april beta release updates (#20672) * SB april beta release updates * Increment package version after release of com.azure azure-messaging-servicebus (#20690) * Use multiple subscribers for `maxConcurrentCalls` in ServiceBusProcessorClient (#21085) * Merge feature branch into release branch * Updated core-amqp version to release as beta

…22426) * Service bus adding max auto lock renew duration in processor client (#20317) * Added API in builder for "adding max auto lock renew duration in processor client" * Service Bus - Merging previously approved -cross transaction feature - into feature branch - preparation for April release. (#20356) * ServiceBus - cross entity transaction feature (#19863) New Feature: Cross entity transaction API * Service bus : Amqp Types SEQUENCE and VALUE (#20285) * Adding feature AMQP SEQUENCE/VALUE data type implementation * added subQueue API

hemanttanwar added 2 commits March 31, 2021 11:55

Added API in builder

3048c87

Initial draft

9aa2a4f

hemanttanwar requested review from conniey, YijunXieMS and yvgopal as code owners April 1, 2021 07:15

ghost added the Service Bus label Apr 1, 2021

hemanttanwar added 2 commits April 1, 2021 00:22

Initial draft

73d0e76

Rename the queue name

13753d8

hemanttanwar requested a review from srnagar April 1, 2021 07:31

Fix check style errors

edc8780

srnagar reviewed Apr 1, 2021

View reviewed changes

Updated the test based on comments

d660415

srnagar reviewed Apr 2, 2021

View reviewed changes

hemanttanwar added 2 commits April 1, 2021 23:07

Removed unwanted import

88aa62c

Updated the test based on comments

eb71662

hemanttanwar requested a review from srnagar April 2, 2021 06:22

Fixed lock renew when auto complete is disabled

069b1bf

srnagar reviewed Apr 2, 2021

View reviewed changes

Removing unwanted changes

7f38470

srnagar approved these changes Apr 3, 2021

View reviewed changes

hemanttanwar merged commit 754aa91 into Azure:feature/servicebus-support-amqp-data-types-17614 Apr 5, 2021

hemanttanwar deleted the sb-processorclient-adding-maxAutoLockRenewDuration-api-19929-april-release branch April 5, 2021 17:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Service bus adding max auto lock renew duration in processor client #20317

Service bus adding max auto lock renew duration in processor client #20317

hemanttanwar commented Apr 1, 2021 •

edited

Loading

srnagar Apr 1, 2021

srnagar Apr 2, 2021

hemanttanwar Apr 2, 2021

srnagar Apr 2, 2021

hemanttanwar Apr 2, 2021 •

edited

Loading

srnagar Apr 2, 2021

hemanttanwar Apr 2, 2021 •

edited

Loading

srnagar Apr 2, 2021

hemanttanwar Apr 2, 2021

srnagar Apr 3, 2021

hemanttanwar Apr 5, 2021

Service bus adding max auto lock renew duration in processor client #20317

Service bus adding max auto lock renew duration in processor client #20317

Conversation

hemanttanwar commented Apr 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hemanttanwar Apr 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hemanttanwar Apr 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hemanttanwar commented Apr 1, 2021 •

edited

Loading

hemanttanwar Apr 2, 2021 •

edited

Loading

hemanttanwar Apr 2, 2021 •

edited

Loading