Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service bus : Amqp Types SEQUENCE and VALUE #20285

Merged
merged 12 commits into from
Apr 12, 2021
Merged

Service bus : Amqp Types SEQUENCE and VALUE #20285

merged 12 commits into from
Apr 12, 2021

Conversation

hemanttanwar
Copy link
Contributor

@hemanttanwar hemanttanwar commented Mar 31, 2021 •
edited
Loading

@ghost ghost added Azure.Core azure-core Event Hubs Service Bus azure-spring All azure-spring related issues labels Mar 31, 2021
stliu
stliu reviewed Mar 31, 2021
View reviewed changes
...amqp/src/samples/java/com/azure/core/amqp/models/AmqpAnnotatedMessageJavaDocCodeSamples.java
case VALUE:
throw new RuntimeException("Body type not supported yet.");
amqpValue = amqpAnnotatedMessage.getBody().getValue();
System.out.println(amqpValue);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine because we are outputting the value in same , so user can see it.

srnagar
srnagar reviewed Mar 31, 2021
View reviewed changes
...ing-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusMessageSerializer.java Outdated
} else if (body instanceof AmqpValue) {
amqpMessageBody = AmqpMessageBody.fromValue(((AmqpValue)body).getValue());
} else if (body instanceof AmqpSequence) {
List messageData = ((AmqpSequence) body).getValue();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the generic notation when using List.

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/models/AmqpMessageBody.java Outdated Show resolved Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/models/AmqpMessageBody.java Outdated Show resolved Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/models/AmqpMessageBody.java Outdated Show resolved Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/models/AmqpMessageBody.java Outdated Show resolved Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/models/AmqpMessageBody.java Outdated Show resolved Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/models/AmqpMessageBody.java Outdated Show resolved Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/models/AmqpMessageBody.java Outdated Show resolved Hide resolved
...ure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusMessage.java Outdated Show resolved Hide resolved
...ing-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusMessageSerializer.java Outdated Show resolved Hide resolved
@hemanttanwar hemanttanwar mentioned this pull request Apr 5, 2021
Closed
@hemanttanwar hemanttanwar merged commit a3ec7ae into Azure:feature/servicebus-support-amqp-data-types-17614 Apr 12, 2021
@hemanttanwar hemanttanwar deleted the servicebus-support-amqp-data-types-17614-part1 branch April 12, 2021 16:23
hemanttanwar added a commit that referenced this pull request May 13, 2021
@hemanttanwar
Core-amqp may 2021 beta release for Servicebus beta (#21393)
6bde71d 
* Service bus adding max auto lock renew duration in processor client (#20317)

* Added API in builder  for "adding max auto lock renew duration in processor client"

* Service Bus - Merging previously approved -cross transaction feature - into feature branch - preparation for April release. (#20356)

* ServiceBus - cross entity transaction  feature  (#19863)

New Feature: Cross entity transaction API

* Service bus : Amqp Types SEQUENCE and VALUE (#20285)

* Adding feature AMQP SEQUENCE/VALUE data type implementation

* Merge master into branch

* beta version change

* getting ready to release beta

* Updating beta version for event hubs

* Fixing unit test case

* Removing unwanted import

* Fixing test subscriber name (#20666)

Co-authored-by: hemanttanwar <hetanwar@users.noreply.github.com>

* SB april beta release updates (#20672)

* SB april beta release updates

* Increment package version after release of com.azure azure-messaging-servicebus (#20690)

* Use multiple subscribers for `maxConcurrentCalls` in ServiceBusProcessorClient (#21085)

* Merge feature branch into release branch

* Updated core-amqp version to release as beta
hemanttanwar added a commit that referenced this pull request Jun 23, 2021
@hemanttanwar
Feature/servicebus newapi crosstxn datatype from june master branch (#…
064db64 
…22426)

* Service bus adding max auto lock renew duration in processor client (#20317)

* Added API in builder  for "adding max auto lock renew duration in processor client"

* Service Bus - Merging previously approved -cross transaction feature - into feature branch - preparation for April release. (#20356)

* ServiceBus - cross entity transaction  feature  (#19863)

New Feature: Cross entity transaction API

* Service bus : Amqp Types SEQUENCE and VALUE (#20285)

* Adding feature AMQP SEQUENCE/VALUE data type implementation

* added subQueue API
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 24, 2022
@ShiqianTao
CodeGen from PR 20285 in Azure/azure-rest-api-specs
6c6e1eb 
Review request for Microsoft.ContainerService to add version 2022-07-01 (Azure#20285)

* Adds base for updating Microsoft.ContainerService from version stable/2022-06-01 to version 2022-07-01

* Updates readme

* Updates API version in new specs and examples

* update readmes (Azure#19871)

* Add example of Azure KeyVault Secrets Provider Addon for 2022-07-01 (Azure#19875)

* add example of kv secret provider addon

* fix lint

* AKS OSSKU supports Windows options (Azure#19976)

* OSSKU supports Windows options

* Improve description

* add default for availableAgentPoolVersions (Azure#19901)

* sync PR Azure#19592 ARM ID annotations for ContainerService

* separate examples for list cluster credentials operations

Co-authored-by: Shiqian Tao <62196586+ShiqianTao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar left review comments

@stliu stliu stliu left review comments

@conniey conniey conniey approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@backwind1233 backwind1233 Awaiting requested review from backwind1233 backwind1233 is a code owner

@chenrujun chenrujun Awaiting requested review from chenrujun

@danieljurek danieljurek Awaiting requested review from danieljurek danieljurek is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@jialindai jialindai Awaiting requested review from jialindai

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@samvaity samvaity Awaiting requested review from samvaity samvaity is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@YijunXieMS YijunXieMS Awaiting requested review from YijunXieMS

@yiliuTo yiliuTo Awaiting requested review from yiliuTo yiliuTo is a code owner

@yvgopal yvgopal Awaiting requested review from yvgopal yvgopal is a code owner

@ankitarorabit ankitarorabit Awaiting requested review from ankitarorabit

@ChenTanyi ChenTanyi Awaiting requested review from ChenTanyi

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel

@JianpingChen JianpingChen Awaiting requested review from JianpingChen

@joshfree joshfree Awaiting requested review from joshfree

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@milismsft milismsft Awaiting requested review from milismsft

@minnieliu minnieliu Awaiting requested review from minnieliu

@moderakh moderakh Awaiting requested review from moderakh

@mrm9084 mrm9084 Awaiting requested review from mrm9084

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

@vcolin7 vcolin7 Awaiting requested review from vcolin7

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft

@weshaggard weshaggard Awaiting requested review from weshaggard

@xseeseesee xseeseesee Awaiting requested review from xseeseesee

@xinlian12 xinlian12 Awaiting requested review from xinlian12

@yungezz yungezz Awaiting requested review from yungezz

Assignees
No one assigned
Labels
Azure.Core azure-core azure-spring All azure-spring related issues Event Hubs Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hemanttanwar @stliu @conniey @srnagar