Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated off latest version of blob swagger #21644

Merged
merged 3 commits into from
May 19, 2021
Merged

Generated off latest version of blob swagger #21644

merged 3 commits into from
May 19, 2021

Conversation

gapra-msft
Copy link
Member

No description provided.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label May 18, 2021
@gapra-msft gapra-msft marked this pull request as draft May 18, 2021 23:09
alzimmermsft
alzimmermsft approved these changes May 19, 2021
View reviewed changes
...ain/java/com/azure/storage/blob/implementation/models/BlobsSetImmutabilityPolicyHeaders.java
import java.time.OffsetDateTime;

/** The BlobsSetImmutabilityPolicyHeaders model. */
@JacksonXmlRootElement(localName = "null")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srnagar, @jianghaolu do we know if this will cause any problems in serialization/deserialization? Is this going to expect this class to be wrapped in null:

<null>
  
</null>

.../java/com/azure/storage/blob/implementation/models/BlobsDeleteImmutabilityPolicyHeaders.java
import java.time.OffsetDateTime;

/** The BlobsDeleteImmutabilityPolicyHeaders model. */
@JacksonXmlRootElement(localName = "null")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here @srnagar, @jianghaolu

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen other model types in the storage libraries with null set here and it hasnt caused any problems so far. This is a class to deserialize headers so it should be fine right?

@gapra-msft gapra-msft marked this pull request as ready for review May 19, 2021 17:05
@gapra-msft
Copy link
Member Author

Merging this for now, if @srnagar or @jianghaolu respond, I will follow up with another PR

@gapra-msft gapra-msft merged commit 8b49136 into Azure:feature/storage/stg78 May 19, 2021
kasobol-msft added a commit that referenced this pull request Jun 24, 2021
@kasobol-msft @gapra-msft @jaschrep-msft
Merge stg 78 (#22498)
2fe662b 
* Set up STG78 branch (#21634)

* Generated off latest version of blob swagger (#21644)

* Reenabled quick query parquet support (#21785)

* Implemented Immutable Storage with Versioning (#21718)

* File listing v2 (#21720)

* swagger generation and hookup

regenerated files swagger for listing
hooked up generated and handwritten models
expanded client API to support new models

* testing and fixes

expanded test parameters for file listing.
swagger transform added.

* rerecorded file listing test

* more testing

also fixed a method name casing

* docstrings and samples

* checkstyle

* reverted primative boolean extended info arg

REST api accepts true or an absence of value. Alligning with .NET for
now on Boolean vs boolean.

* checkpoint

* pr feedback

* misused variable fix

* fixed test

* send nothing, not false: include-extended-info

other minor fixes
rerecorded tests

* import cleanup

* swagger regeneration and test fixes

* API comments

extendedInfo boolean => Boolean
renamed options class

* reidentified samples for options class name change

Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com>

* Fix test.

* Implemented list deleted root blob with versions (#21996)

* Addressed comments for immutable storage with versioning (#22388)

* Develop on main, part 1 (#22451)

* move back service version.

* pin CI.

* fix ci.

* fix ci ?

* fix live tests ?

* use latest service version to filter if not specified in variable.

* use latest service version to filter if not specified in variable.

* does this work ??

* missing stuff.

* move that piece to parent as well.

* rollback yml changes in favor of pom.xml

* fix build ?

* how about this ?

* more ?

* not this.

* rollback some.

* does this work ??

Co-authored-by: Gauri Prasad <51212198+gapra-msft@users.noreply.github.com>
Co-authored-by: gapra <gapra@microsoft.com>
Co-authored-by: James <41338290+jaschrep-msft@users.noreply.github.com>
Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com>
jaschrep-msft added a commit that referenced this pull request Jun 25, 2021
@jaschrep-msft @gapra-msft @kasobol-msft
Feature/oauth copyfromurl (#22086)
73221a9 
* Set up STG78 branch (#21634)

* Generated off latest version of blob swagger (#21644)

* swagger generation and public API overloads

* blob clients obey new generation

* minor changes to bearer token logic

* TEST WORKING

* extra testing

* ported oauthcopy source to blobs

* options API changes and docstrings

* fixed constructor issues

* fix missed source auth misses

* script tags on pom

* removes arg checks in option model constructors

rerecorded tests

* pom fix

* fix misnamed page blob tests

* Test fixes

adds missing recording.
extra playback logic for oauth tokens that should fix a CI-specific
issue.

* fixed pom script comment

* downgrade some depenency verions

* rerecord sas tests

* snippets and checkstyle

* rerecorded tests

fixed recording infra for file share tests

* test fixes

* rerecorded versioning tests

* HttpAuthorization added to core-experimental

azure-storage-blob and azure-storage-file-share now depend on
core-experimental for new class and updated their APIs to use the new
class.

* refactored options type names

* Reenabled quick query parquet support (#21785)

* reidentified samples for options class name change

* Implemented Immutable Storage with Versioning (#21718)

* File listing v2 (#21720)

* swagger generation and hookup

regenerated files swagger for listing
hooked up generated and handwritten models
expanded client API to support new models

* testing and fixes

expanded test parameters for file listing.
swagger transform added.

* rerecorded file listing test

* more testing

also fixed a method name casing

* docstrings and samples

* checkstyle

* reverted primative boolean extended info arg

REST api accepts true or an absence of value. Alligning with .NET for
now on Boolean vs boolean.

* checkpoint

* pr feedback

* misused variable fix

* fixed test

* send nothing, not false: include-extended-info

other minor fixes
rerecorded tests

* import cleanup

* swagger regeneration and test fixes

* API comments

extendedInfo boolean => Boolean
renamed options class

* reidentified samples for options class name change

Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com>

* Fix test.

* remove HttpAuthorization in prep for merge

added in separate PR. removing to be ready for that offical addition.

* fix build from merge

* fix pom versioning CI issues

* snippet line length

* fix merge error with immutable versioning

* PR feedback

* Minor cleanup

* generator cleanup and regeneration

* Keep files-shares tests dependent on latest blob

* test refactor/rerecord

* deleted old tests that were copied instead of moved

* min service version reformat

* import cleanup

* post-merge.

* getOauthToken refactor

* reformatting

Co-authored-by: Gauri Prasad <51212198+gapra-msft@users.noreply.github.com>
Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com>
Co-authored-by: gapra <gapra@microsoft.com>
Co-authored-by: Kamil Sobol <kasobol@microsoft.com>
Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Feb 17, 2023
CodeGen from PR 21643 in Azure/azure-rest-api-specs
c58514f 
[Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2023-01-31 (Azure#21643)

* Adds base for updating Microsoft.DigitalTwins from version stable/2022-10-31 to version 2023-01-31

* Updates readme

* Updates API version in new specs and examples

* Added lifecycle event tables and deletion option (Azure#21644)

* Added lifecycle event tables and deletion option

* Add examples, add deletion option

* Add default value for recordPropertyAndItemRemovals

* Convert boolean into enum (Azure#22083)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaschrep-msft jaschrep-msft jaschrep-msft approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

@rickle-msft rickle-msft Awaiting requested review from rickle-msft

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gapra-msft @jaschrep-msft @alzimmermsft