Reenabled quick query parquet support #21785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
alzimmermsft
approved these changes
Jun 4, 2021
| @@ -6,5 +6,4 @@ | |||
| /** | |||
| * Defines the input parquet serialization for a blob quick query request. | |||
| */ | |||
| // TODO (gapra): public when parquet is released | |||
| class BlobQueryParquetSerialization implements BlobQuerySerialization { } | |||
| public class BlobQueryParquetSerialization implements BlobQuerySerialization { } | |||
| @@ -323,13 +323,12 @@ private static JsonTextConfiguration transformJson(BlobQueryJsonSerialization js | |||
| * @param parquetSerialization {@link BlobQueryParquetSerialization} | |||
| * @return {@link JsonTextConfiguration} | |||
| */ | |||
| // TODO (gapra): uncomment when parquet is released | |||
| /*private static Object transformParquet(BlobQueryParquetSerialization parquetSerialization) { | |||
| private static Object transformParquet(BlobQueryParquetSerialization parquetSerialization) { | |||
There was a problem hiding this comment.
Mind adding more context to this method on why it just returns a new Object().
| } else { | ||
| throw new IllegalArgumentException( | ||
| String.format("'serialization' must be one of %s, %s, or %s", | ||
| String.format("'serialization' must be one of %s, %s, %s, or %s", |
There was a problem hiding this comment.
Do we want to make this error message into a constant instead of formatting every time it is thrown
| @@ -6,5 +6,4 @@ | |||
| /** | |||
| * Defines the input parquet serialization for a file quick query request. | |||
| */ | |||
| // TODO (gapra): public when parquet is released | |||
| class FileQueryParquetSerialization implements FileQuerySerialization { } | |||
| public class FileQueryParquetSerialization implements FileQuerySerialization { } | |||
jaschrep-msft
approved these changes
Jun 15, 2021
kasobol-msft
added a commit
that referenced
this pull request
Jun 24, 2021
* Set up STG78 branch (#21634) * Generated off latest version of blob swagger (#21644) * Reenabled quick query parquet support (#21785) * Implemented Immutable Storage with Versioning (#21718) * File listing v2 (#21720) * swagger generation and hookup regenerated files swagger for listing hooked up generated and handwritten models expanded client API to support new models * testing and fixes expanded test parameters for file listing. swagger transform added. * rerecorded file listing test * more testing also fixed a method name casing * docstrings and samples * checkstyle * reverted primative boolean extended info arg REST api accepts true or an absence of value. Alligning with .NET for now on Boolean vs boolean. * checkpoint * pr feedback * misused variable fix * fixed test * send nothing, not false: include-extended-info other minor fixes rerecorded tests * import cleanup * swagger regeneration and test fixes * API comments extendedInfo boolean => Boolean renamed options class * reidentified samples for options class name change Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com> * Fix test. * Implemented list deleted root blob with versions (#21996) * Addressed comments for immutable storage with versioning (#22388) * Develop on main, part 1 (#22451) * move back service version. * pin CI. * fix ci. * fix ci ? * fix live tests ? * use latest service version to filter if not specified in variable. * use latest service version to filter if not specified in variable. * does this work ?? * missing stuff. * move that piece to parent as well. * rollback yml changes in favor of pom.xml * fix build ? * how about this ? * more ? * not this. * rollback some. * does this work ?? Co-authored-by: Gauri Prasad <51212198+gapra-msft@users.noreply.github.com> Co-authored-by: gapra <gapra@microsoft.com> Co-authored-by: James <41338290+jaschrep-msft@users.noreply.github.com> Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com>
jaschrep-msft
added a commit
that referenced
this pull request
Jun 25, 2021
* Set up STG78 branch (#21634) * Generated off latest version of blob swagger (#21644) * swagger generation and public API overloads * blob clients obey new generation * minor changes to bearer token logic * TEST WORKING * extra testing * ported oauthcopy source to blobs * options API changes and docstrings * fixed constructor issues * fix missed source auth misses * script tags on pom * removes arg checks in option model constructors rerecorded tests * pom fix * fix misnamed page blob tests * Test fixes adds missing recording. extra playback logic for oauth tokens that should fix a CI-specific issue. * fixed pom script comment * downgrade some depenency verions * rerecord sas tests * snippets and checkstyle * rerecorded tests fixed recording infra for file share tests * test fixes * rerecorded versioning tests * HttpAuthorization added to core-experimental azure-storage-blob and azure-storage-file-share now depend on core-experimental for new class and updated their APIs to use the new class. * refactored options type names * Reenabled quick query parquet support (#21785) * reidentified samples for options class name change * Implemented Immutable Storage with Versioning (#21718) * File listing v2 (#21720) * swagger generation and hookup regenerated files swagger for listing hooked up generated and handwritten models expanded client API to support new models * testing and fixes expanded test parameters for file listing. swagger transform added. * rerecorded file listing test * more testing also fixed a method name casing * docstrings and samples * checkstyle * reverted primative boolean extended info arg REST api accepts true or an absence of value. Alligning with .NET for now on Boolean vs boolean. * checkpoint * pr feedback * misused variable fix * fixed test * send nothing, not false: include-extended-info other minor fixes rerecorded tests * import cleanup * swagger regeneration and test fixes * API comments extendedInfo boolean => Boolean renamed options class * reidentified samples for options class name change Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com> * Fix test. * remove HttpAuthorization in prep for merge added in separate PR. removing to be ready for that offical addition. * fix build from merge * fix pom versioning CI issues * snippet line length * fix merge error with immutable versioning * PR feedback * Minor cleanup * generator cleanup and regeneration * Keep files-shares tests dependent on latest blob * test refactor/rerecord * deleted old tests that were copied instead of moved * min service version reformat * import cleanup * post-merge. * getOauthToken refactor * reformatting Co-authored-by: Gauri Prasad <51212198+gapra-msft@users.noreply.github.com> Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com> Co-authored-by: gapra <gapra@microsoft.com> Co-authored-by: Kamil Sobol <kasobol@microsoft.com> Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hidden in this PR, so this PR effectively reverses https://github.com/Azure/azure-sdk-for-java/pull/21152/files