Implemented list deleted root blob with versions #21996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gapra-msft
commented
Jun 1, 2021
...c/main/java/com/azure/storage/blob/implementation/models/ContainersGetPropertiesHeaders.java
Outdated
Show resolved
Hide resolved
gapra-msft
commented
Jun 1, 2021
...c/main/java/com/azure/storage/blob/implementation/models/ContainersGetPropertiesHeaders.java
Outdated
Show resolved
Hide resolved
gapra-msft
commented
Jun 1, 2021
...re-storage-blob/src/main/java/com/azure/storage/blob/models/BlobContainerItemProperties.java
Outdated
Show resolved
Hide resolved
gapra-msft
commented
Jun 1, 2021
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
jaschrep-msft
approved these changes
Jun 15, 2021
kasobol-msft
approved these changes
Jun 17, 2021
| @@ -265,6 +265,8 @@ public static BlobItem populateBlobItem(BlobItemInternal blobItemInternal) { | |||
| blobItem.setObjectReplicationSourcePolicies( | |||
| transformObjectReplicationMetadata(blobItemInternal.getObjectReplicationMetadata())); | |||
|
|
|||
| blobItem.setHasVersionsOnly(blobItemInternal.isHasVersionsOnly()); | |||
There was a problem hiding this comment.
isHasVersionsOnly 😱 . The generator's code is very idiomatic.
There was a problem hiding this comment.
Yeah - it's kinda bad about booleans
kasobol-msft
added a commit
that referenced
this pull request
Jun 24, 2021
* Set up STG78 branch (#21634) * Generated off latest version of blob swagger (#21644) * Reenabled quick query parquet support (#21785) * Implemented Immutable Storage with Versioning (#21718) * File listing v2 (#21720) * swagger generation and hookup regenerated files swagger for listing hooked up generated and handwritten models expanded client API to support new models * testing and fixes expanded test parameters for file listing. swagger transform added. * rerecorded file listing test * more testing also fixed a method name casing * docstrings and samples * checkstyle * reverted primative boolean extended info arg REST api accepts true or an absence of value. Alligning with .NET for now on Boolean vs boolean. * checkpoint * pr feedback * misused variable fix * fixed test * send nothing, not false: include-extended-info other minor fixes rerecorded tests * import cleanup * swagger regeneration and test fixes * API comments extendedInfo boolean => Boolean renamed options class * reidentified samples for options class name change Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com> * Fix test. * Implemented list deleted root blob with versions (#21996) * Addressed comments for immutable storage with versioning (#22388) * Develop on main, part 1 (#22451) * move back service version. * pin CI. * fix ci. * fix ci ? * fix live tests ? * use latest service version to filter if not specified in variable. * use latest service version to filter if not specified in variable. * does this work ?? * missing stuff. * move that piece to parent as well. * rollback yml changes in favor of pom.xml * fix build ? * how about this ? * more ? * not this. * rollback some. * does this work ?? Co-authored-by: Gauri Prasad <51212198+gapra-msft@users.noreply.github.com> Co-authored-by: gapra <gapra@microsoft.com> Co-authored-by: James <41338290+jaschrep-msft@users.noreply.github.com> Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Jan 16, 2023
Dev search microsoft.search 2022 09 01 (Azure#21964) * Adds base for updating Microsoft.Search from version stable/2020-08-01 to version 2022-09-01 * Updates readme * Updates API version in new specs and examples * Add missing private endpoint connection properties (Azure#21629) * add missing private endpoint connection properties * fix errors * Adding delegated identities to data plane * Revert "Adding delegated identities to data plane" This reverts commit def1bd3ba296458c19b8f04cb1a7a5b800d002f9. * Fix Lint ProvisioningStateValidation Error * Applying prettier changes npm run prettier -- --write Co-authored-by: Enrique Jaimes <enjaimes@microsoft.com> * Satumkur/new api ver 20220901 (Azure#21922) * semantic updates * Add Dataplane RBAC related changes + examples * Prettier fixes * Fix LintDiff errors * Update SearchUpdateServiceDisableLocalAuth.json update erroneous api version param Co-authored-by: Samartha Tumkur Vani <satumkur@microsoft.com> Co-authored-by: Enrique Jaimes <enjaimes@microsoft.com> * Add CMK Enforcement policy support (Azure#21996) * Add CMK Enforcement policy support * Update api-version * Remove unused properties * Remove bypass property Co-authored-by: satumkurmsft <72990508+satumkurmsft@users.noreply.github.com> Co-authored-by: Matt <57731498+mattmsft@users.noreply.github.com> Co-authored-by: Samartha Tumkur Vani <satumkur@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.