[Storage][Blob][Bug]Support parsing blob url with '/' in blob name #12619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiafu-msft
requested review from
amishra-dev,
annatisch,
rakshith91 and
zezha-msft
as code owners
ghost
added
the
xiafu-msft
added
the
bug
|
/azp run python - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rakshith91
reviewed
Aug 8, 2020
| @@ -320,11 +325,11 @@ def __exit__(self, *args): # pylint: disable=arguments-differ | |||
| pass | |||
|
|
|||
|
|
|||
| def format_shared_key_credential(account, credential): | |||
| def format_shared_key_credential(account_name, credential): | |||
There was a problem hiding this comment.
we should rename this to _format_shared_key_credential . It's not exposed so rather make it private
rakshith91
reviewed
Aug 12, 2020
| container_client = ContainerClient( | ||
| account_url='http://127.0.0.1:1000/devstoreaccount1', | ||
| container_name='newcontainer', | ||
| credential='Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==') |
There was a problem hiding this comment.
hoping this is not real :P
There was a problem hiding this comment.
I bet we'll get email to remove it soon :P
rakshith91
approved these changes
Aug 12, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 17, 2020
…into get_certs_2016 * 'master' of https://github.com/Azure/azure-sdk-for-python: (26 commits) Type inference (Azure#12980) Add azure-ai-anomalydetector to error code 5 ignored list (Azure#13131) Handle missing model properties in Key Vault 2016-10-01 (Azure#13129) fix aad test so it runs locally (Azure#13127) Suppress errors in anomoly detector for now. (Azure#13141) Anomaly Detector V1, track2 generator (Azure#12931) [formrecognizer] Add `kind` to FormElement (Azure#13079) Regenerate code from connie's swagger change (Azure#12979) Update async (Azure#12978) Move get_access_conditions to _serialize.py (Azure#13105) [Storage][DataLake]Update Min Dependency (Azure#13108) Restore user authentication API from 1.4.0b7 (Azure#13070) [Storage][FileShare]ChangeLog update (Azure#13103) remove locale (Azure#13102) [Storage][Blob]ChangeLog Update (Azure#13081) Fixed etag bug (Azure#13078) [Storage][Blob]Fix live test and if tags bug (Azure#13054) [Storage][Blob][Batch]Support batch delete empty blob list (Azure#13029) [Storage][Blob][Bug]Support parsing blob url with '/' in blob name (Azure#12619) [formrecognizer] add api version enum (Azure#12888) ...
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Feb 8, 2021
[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2020-04-01-preview (Azure#12619)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12563
#12568