Regenerate code from connie's swagger change #12979
Conversation
| @@ -5,7 +5,7 @@ | |||
| # -------------------------------------------------------------------------- | |||
| import platform | |||
| import sys | |||
| from ._generated.version import VERSION | |||
| from ._generated._version import VERSION | |||
|
|
|||
| # UserAgent string sample: 'Azure-Storage/0.37.0-0.38.0 (Python CPython 3.4.2; Windows 8)' | |||
| # First version(0.37.0) is the common package, and the second version(0.38.0) is the service package | |||
There was a problem hiding this comment.
Are we actually using the user-agent string below? This doesn't fit our format:
https://azure.github.io/azure-sdk/general_azurecore.html#telemetry-policy
There was a problem hiding this comment.
Also we've talked about this partially offline, @seankane-msft were you able to find out a way to not import this and set the x-ms-version on our side, and just rely on the generated code? I think this can also be addressed in a separate PR as long as there's an issue open for it
There was a problem hiding this comment.
I have not yet, there is an issue out related with the versioning (#12411)
sdk/tables/azure-data-tables/azure/data/tables/_generated/_azure_table.py
Outdated
Show resolved
Hide resolved
| @@ -37,7 +40,7 @@ def __init__( | |||
|
|
|||
| self.url = url | |||
| self.version = "2019-02-02" | |||
| kwargs.setdefault('sdk_moniker', 'azuretable/{}'.format(VERSION)) | |||
| kwargs.setdefault('sdk_moniker', 'table/{}'.format(VERSION)) | |||
There was a problem hiding this comment.
this too, I think this should be data-tables/
Wondering if we need to regenerate with autorest and specify namespace like,
--namespace=azure.data.tables --package-name=azure-data-tables
There was a problem hiding this comment.
@kristapratico yeah the correct sdk moniker should be 'data-tables'. But we shouldn't need to regenerate, since we're overwriting the generated code's sdk moniker here. Instead, the code I linked should be changed to "data-tables".
@seankane-msft can you change this? We tend to keep the user agent in a separate file, that way you can import the constant from the file and use it. TA file example here, and for now, you can just import the user agent constant from that file and set sdk_moniker equal to that
There was a problem hiding this comment.
unrelated to user-agent, I think we still need to regen with azure-data-tables otherwise all generated code refs will be off
There was a problem hiding this comment.
yeah ended up agreeing with you after going through the whole SDK. I don't think it's 100% necessary since it's more for us, but do agree it would look a lot better
There was a problem hiding this comment.
@kristapratico @iscai-msft I regenerated this, user-agent isn't used anywhere in this sdk, should I move it to it's own file or should I remove it entirely?
There was a problem hiding this comment.
You can move it to its own file like how izzy linked above, it's more manageable that way. It looks like the current user-agent string is
azsdk-python-storage-table/2019-07-07 Python/3.8.3 (Windows-10-10.0.19041-SP0)
and it should look like this:
azsdk-python-data-tables/{SDK version} Python/3.8.3 (Windows-10-10.0.19041-SP0)
There was a problem hiding this comment.
Actually going through the whole PR, i think it twould be better / more clean to regenerate with package-name azure-data-tables and namespace azure.data.tables as @kristapratico suggested. But overall it looks good, some issues that we might want to address in a separate PR though
| @@ -5,7 +5,7 @@ | |||
| # -------------------------------------------------------------------------- | |||
| import platform | |||
| import sys | |||
| from ._generated.version import VERSION | |||
| from ._generated._version import VERSION | |||
|
|
|||
| # UserAgent string sample: 'Azure-Storage/0.37.0-0.38.0 (Python CPython 3.4.2; Windows 8)' | |||
| # First version(0.37.0) is the common package, and the second version(0.38.0) is the service package | |||
There was a problem hiding this comment.
Also we've talked about this partially offline, @seankane-msft were you able to find out a way to not import this and set the x-ms-version on our side, and just rely on the generated code? I think this can also be addressed in a separate PR as long as there's an issue open for it
…into get_certs_2016 * 'master' of https://github.com/Azure/azure-sdk-for-python: (26 commits) Type inference (Azure#12980) Add azure-ai-anomalydetector to error code 5 ignored list (Azure#13131) Handle missing model properties in Key Vault 2016-10-01 (Azure#13129) fix aad test so it runs locally (Azure#13127) Suppress errors in anomoly detector for now. (Azure#13141) Anomaly Detector V1, track2 generator (Azure#12931) [formrecognizer] Add `kind` to FormElement (Azure#13079) Regenerate code from connie's swagger change (Azure#12979) Update async (Azure#12978) Move get_access_conditions to _serialize.py (Azure#13105) [Storage][DataLake]Update Min Dependency (Azure#13108) Restore user authentication API from 1.4.0b7 (Azure#13070) [Storage][FileShare]ChangeLog update (Azure#13103) remove locale (Azure#13102) [Storage][Blob]ChangeLog Update (Azure#13081) Fixed etag bug (Azure#13078) [Storage][Blob]Fix live test and if tags bug (Azure#13054) [Storage][Blob][Batch]Support batch delete empty blob list (Azure#13029) [Storage][Blob][Bug]Support parsing blob url with '/' in blob name (Azure#12619) [formrecognizer] add api version enum (Azure#12888) ...
Regenerates the
_generatedfile and updates theget_entitymethod for the new changes.