Fixed etag bug #13078
Merged
Fixed etag bug #13078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasherif-msft
requested review from
amishra-dev,
annatisch,
kasobol-msft,
rakshith91 and
zezha-msft
as code owners
xiafu-msft
previously approved these changes
Aug 12, 2020
|
I just noticed we have the same issue in lease_async.py, can you also fix that in this pr ^_^ sorry that I didn't describe it in the github issue |
xiafu-msft
previously approved these changes
Aug 12, 2020
xiafu-msft
approved these changes
Aug 12, 2020
Done :) |
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 17, 2020
…into get_certs_2016 * 'master' of https://github.com/Azure/azure-sdk-for-python: (26 commits) Type inference (Azure#12980) Add azure-ai-anomalydetector to error code 5 ignored list (Azure#13131) Handle missing model properties in Key Vault 2016-10-01 (Azure#13129) fix aad test so it runs locally (Azure#13127) Suppress errors in anomoly detector for now. (Azure#13141) Anomaly Detector V1, track2 generator (Azure#12931) [formrecognizer] Add `kind` to FormElement (Azure#13079) Regenerate code from connie's swagger change (Azure#12979) Update async (Azure#12978) Move get_access_conditions to _serialize.py (Azure#13105) [Storage][DataLake]Update Min Dependency (Azure#13108) Restore user authentication API from 1.4.0b7 (Azure#13070) [Storage][FileShare]ChangeLog update (Azure#13103) remove locale (Azure#13102) [Storage][Blob]ChangeLog Update (Azure#13081) Fixed etag bug (Azure#13078) [Storage][Blob]Fix live test and if tags bug (Azure#13054) [Storage][Blob][Batch]Support batch delete empty blob list (Azure#13029) [Storage][Blob][Bug]Support parsing blob url with '/' in blob name (Azure#12619) [formrecognizer] add api version enum (Azure#12888) ...
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Feb 26, 2021
[Hub Generated] Review request for Microsoft.Security to add version stable/2020-01-01 (Azure#13078) * fixing serverVulnerabilityAssessments swagger correctness in the delete action (instead of synchronous operation it is an asynchronous one) - so adding the operationResults path * fix the examples path * updates to the delete and operationResults responses and status codes * removing the long-running-operation from the put, and adding the synchronous status codes to the delete as well * fixing unconnected validation errors in SDK Track2 Validation * fixing SDK Track2 Validation errors - the same specifications were used twice under the same tag (the commented out version and a newer preview api-version) - which caused errors like: "Duplicate Operation '{Get/List}' detected" * Revert "fixing SDK Track2 Validation errors - the same specifications were used twice under the same tag (the commented out version and a newer preview api-version) - which caused errors like: "Duplicate Operation '{Get/List}' detected"" This reverts commit 12baa06128ddfd985a8ae7425e015f2ff86fe738. * Revert "fixing unconnected validation errors in SDK Track2 Validation" This reverts commit 056ae33764ebee243be8158e0e5d3259c654a3b7. * removing the operationResults path and example from the swagger - as this resource type does not need to be declared in the Swagger (verified in ARM office hours)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves to #8490 intended to fix a small etag bug. Initially the etag variable was empty since it was not storing the appropriate response etag. Two additional unit tests were added.