[textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput #16542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DetectLanguageInput
a-noyass
requested review from
abhahn,
iscai-msft and
kristapratico
as code owners
ghost
added
the
iscai-msft
approved these changes
Feb 4, 2021
| @@ -740,6 +740,12 @@ def __repr__(self): | |||
| class DetectLanguageInput(LanguageInput): | |||
| """The input document to be analyzed for detecting language. | |||
|
|
|||
| :keyword str id: Unique, non-empty document identifier. | |||
There was a problem hiding this comment.
hey @a-noyass thank you so much for doing this PR.
When adding the keyword docstrings, you can remove the ivar ones, so they're not duplicated. Other than that your pr looks great!
There was a problem hiding this comment.
actually @a-noyass i'm totally wrong, we should keep both. Going to merge your PR when it's green
There was a problem hiding this comment.
@iscai-msft Okay. Thank you!
iscai-msft
added a commit
to abhahn/azure-sdk-for-python
that referenced
this pull request
Feb 5, 2021
…into expose_length * 'master' of https://github.com/Azure/azure-sdk-for-python: [textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput (Azure#16542) [SB] combine conn str parser logic in base handler and _common (Azure#16464) [text analytics] add analyze readme bullet point (Azure#16552) resolve issues with failing search documents on mindependency checks (Azure#16553) [text analytics] analyze changes (Azure#16418) [Core] Added enum meta class (Azure#16316) Adding missing supported fields to invoice sample (Azure#16547) Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545) patching the publishing of artifacts only on successful run (Azure#16539) need to bump msrest up one (Azure#16544) [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515) add dotenv as a dep for azure-sdk-tools (Azure#16532) skip prebuilt from_url tests for now (Azure#16534) Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510) CertificateCredential accepts certs as bytes (Azure#16410)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Feb 5, 2021
…into new_polling * 'master' of https://github.com/Azure/azure-sdk-for-python: (250 commits) Converting to pure unit tests (Azure#16499) Fix replace keys for nested json (Azure#16557) update release date (Azure#16543) Feature/communication chat preview3 new model (Azure#16561) [text analytics] Exposed the length property in classes impacted by `string_index_type` (Azure#16538) [textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput (Azure#16542) [SB] combine conn str parser logic in base handler and _common (Azure#16464) [text analytics] add analyze readme bullet point (Azure#16552) resolve issues with failing search documents on mindependency checks (Azure#16553) [text analytics] analyze changes (Azure#16418) [Core] Added enum meta class (Azure#16316) Adding missing supported fields to invoice sample (Azure#16547) Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545) patching the publishing of artifacts only on successful run (Azure#16539) need to bump msrest up one (Azure#16544) [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515) add dotenv as a dep for azure-sdk-tools (Azure#16532) skip prebuilt from_url tests for now (Azure#16534) Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510) CertificateCredential accepts certs as bytes (Azure#16410) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16482