Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing supported fields to invoice sample #16547

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

catalinaperalta
Copy link
Member

Fixes #15792.

@catalinaperalta
Copy link
Member Author

I've updated the sample to use the invoice linked in the issue, but I could create another sample that uses the other invoice as well. Not sure how much value it would add since that one only shows a subset of the fields that the new invoice adds.

Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kristapratico
Copy link
Member

I've updated the sample to use the invoice linked in the issue, but I could create another sample that uses the other invoice as well. Not sure how much value it would add since that one only shows a subset of the fields that the new invoice adds.

I think one sample per sync/async for invoices is enough.

@catalinaperalta catalinaperalta marked this pull request as ready for review February 4, 2021 22:15
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my gosh @catalinaperalta so much work

@catalinaperalta catalinaperalta merged commit c17f3f3 into Azure:master Feb 4, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Feb 4, 2021
…into add_analyze_readme

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [text analytics] analyze changes (Azure#16418)
  [Core] Added enum meta class (Azure#16316)
  Adding missing supported fields to invoice sample (Azure#16547)
  Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545)
  patching the publishing of artifacts only on successful run (Azure#16539)
  need to bump msrest up one (Azure#16544)
  [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515)
  add dotenv as a dep for azure-sdk-tools (Azure#16532)
  skip prebuilt from_url tests for now (Azure#16534)
  Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510)
  CertificateCredential accepts certs as bytes (Azure#16410)
iscai-msft added a commit to abhahn/azure-sdk-for-python that referenced this pull request Feb 5, 2021
…into expose_length

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput (Azure#16542)
  [SB] combine conn str parser logic in base handler and _common (Azure#16464)
  [text analytics] add analyze readme bullet point (Azure#16552)
  resolve issues with failing search documents on mindependency checks (Azure#16553)
  [text analytics] analyze changes (Azure#16418)
  [Core] Added enum meta class (Azure#16316)
  Adding missing supported fields to invoice sample (Azure#16547)
  Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545)
  patching the publishing of artifacts only on successful run (Azure#16539)
  need to bump msrest up one (Azure#16544)
  [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515)
  add dotenv as a dep for azure-sdk-tools (Azure#16532)
  skip prebuilt from_url tests for now (Azure#16534)
  Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510)
  CertificateCredential accepts certs as bytes (Azure#16410)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Feb 5, 2021
…into new_polling

* 'master' of https://github.com/Azure/azure-sdk-for-python: (250 commits)
  Converting to pure unit tests (Azure#16499)
  Fix replace keys for nested json (Azure#16557)
  update release date (Azure#16543)
  Feature/communication chat preview3 new model (Azure#16561)
  [text analytics] Exposed the length property in classes impacted by `string_index_type` (Azure#16538)
  [textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput (Azure#16542)
  [SB] combine conn str parser logic in base handler and _common (Azure#16464)
  [text analytics] add analyze readme bullet point (Azure#16552)
  resolve issues with failing search documents on mindependency checks (Azure#16553)
  [text analytics] analyze changes (Azure#16418)
  [Core] Added enum meta class (Azure#16316)
  Adding missing supported fields to invoice sample (Azure#16547)
  Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545)
  patching the publishing of artifacts only on successful run (Azure#16539)
  need to bump msrest up one (Azure#16544)
  [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515)
  add dotenv as a dep for azure-sdk-tools (Azure#16532)
  skip prebuilt from_url tests for now (Azure#16534)
  Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510)
  CertificateCredential accepts certs as bytes (Azure#16410)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[formrecognizer] show all available fields in invoice sample
3 participants