raise decode error instead of ContentDecodingError #19433
Conversation
ghost
added
the
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## 1.15.1 (Unreleased) | |||
|
|
|||
| ### Breaking Changes | |||
|
|
|||
| - Sync stream downloading now raises `azure.core.exceptions.DecodeError` rather than `requests.exceptions.ContentDecodingError` | |||
There was a problem hiding this comment.
Are we okay with this breaking change because no one should have written code to explicitly handle this error?
There was a problem hiding this comment.
Yes. Checked with @johanste and he agreed this was an acceptable breaking change.
| raise requests.exceptions.ContentDecodingError(e) | ||
| raise ServiceResponseError(e, error=e) | ||
| except CoreDecodeError as e: | ||
| raise DecodeError(e, error=e) |
There was a problem hiding this comment.
This scenario is being correctly handled in the other transports?
There was a problem hiding this comment.
Currently different transport raises different type of error. (That's the reason we need this change).
We want to uniform the errors so user can catch all by using except AzureError.
|
/azp run python - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API changes have been detected in |
|
API changes have been detected in |
…into add_webpubsub_tests * 'main' of https://github.com/Azure/azure-sdk-for-python: [Key Vault] Add support for multi-tenant authentication (Azure#21290) [webpubsub] regen with hub as a client parameter (Azure#21688) update automatic close mechanism (Azure#21580) [Test Proxy] Add fixture to automatically start/stop Docker container (Azure#21538) Update Monitor Query API ref link (Azure#21683) Migration Guide from Azure-loganalytics (Azure#21674) Update docs for Web PubSub GA (Azure#21659) Update CHANGELOG.md (Azure#21681) Increment version for formrecognizer releases (Azure#21678) Increment version for videoanalyzer releases (Azure#21455) Increment version for cognitivelanguage releases (Azure#21566) Increment version for storage releases (Azure#21652) Increment version for communication releases (Azure#21667) raise decode error instead of ContentDecodingError (Azure#19433) Update CHANGELOG.md (Azure#21679) resolve mac agent failure (Azure#21677) Re-add get-codeowners.ps1 (Azure#21676) [SchemaRegistry] remove schema prefix in params (Azure#21675) Validate python docs packages using docker (Azure#21657) update git helper (Azure#21670)
No description provided.