Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Storage] Revert removing aiohttp dependency for storage.blob.aio" #25393

Closed
wants to merge 1 commit into from

Conversation

Stevenjin8
Copy link
Contributor

@Stevenjin8 Stevenjin8 commented Jul 25, 2022

Description

Reverts #25084 and is similar to #25017. In a nutshell,

In this line of code

data is an instance of azure.core.pipeline.transport._requests_basic.StreamDownloadGenerator. Looking at the history of StreamDownloadGenerator.__next__, I found that

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jul 25, 2022
@Stevenjin8 Stevenjin8 self-assigned this Jul 25, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-blob

@Stevenjin8
Copy link
Contributor Author

see #25455

@Stevenjin8 Stevenjin8 closed this Jul 28, 2022
@Stevenjin8 Stevenjin8 deleted the revert-25084-revert_aiohttp branch August 11, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants