Update Ubuntu images to 1ES-hosted Ubuntu 22.04 in many places #4996
Conversation
konrad-jamrozik
requested review from
scbedd,
mikeharder,
benbp,
ckairen,
dw511214992,
chunyu3,
zzvswxy,
weshaggard,
a team and
sima-zhu
as code owners
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
changed the title
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
| @@ -31,7 +31,7 @@ RUN apt install python3-pip -y && apt install python3-venv -y && pip3 install -- | |||
| RUN add-apt-repository ppa:deadsnakes/ppa -y && apt-get install python3.10 -y && apt-get install python3.10-venv -y | |||
|
|
|||
| # install powershell | |||
| RUN wget -q https://packages.microsoft.com/config/ubuntu/20.04/packages-microsoft-prod.deb | |||
| RUN wget -q https://packages.microsoft.com/config/ubuntu/22.04/packages-microsoft-prod.deb | |||
There was a problem hiding this comment.
Please revert it because our docker image is based on ubuntu 20.04 now.
There was a problem hiding this comment.
@dw511214992 I have reverted all the changes to tools/sdk-generation-pipeline, but I kindly ask you to review this PR:
I left some questions there for you in the PR description.
Thank you!
There was a problem hiding this comment.
@konrad-jamrozik I have added comment to your PR. thanks
|
The following pipelines have been queued for testing: |
|
Changes look good to me, but I think we should hold off on merging until after the holidays when we're better equipped to deal with any failures that result in our tooling/pipelines from the OS upgrade. |
konrad-jamrozik
force-pushed
the
users/kojamroz/iss_4967
branch
2 times, most recently
from
7145170
to
ea4e783
Compare
|
The following pipelines have been queued for testing: |
konrad-jamrozik
force-pushed
the
users/kojamroz/iss_4967
branch
from
02f4d06
to
1007c9c
Compare
konrad-jamrozik
changed the title
konrad-jamrozik
changed the title
There was a problem hiding this comment.
LGTM. I think you can merge the following changes in #5004 to this PR:
- tools/sdk-generation-pipeline/.github/workflows/ci.yml
- tools/sdk-generation-pipeline/ci.yml
- tools/sdk-generation-pipeline/sdk-generation-pipeline.yml
If you want to merge them in separate PR, it's fine too.
Thanks
Contributes to addressing:
azure-sdk-tools(includinglatest) to Ubuntu 22.04 #4967which is part of work to address:
As a secondary change, gets rid of all
#ubuntu-2004hyperlink anchors.I found the places to migrate by doing full-text search for following strings, and then manually reviewing the found matches:
1604,16.04,1804,18.04,2004,20.04.I didn't migrate the following Ubuntu image usages:
job-matrix. This will be done as part of:eng/common;eng/commonto Ubuntu 22.04 #5005tools/sdk-generation-pipeline, because of this build failure. See also this conversation.tools/sdk-generation-pipelineto Ubuntu 22.04 #5004.ubuntu-latest; this is done by:ubuntu-latestimages: set them to Ubuntu 22.04 XOR comment they arelatestintentionally #500616.04-LTSreferences intools\sdk-testgen, in following directories, as they seem to be committed debug symbols or samples, which are not that important:azure-sdk-tools\tools\sdk-testgen\packages\autorest.testmodeler\test\integrationtest\outputazure-sdk-tools\tools\sdk-testgen\swagger\specification\compute\resource-manager\Microsoft.Compute\stable\<date>\examples