Components es6 apply code review fix suggestions #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
reviewed
Aug 25, 2021
| @@ -357,6 +358,7 @@ | |||
| options.group = "[Sampler" + options.number + "]"; | |||
| options.outKey = null, // hack to get Component constructor to call connect() | |||
| super(options); | |||
| // this.connect(); | |||
There was a problem hiding this comment.
Ups, yes this was on accident. It was left from a previous experiment where I tried to call connect after the parent constructor but that didn't work out-right so I wanted to take a look some other time.
Be-ing
reviewed
Aug 25, 2021
| @@ -125,6 +125,7 @@ | |||
| } | |||
| } | |||
| trigger() { | |||
|
|
|||
There was a problem hiding this comment.
eslint broke when I removed it. Seems to me like some obscure bug but idk.
…ded_effect Effects refactoring: loaded effect
EffectChain: make setting chain_preset_selector to 0 a no-op
Notes:
* m_pFifoChunkBuffer was actualy an array pointer; was not deleted
safely. Refactor fixes memory leak.
* Used void*[] implicit conversions for protobuf.
* Used "auto _ = std::vector{}" style for some assignments.
* Default'ed empty virtual destructors and fully removed other empty
destructors from codebase.
* Used std::vector<T>.resize() in place of raw-new.
EffectChain: name ControlObjects consistently with chain_preset
Hopefully this will result in less frequent cache misses.
GH Actions: lower compiler cache size to 0.5 GB
This finishes the refactoring started in mixxxdj@33405b2
…ineParameters Rename variables of type EnigineParameter to engineParameters
…types Removed raw array pointer types for std::vector
without the indirection via sidebar, and without assuming the library is next/after the sidebar.
Focus library directly
WTrackMenu: Add missing feature to all features enum variant
Update vendored Benchmark library to v1.6.0
…bled WTrackMenu::featureIsEnabled(): Fix unhandled case
don't wipe inapplicable sound config immediately
Define `CFBundleName` in macOS bundle
HidController: return QByteArrays for get[Input/Feature]Report
- Add initial macOS Big Sur icon draft - Replace macOS icon lens flare with brighter gradient - Add drop shadow to macOS icon - Update macOS ICNS files - Remove hidden layers from new macOS icon
Add a Big Sur-style rounded rectangle icon on macOS
* MiniMixxx: Initial implementation * MiniMixxx: Start implementing buttons * MiniMixxx: Implement layers * MiniMixxx: relative pitch slider mode * MiniMixxx: wheel spinnies! * MiniMixxx: forgot to hook up a connection * MiniMixxx: small light tweak * MiniMixxx: sampler layer * MiniMixxx: Fix some layer switching issues * MiniMixxx: library mode * MiniMixxx: add fx layer oh no I have no room for hotcues! * MiniMixxx: rearrange file * MiniMixxx: factor out vu meter color * MiniMixxx: Add hotcue layer Because we are out of buttons, hotcues are activated for both decks at once. That seems ok. MiniMixxx is now feature complete! * MiniMixxx: allow for scrubbing through track in library mode * MiniMixxx: Add newline to satisfy linter * MiniMixxx: Factor out colors * MiniMixxx: Add main output adjustments * MiniMixxx: trying to get consistent behavior with layers * MiniMixxx: cleanup * MiniMixxx: more cleanup * MiniMixxx: Apply eslint * MiniMixxx: cleanup and fix comments * MiniMixxx: Upgrade to javascript classes * MiniMixx: fix sync button push-and-lock * MiniMixxx: Use newer engine connection API * MiniMixxx: use proper debug output * Minimixxx: make it possible to expand tree items in library browsing * MiniMixxx: bind booth volume adjustment Also create mode where pitch sliders don't do anything *unless* shift is held. This prevents mixtakes * minimixxx: adjust jog sensitivity * MiniMixxx: make righthand library encoder scroll horizontally also some minor tweaks * Minimixxx: fix typo * raspi: make hotcues the non-shift action * Minimixxx: rename files to be consistent * Minimixxx: use switches where possible * Update res/controllers/Yaeltex MiniMixxx.midi.xml Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com> * Update res/controllers/Yaeltex-MiniMixxx-scripts.js Co-authored-by: Be <be.0@gmx.com> * Minimixxx: revert bad change (var was undefined) * Minimixxx: disclaimer Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com> Co-authored-by: Be <be.0@gmx.com>
…tadartpaths remove unused includes QDesktop/QStandardPaths
Make Button.types enum a static frozen/read-only property on the button object in an effort to reduce the exposure of the prototype
replace `function(){}.bind(this)` pattern with arrow functions where
applicable.
Swiftb0y
force-pushed
the
components_es6
branch
from
2c74d29
to
bb47432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some of the minimally invasive fixes I suggested during code review. I don't have have access to my controller atm so it'll take some time until I'll be able to implement other stuff I suggested during review.