-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on oldest-supported-numpy instead of plain NumPy #134
Conversation
Requiring an oldest version of NumPy causes less incompatibilities with other projects (esp. if they depend on oldest-supported-numpy themselves). Tests seem to work just fine, and generated documentation still looks ok.
requirements-runtime.txt
Outdated
@@ -1,4 +1,4 @@ | |||
msgpack | |||
ndindex>=1.4 | |||
numpy>=1.20.3 | |||
oldest-supported-numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for runtime numpy<2
is a better option (oldest-supported-numpy
is mainly for building purposes).
requirements-test-wheels.txt
Outdated
@@ -1,5 +1,5 @@ | |||
pip | |||
numpy<2 | |||
oldest-supported-numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
requirements-tests.txt
Outdated
@@ -1,5 +1,5 @@ | |||
pip | |||
numpy<2 | |||
oldest-supported-numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
This makes the package more compatible with others at runtime too. With this, the modifications amount to changing build dependency on numpy<2 to oldest-supported-numpy, and runtime dependency on numpy>=1.20.3 to numpy<2 (as in other runtime-like requirements files). Suggested by @FrancescAlted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am doing the necessary changes for this in PR #135. This can be closed now. |
Requiring an oldest version of NumPy causes less incompatibilities with other projects (esp. if they depend on oldest-supported-numpy themselves).
Tests seem to work just fine, and generated documentation still looks ok.