Depend on oldest-supported-numpy instead of plain NumPy #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requiring an oldest version of NumPy causes less incompatibilities with other projects (esp. if they depend on oldest-supported-numpy themselves). Tests seem to work just fine, and generated documentation still looks ok.
requirements-runtime.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| msgpack | |||
| ndindex>=1.4 | |||
| numpy>=1.20.3 | |||
| oldest-supported-numpy | |||
There was a problem hiding this comment.
I think for runtime numpy<2 is a better option (oldest-supported-numpy is mainly for building purposes).
FrancescAlted
requested changes
Sep 26, 2023
requirements-test-wheels.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| pip | |||
| numpy<2 | |||
| oldest-supported-numpy | |||
requirements-tests.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| pip | |||
| numpy<2 | |||
| oldest-supported-numpy | |||
This makes the package more compatible with others at runtime too. With this, the modifications amount to changing build dependency on numpy<2 to oldest-supported-numpy, and runtime dependency on numpy>=1.20.3 to numpy<2 (as in other runtime-like requirements files). Suggested by @FrancescAlted.
|
I am doing the necessary changes for this in PR #135. This can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring an oldest version of NumPy causes less incompatibilities with other projects (esp. if they depend on oldest-supported-numpy themselves).
Tests seem to work just fine, and generated documentation still looks ok.