Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on oldest-supported-numpy instead of plain NumPy #134

Closed
wants to merge 4 commits into from
Closed

Depend on oldest-supported-numpy instead of plain NumPy #134

wants to merge 4 commits into from

Commits on Sep 26, 2023

  1. Depend on oldest-supported-numpy instead of plain NumPy 

    Requiring an oldest version of NumPy causes less incompatibilities with other
projects (esp. if they depend on oldest-supported-numpy themselves).

Tests seem to work just fine, and generated documentation still looks ok.
    @ivilata
    ivilata committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    61c4b00 View commit details
    Browse the repository at this point in the history

  2. Relax runtime dependencies on NumPy 

    This makes the package more compatible with others at runtime too.

With this, the modifications amount to changing build dependency on numpy<2 to
oldest-supported-numpy, and runtime dependency on numpy>=1.20.3 to numpy<2 (as
in other runtime-like requirements files).

Suggested by @FrancescAlted.
    @ivilata
    ivilata committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1a3f644 View commit details
    Browse the repository at this point in the history

  3. Test whether oldest numpy makes test suite crash on win

    @FrancescAlted
    FrancescAlted committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1a5ddd7 View commit details
    Browse the repository at this point in the history

  4. Probing the minimum NumPy supported

    @FrancescAlted
    FrancescAlted authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    8d64628 View commit details
    Browse the repository at this point in the history