Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade greenwood v0.15.0 #94

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Aug 6, 2021

Related Issue

N / A

Summary of Changes

  1. Upgrade latest version of Greenwood v0.15.0
  2. Made upgrade to pass explicit ?type=css to all CSS via ESM import calls
Looks like something broke with `develop` with the importMap :/ ![Screen Shot 2021-08-06 at 12 03 30 PM](https://user-images.githubusercontent.com/895923/128540064-2c52d5f1-5b84-4c8c-9382-e077a85e4928.png)

Works fine with serve, though Rollup does emit this warning

% yarn build
yarn run v1.22.5
$ greenwood build
-------------------------------------------------------
Welcome to Greenwood (v0.15.0) ♻️
-------------------------------------------------------
Running Greenwood with the build command.
Initializing project config
Initializing project workspace contexts
Generating graph of workspace files...
pages to generate
 /Users/owenbuckley/Workspace/analogstudios.net/repo/www.analogstudios.net/src/index.html
success, done generating all pages!
The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten

Same issue as in another SPA, but not an SSG / MPA 🤔

Both of those projects are using Lit@2 I believe, which is still in RC, fwiw

TODO

  1. Fix specs - fixed by handling .css files and trimming query string
  2. Get SPA issue fixed - node modules paths are being resolved to "matching" user workspace paths causing broken package loading ProjectEvergreen/greenwood#686
  3. Get fix for node_modules handling / URL forwarding - fix consistency with user plugin node modules resolution ProjectEvergreen/greenwood#692

@thescientist13 thescientist13 merged commit 50f068d into master Aug 11, 2021
@thescientist13 thescientist13 deleted the chore/upgrade-greenwood-0.15.0 branch August 11, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore needs upstream Dependency needed on Greenwood
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant