-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup dockerfile and add coral support #227
Conversation
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 72.26% 72.34% +0.07%
==========================================
Files 27 27
Lines 2632 2632
==========================================
+ Hits 1902 1904 +2
+ Misses 617 616 -1
+ Partials 113 112 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Simple solution.
I would like multiple dockerfiles sometime in the future, but that makes the build time huge Let's revisit this later, but I would do this for coral and gaiaflex |
# without this, build with LEDGER_ENABLED=false | ||
RUN apk add libusb-dev linux-headers | ||
# NOTE: add these to run with LEDGER_ENABLED=true | ||
# RUN apk add libusb-dev linux-headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another block like this a few lines above (line 6-7). Should we do the same there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I can remove that one entirely.
I guess I'll throw that in an existing branch - #229 to avoid a micro-pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ster * remotes/gaia/master: (38 commits) Merge PR CosmWasm#259: Bump SDK master commit Exec go mod tidy (CosmWasm#267) Merge PR CosmWasm#265: add version v2.0.5 to CHANGELOG Fix broken link in delegator guide (CosmWasm#262) docs: removed redundant readme.md (CosmWasm#261) Merge PR CosmWasm#258: Bump github.com/spf13/viper from 1.6.1 to 1.6.2 Merge PR CosmWasm#250: Docs-update Merge PR CosmWasm#256: Bump github.com/pkg/errors from 0.9.0 to 0.9.1 Merge PR CosmWasm#255: Bump github.com/pkg/errors from 0.8.1 to 0.9.0 Merge PR CosmWasm#253: Bump SDK master commit Merge PR CosmWasm#252: v2.0.4 Changelog Merge PR CosmWasm#249: docker image build and upload for release tags Merge PR CosmWasm#247: Update SDK Commit & Update CLI Doc Merge PR CosmWasm#246: Update Archive page with explorers Merge PR CosmWasm#245: archives Bump SDK commit to the latest master (CosmWasm#239) Merge PR CosmWasm#215: Update simulation tests Update join-mainnet.md (CosmWasm#229) Incorporate SDK's latest changes (CosmWasm#227) Merge PR CosmWasm#221: Hide unnecessarily exported function to better coverage report ...
coral
/corald
binariesTargeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added relevant
godoc
comments.Added a relevant changelog entry to the
Unreleased
section inCHANGELOG.md
Re-reviewed
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)