Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SourceName to SourceSpec #2843

Closed
amarjandu opened this issue Feb 26, 2021 · 2 comments
Closed

Rename SourceName to SourceSpec #2843

amarjandu opened this issue Feb 26, 2021 · 2 comments
Assignees
Labels
code [subject] Production code debt [type] A defect incurring continued engineering cost demoed [process] Successfully demonstrated to team orange [process] Done by the Azul team

Comments

@amarjandu
Copy link
Contributor

This was a FIXME that was part of a sketch done by @hannes-ucsc
See #2650 (comment)

Index: src/azul/indexer/__init__.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/azul/indexer/__init__.py b/src/azul/indexer/__init__.py
--- a/src/azul/indexer/__init__.py	(revision 46e23043c6a4421f588ce3ac9f17db488ae4c88a)
+++ b/src/azul/indexer/__init__.py	(date 1614202583703)
@@ -53,6 +53,9 @@
 SOURCE_NAME = TypeVar('SOURCE_NAME', bound='SourceName')
 
 
+# FIXME: Rename to SourceSpec/SOURCE_SPEC, and all .name to .spec
+#        <insert link to ticket here>
+
 class SourceName(ABC, Generic[SOURCE_NAME]):
     """
     The name of a repository source containing bundles to index. A repository
@amarjandu amarjandu added the orange [process] Done by the Azul team label Feb 26, 2021
@melainalegaspi melainalegaspi added code [subject] Production code debt [type] A defect incurring continued engineering cost labels Feb 26, 2021
@amarjandu
Copy link
Contributor Author

pushed this into in-progress during parking lot discussion w/ @hannes-ucsc .

This should be fixed before addressing #2750

@amarjandu amarjandu self-assigned this May 10, 2021
@hannes-ucsc
Copy link
Member

hannes-ucsc commented Jun 8, 2021

For demo, show source specifications in manifests and JSON responses, as well as a sampling of contributions and aggregate documents (using Kibana).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code [subject] Production code debt [type] A defect incurring continued engineering cost demoed [process] Successfully demonstrated to team orange [process] Done by the Azul team
Projects
None yet
Development

No branches or pull requests

4 participants