Fix: Missed SourceSpec renamings in azul.plugins.repository.canned (#2843)

[amarjandu]

Author

• PR title references issue
• Title of main commit references issue
• PR is linked to Zenhub issue

Author (reindex)

• Added r tag to commit title _{or this PR does not require reindexing}
• Added reindex label to PR _{or this PR does not require reindexing}

Author (freebies & chains)

• Freebies are blocked on this PR _{or there are no freebies in this PR}
• Freebies are referenced in commit titles _{or there are no freebies in this PR}
• This PR is blocked by previous PR in the chain _{or this PR is not chained to another PR}
• Added chain label to the blocking PR _{or this PR is not chained to another PR}

Author (upgrading)

• Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading}
• Added u tag to commit title _{or this PR does not require upgrading}
• Added upgrade label to PR _{or this PR does not require upgrading}

Author (requirements, before every review)

• Ran make requirements_update _{or this PR leaves requirements*.txt, common.mk and Makefile untouched}
• Added R tag to commit title _{or this PR leaves requirements*.txt untouched}
• Added reqs label to PR _{or this PR leaves requirements*.txt untouched}

Author (before every review)

• make integration_test passes in personal deployment _{or this PR does not touch functionality that could break the IT}
• Rebased branch on develop, squashed old fixups

Primary reviewer (after approval)

• Commented in issue about demo expectations _{or labelled issue as no demo}
• Decided if PR can be labeled no sandbox
• PR title is appropriate as title of merge commit
• Moved ticket to Approved column
• Assigned PR to an operator

Operator (before pushing merge the commit)

• Checked reindex label and r commit title tag
• Checked that demo expectations are clear _{or issue is labeled as no demo}
• Rebased and squashed branch
• Sanity-checked history
• Pushed PR branch to Github
• Branch pushed to Gitlab _{or PR is labeled no sandbox}
• Build passes in sandbox and added sandbox label _{or PR is labeled no sandbox}
• Started reindex in sandbox _{or this PR does not require reindexing sandbox}
• Checked for failures in sandbox _{or this PR does not require reindexing sandbox}
• Added PR reference to merge commit title
• Collected commit title tags in merge commit title
• Moved linked issue to Merged column
• Pushed merge commit to Github

Operator (after pushing the merge commit)

• Moved freebies to Merged column _{or there are no freebies in this PR}
• Shortened the PR chain _{or this PR is not the base of another PR}
• Verified that N reviews labelling is accurate
• Pushed merge commit to Gitlab _{or this changes can be pushed later, together with another PR}
• Deleted PR branch from Github and Gitlab

Operator (reindex)

• Started reindex in dev _{or this PR does not require reindexing or does not target dev}
• Checked for failures in dev _{or this PR does not require reindexing or does not target dev}
• Started reindex in prod _{or this PR does not require reindexing or does not target prod}
• Checked for failures in prod _{or this PR does not require reindexing or does not target prod}

Operator

• Unassigned PR

[codecov]

Codecov Report

Merging #3173 (c7cff8e) into develop (c7cff8e) will not change coverage.
The diff coverage is n/a.

❗ Current head c7cff8e differs from pull request most recent head 4b1f1f8. Consider uploading reports for the commit 4b1f1f8 to get more accurate results

@@           Coverage Diff            @@
##           develop    #3173   +/-   ##
========================================
  Coverage    82.68%   82.68%           
========================================
  Files          122      122           
  Lines        13552    13552           
========================================
  Hits         11206    11206           
  Misses        2346     2346           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7cff8e...4b1f1f8. Read the comment docs.

[coveralls]

Coverage remained the same at 82.925% when pulling 4b1f1f8 on issues/amar/2843-canned-spec into c7cff8e on develop.

[amarjandu]

Closing this PR, branch name has the wrong issue number in it.

[hannes-ucsc]

What's a "canned repository"? I think I know what you mean but this title is confusing.

[hannes-ucsc]

Title still not right. You're not updating a repository.

You can use file names in commit titles, you know?

[amarjandu]

Title still not right. You're not updating a repository.

You can use file names in commit titles, you know?

Yeah, but __init__.py is not really identifiable, and I dont want use the path as the file nested pretty far. In the past other commits reference TDR plugin or DSS Plugin, going to do something similar.

[hannes-ucsc]

Title even worse than before. There are no canned plugins. And "Canned" is not a proper noun either.

[hannes-ucsc]

I opened #3196 in relation to the typo you fixed.