Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover scripts/can_bundle.py in integration tests #3196

Closed
hannes-ucsc opened this issue Jul 2, 2021 · 1 comment
Closed

Cover scripts/can_bundle.py in integration tests #3196

hannes-ucsc opened this issue Jul 2, 2021 · 1 comment
Assignees
@nadove-ucsc
Labels
debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team orange [process] Done by the Azul team test [subject] Unit and integration test code

Comments

@hannes-ucsc
Copy link
Member

hannes-ucsc commented Jul 2, 2021 •
edited
Loading

The first commit in #3173 ("Fix typo in azul.plugins.repository.canned") fixes a fatal typo that we should have noticed much earlier.

The integration test should invoke scripts/can_bundle.py on one subgraph from each IT catalog, plus a known canned subgraph from the schema-test-data repo. The latter might require patching the configuration because no catalog currently uses the canned plugin.
@hannes-ucsc hannes-ucsc added orange [process] Done by the Azul team debt [type] A defect incurring continued engineering cost no sandbox [process] PR will not be tested in the sandbox test [subject] Unit and integration test code and removed no sandbox [process] PR will not be tested in the sandbox labels Jul 2, 2021
nadove-ucsc added a commit that referenced this issue Oct 1, 2021
@nadove-ucsc
[u] Cover can_bundle.py in integration tests (#3196)
07397b0
nadove-ucsc added a commit that referenced this issue Oct 1, 2021
@nadove-ucsc
[u] Cover can_bundle.py in integration tests (#3196, PR #3237)
2fbf613
@theathorn theathorn added the demoed [process] Successfully demonstrated to team label Oct 5, 2021
@jessebrennan jessebrennan added the demo [process] To be demonstrated at the end of the sprint label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadove-ucsc nadove-ucsc

Labels
debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team orange [process] Done by the Azul team test [subject] Unit and integration test code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hannes-ucsc @jessebrennan @theathorn @dsotirho-ucsc @nadove-ucsc