AJ-1095: Publish Library and CLI

[snf2ye]

Background

The goal of this PR is enable publishing of the java-pfb-library and java-pfb-cli.

Included Changes

1. Updated GHAs

• Now using reusable workflow instead of outdated workflow-dispatch
• Added publish action for library publish to artifactory
• Add action to create release in github that includes CLI jar

2. Enabled publishing of library

• We now have v0.1.0 of the library published to artifactory for java-pfb-library
• POC imports of library in java-pfb-cli and WDS (See PR: AJ-1095: Add Java-PFB import and test terra-workspace-data-service#315)
• Instructions/details of automatic and manual publishing process added to library/README

3. Enabled publishing CLI

• Version for CLI is pulled from git.properties
• Release is now automatically created and includes the cli jar (Utilizes github cli: https://cli.github.com/manual/gh_release_create)
  Example:
  (Note: I've since deleted the release in the screen shot below to avoid confusion, as it was just a dummy release.)

Note on testing:

I've tested all of the individual actions, but I won't really be able to test them all together until this is merged. There is a small chance for a need for a follow on ticket to fix up the github actions.

[pshapiro4broad]

A few comments, please feel free to set up a meeting or send me a slack message if you want me to go over the comments in more detail.

[pshapiro4broad]

Just a few more comments, looks OK overall.

[pshapiro4broad]

Is this still called on workflow_dispatch? If not I think you can remove this line.

[snf2ye]

I'll remove it!

Just wanted to note that this trigger enables the "run workflow" button in the GitHub UI. But, I agree, I don't think it's needed for the tag action.

[pshapiro4broad]

I think I commented on this before, but I can't find the comment now. I think all three steps can be run as part of a single job. Something like

  tag-and-release:
    needs: [ unit-tests-and-sonarqube, source-clear ]
    if: success() && github.ref == 'refs/heads/main'
    runs-on: ubuntu-latest
    steps:
      - name: Tag
        uses: .github/workflows/tag.yml
        secrets: inherit
      - name: Publish library
        uses: .github/workflows/publish.yml
        with:
          tag: ${{ tag.outputs.tag }}
        secrets: inherit
      - name: Release CLI
        uses: .github/workflows/release-cli.yml
        with:
          tag: ${{ tag.outputs.tag }}
        secrets: inherit

Although the yaml lint is complaining about the secrets: inherit lines. Not sure why, to me it looks the same as the examples here: https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow

[snf2ye]

Oh sorry, I probably missed that suggestion!

I'd rather keep them as separate jobs. If nothing else, I like the diagram it produces 😀. I also have it so that the published library and publish cli jobs can run at the same time once the tag job completes (not that it saves that much time- they're both quick jobs).

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

85.0% Coverage
0.0% Duplication