-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop into main #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroecheler
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. The simplification around SQRLTable is very noticable. Good work!
sqrl-planner/sqrl-common/src/main/java/com/datasqrl/calcite/QueryPlanner.java
Outdated
Show resolved
Hide resolved
sqrl-planner/sqrl-common/src/main/java/com/datasqrl/calcite/QueryPlanner.java
Outdated
Show resolved
Hide resolved
sqrl-planner/sqrl-common/src/main/java/com/datasqrl/calcite/SqrlFramework.java
Outdated
Show resolved
Hide resolved
sqrl-planner/sqrl-common/src/main/java/com/datasqrl/calcite/SqrlFramework.java
Outdated
Show resolved
Hide resolved
sqrl-planner/sqrl-common/src/main/java/com/datasqrl/calcite/SqrlFramework.java
Outdated
Show resolved
Hide resolved
sqrl-planner/sqrl-common/src/main/java/com/datasqrl/calcite/schema/ScriptPlanner.java
Outdated
Show resolved
Hide resolved
sqrl-engines/sqrl-engine-core/src/main/java/com/datasqrl/plan/hints/TimestampHint.java
Show resolved
Hide resolved
sqrl-planner/sqrl-common/src/main/java/com/datasqrl/plan/ScriptValidator.java
Outdated
Show resolved
Hide resolved
...nner/sqrl-planner-local/src/main/java/com/datasqrl/graphql/generate/SchemaGeneratorUtil.java
Outdated
Show resolved
Hide resolved
...urces/snapshots/com/datasqrl/flink/FlinkDebugPhysicalIT/debugC3602OutputSelectTablesTest.txt
Show resolved
Hide resolved
mbroecheler
approved these changes
Oct 12, 2023
* Add dedicated PrimaryKeyMap for keeping track of primary key indexes. * Simplified AddedColumn class and fixed column order in aggregate * Generalized SelectIndexMap to allow "gaps" for structured columns in normalized representations
* Remove shadowed columns in use cases Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Add build on develop branch Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
…estamp handling and is more robust. WIP. Can be simplified further by removing all the custom "addColumn" functionality and isolate to ProxyImportRelationalTable for tiemstamp columns.
remove "wholes" from SelectIndexMap.
…ction. Removed VirtualRelationalTable and replaced with new classes. Updated the logical planner to keep structured columns.
* Remove column versions for user defined named --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
…rom the beginning.
…tween warnings and errors in the Error handler.
* Add post array handling for flink jdbc connector Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update names Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Remove test json Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Casing issue workaround Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Move to utility classes Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Add test Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Retain order of index set for build, fix conference test Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Move to lower case Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Better case insensitive filesystem search Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Add debugging Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * More case insensitive file lookup Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update case Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Remove print statements Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Aggregate repo test files Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
* WIP Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Separate SQRL table from planning Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix subscriptions Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Assure relationships are removed when root tables are shadowed Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Uncomment error message Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * cleanup Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Move to namepath, update snaps Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
* Convert to sqrl types for operand type inference Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix snap Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Move to lowercase Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> Signed-off-by: henneberger <git@danielhenneberger.com>
* Reuse flink cluster between tests Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix junit 5 running Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Code style Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix logging Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Local naming convention for tables Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
* Refactor schema building to support relationships to shadowed columns Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Reduce flink logging level to warn Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
* Quote all postgres identifiers Has a more consistent result set during querying (postgres converts to lowercase for column names otherwise), removes a quoting hack, and allows reserved words as column names --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
* Update documentation examples Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Snaps Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
* Use ungeneralized types for flexible schema and planner Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Move to wildcard Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix generics Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update other file Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Add flink std library Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Exclude PROCTIME due to incompatibility Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Generate docs for flink fncs Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
* Use ungeneralized types for flexible schema and planner Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix generics Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update other file Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Minor code changes Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Fix equality Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
* Use ungeneralized types for flexible schema and planner Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update other file Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Update library to use briding flink functions Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
* Small improvements to error presentation in cli Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> * Cleanup Signed-off-by: Daniel Henneberger <git@danielhenneberger.com> --------- Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Use base64 encoded plan as argument when submitting flink jobs Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Signed-off-by: Daniel Henneberger <git@danielhenneberger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.