Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enzyme to RTL (some files) #4573

Closed
wants to merge 5 commits into from

Conversation

yuki0410-dev
Copy link
Contributor

Continuation from last time PR(#4559);

Ref #4300

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@yuki0410-dev you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 913
- 552

94% JavaScript (tests)
6% JavaScript
<1% JSON

Generated lines of change

+ 21
- 1

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 96.51%. Comparing base (1fe9726) to head (31dd952).

Files Patch % Lines
src/month.jsx 42.85% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4573      +/-   ##
==========================================
- Coverage   96.87%   96.51%   -0.37%     
==========================================
  Files          28       28              
  Lines        2561     2581      +20     
  Branches     1074     1094      +20     
==========================================
+ Hits         2481     2491      +10     
- Misses         80       86       +6     
- Partials        0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijnrusschen
Copy link
Member

what happened?

@yuki0410-dev
Copy link
Contributor Author

yuki0410-dev commented Mar 10, 2024

@martijnrusschen
I mistakenly closed this PR.
(Running the code formatter caused a line break and required additional testing.)
I created #4574 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants