Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enzyme to RTL (some files) #4574

Merged
merged 5 commits into from
Mar 10, 2024

Conversation

yuki0410-dev
Copy link
Contributor

Continuation from last time PR(#4559);

Ref #4300

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@yuki0410-dev you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 1,044
- 557

91% JavaScript (tests)
9% JavaScript
<1% JSON

Generated lines of change

+ 21
- 1

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.90%. Comparing base (1fe9726) to head (dd32ed6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4574      +/-   ##
==========================================
+ Coverage   96.87%   96.90%   +0.02%     
==========================================
  Files          28       28              
  Lines        2561     2581      +20     
  Branches     1074     1094      +20     
==========================================
+ Hits         2481     2501      +20     
  Misses         80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martijnrusschen martijnrusschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a massive one, nice work! Many changes and extra tests. Thanks!

@martijnrusschen martijnrusschen merged commit e8c2766 into Hacker0x01:main Mar 10, 2024
6 checks passed
@yuki0410-dev yuki0410-dev deleted the feat/useRTL branch March 10, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants