lightgbm 2.2.3 (new formula) #43244
Closed
lightgbm 2.2.3 (new formula) #43244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't specify the amount of jobs in the makefile. It might cause issues with building. |
|
My bad, updated |
fxcoudert
requested changes
Sep 14, 2019
Formula/lightgbm.rb
Outdated
| system "cmake", *args, ".." | ||
| system "make" | ||
| end | ||
| lib.install "lib_lightgbm.so" |
There was a problem hiding this comment.
Shared libraries on macOS should be .dylib, not .so
There was a problem hiding this comment.
Fixed this as well with an additional flag.
Formula/lightgbm.rb
Outdated
| system "make" | ||
| end | ||
| lib.install "lib_lightgbm.so" | ||
| bin.install "lightgbm" |
There was a problem hiding this comment.
Is there no make install target?
There was a problem hiding this comment.
Hey @fxcoudert, thanks for the feedback. There was a make install target, so switched to that.
|
This is great! Merging. |
|
Thanks @fxcoudert and @SMillerDev 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?