Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew Formula for LightGBM #2408

Closed
StrikerRUS opened this issue Sep 14, 2019 · 8 comments · Fixed by #2414
Closed

Homebrew Formula for LightGBM #2408

StrikerRUS opened this issue Sep 14, 2019 · 8 comments · Fixed by #2414

Comments

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Sep 14, 2019

Upstream issue: Homebrew/homebrew-core#43244.

@ankane Thanks a lot for your efforts!

Please ping us if any help is needed from our side.

Want to hear opinion of macOS users @jameslamb @Laurae2 @henry0312.

@ankane
Copy link
Contributor

ankane commented Sep 14, 2019

Hey @StrikerRUS, the formula was just accepted, so Mac users can now do:

brew install lightgbm

Homebrew pre-compiles ("bottles") formula, so it installs in a couple seconds 🔥

@jameslamb
Copy link
Collaborator

WOW thank you so much @ankane this is great!

I read the formula and it looks good to me. @StrikerRUS we should consider updating that formula as a part of our release process. I think all we'd need to do is update which archive it points to.

@StrikerRUS
Copy link
Collaborator Author

@ankane Awesome! Many thanks to you!

@jameslamb

we should consider updating that formula as a part of our release process.

That's for sure! We should send PR to Homebrew repo right after LightGBM new release.

I think all we'd need to do is update which archive it points to.

@ankane Can you please confirm this? Should we only update url and sha256 fields in the formula?

@ankane
Copy link
Contributor

ankane commented Sep 15, 2019

@StrikerRUS Yeah, unless the build instructions change. Feel free to ping me if you run into issues with it.

@StrikerRUS
Copy link
Collaborator Author

@ankane Got it! Thanks a lot for your kindness!

@StrikerRUS
Copy link
Collaborator Author

@ankane BTW, is it possible to add an option --mpi to the formula to install with the MPI support? Maybe for some users it will be useful.
It will require only adding open-mpi dependency and -DUSE_MPI=ON flag for CMake.
https://github.com/microsoft/LightGBM/blob/master/docs/Installation-Guide.rst#apple-clang-2

@ankane
Copy link
Contributor

ankane commented Sep 16, 2019

It looks like options aren't allowed in formula in Homebrew core. From the docs:

Note: options are not allowed in Homebrew/homebrew-core as they are not tested by CI.

https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md

Also, I don't see any formula with optional dependencies, so I imagine that's not allowed as well.

@StrikerRUS
Copy link
Collaborator Author

@ankane Oh, I see! I'm sorry, I'm not very familiar with brew. I asked only because I have brew install gcc --without-multilib command (outdated already) in my head 😃 .

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants