Add new menu entry to remove braces from selection, aka unprotect it.

[BeeJay28]

Fixes #9950

Add an additional right click menu entry to "unprotect text selection", which strips the selected text of any curly-brace pairs.

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable). (UnprotectTermsFormatterTest.java does the testing)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request. (No information there)
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository. No documentation for this little right-click menu entry available. If an entry is necessary, then perhaps in general on how terms-protection works, what it is useful for and how to use it.

UI Changes:

[koppor]

The PR misses a screenshot:

It works there, but does not work if nothing is selected:

Three options:

a) gray out option if nothing is selected
b) Unprotect ALL if clicked
c) change text to "Unprotect" if nothing is selected and unprotect everything when clicked

[koppor]

It does not behave properly when nothing is selected. See comments.

Minor: I had to fix a CHANGELOG merge error.

[BeeJay28]

I was unsure of what it should exactly do if nothing is selected, so I just left it at the easiest option. Thanks for the feedback, I'll get on it.
And thank you for the screenshot. Tbh, I just had issues screenshotting while having the right click menu up (it would automatically close before capture). Thank you for that too 😅

[koppor]

And thank you for the screenshot. Tbh, I just had issues screenshotting while having the right click menu up (it would automatically close before capture). Thank you for that too 😅

I am using Greenshot on Windows with Hotkey Ctrl+F1 and that works most of the time. I also have experiences using GIMP, where one can say: Take a screenshot in 10 seconds. Then, one only needs "patience".

Thank you for continuing working on this!

[BeeJay28]

Three options:

a) gray out option if nothing is selected b) Unprotect ALL if clicked c) change text to "Unprotect" if nothing is selected and unprotect everything when clicked

I picked option a)

[koppor]

@ThiloteE OK for me that the option is disabled; consistent to other UI. I would have found the changing label better, but if it's OK for you to move forward, it is also for me :)