Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container for group item count still visible if display count is off #9980

Conversation

BeeJay28
Copy link
Contributor

@BeeJay28 BeeJay28 commented Jun 6, 2023

Fixes #9972

I moved the setting of the 'hits' style (which contains the styling of the grey container) into the update-callback of the displayGroupCountProperty. That way, whenever said property is updated, it clears all styling of it (mimicking the clearing of the setAll() method, that was used before my change) and adds the 'hits' style if the setting corresponding to the property was switched to true.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request. (too small of a feature, not documented)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository. (too small of a feature, not documented)

UI Changes:

2023-06-06-221019_1916x386_scrot
2023-06-06-221055_1903x448_scrot

@ThiloteE ThiloteE added the groups label Jun 7, 2023
@Siedlerchr Siedlerchr marked this pull request as ready for review June 7, 2023 16:58
@Siedlerchr Siedlerchr merged commit dc0d10c into JabRef:main Jun 7, 2023
@Siedlerchr
Copy link
Member

Thanks a lot for the contribution!

@AEgit
Copy link

AEgit commented Oct 17, 2023

JabRef 5.11--2023-10-17--8ede31a
Windows 10 10.0 amd64
Java 21-internal
JavaFX 20.0.2+3

@Siedlerchr I have a high suspicion that removing this feature has now removed the only visual queue that a specific item belongs to a group. Previously you could see that, because the grey rectangle was coloured green, when an item was selected that belonged to that group. Now, if display count is off (which is required for larger databases for performance reasons) you ca no longer visually see, whether a selected item belongs to a group or not. If my suspicion is correct, please revert this change (it is only a cosmetic one, anyway, but it removes actual functionality - e.g., in old JabRef 3.8.2 group assignment of an item was indicated by the group being underlined - in JabRef 5 it was then the colour of the rectangle that indicated group assignment).

Siedlerchr added a commit that referenced this pull request Jan 1, 2024
* upstream/main: (68 commits)
  Fix issue 9863 - Change Tab selection order (#9907)
  New Crowdin updates (#9994)
  Enable editing typo with double clicking on field name in custom entry type (#9977)
  Remove "Field name:" from localization - we already have "Field name" (#9991)
  Changed database to catalog in org.jabref.gui.slr and org.jabref.logic.crawler (#9989)
  Use environment variables for hostname detection (#9910)
  Add cleanup activity for URL field (#9970)
  Fix freezing when fetching IBSN and no results are found (#9987)
  Make Group(Node)TreeViewModel more OO (#9978)
  Fix container for group item count still visible if display count is off  (#9980)
  Fix paste of BibTeX data (#9985)
  Bring back SimplifyBoolean* and UnnecessaryParantheses (and refine guide) (#9981)
  Add new menu entry to remove braces from selection, aka unprotect it. (#9968)
  User specific comment (#9727)
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 1.19.3 to 2.0.0 (#9975)
  Fix typos
  Remove non-needed link
  Fix typos
  Enable RemoveJavaDocAuthorTag (#9973)
  Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#9974)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container for group item count still visible if display count is off
5 participants