Style admonitions with tcolorbox in LaTeXWriter

[odow]

TODOs before merging:

• NEWS
• Tests? I'm not really sure how to test this.

Closes #1931

Before

After

[odow]

Ah. Test failures are because I was developing on the latest patch, and then rebased onto master.

[mortenpi]

To fix the reference tests, you can run the tests locally with DOCUMENTER_FIXTESTS set (to anything).

[odow]

Okay, that seems to have done the trick.

[KristofferC]

Looks nice!

[mortenpi]

Hmm, it looks like there is some bad interaction with the surrounding elements here, effectively making the admonitions inline elements:

You can get the PDF from the PDFs artifact here, and and the relevant markdown is here.

[mortenpi]

Oh, and this is getting into bikeshedding territory, but what about (1) bold text in the title, and (2) any way to get it vertically centered?

[odow]

Oh, nice. I didn't notice the artifacts. I'll admit that I didn't look at the PDF of the showcase, I was just looking at the MOI and JuMP docs.

It looks like this might be some weird behavior with the use of \subparagraph for the Note admonition headers in bold?

Other parts seem normal:

Bikeshed away. Bold and vertical centering look doable: https://tex.stackexchange.com/questions/482103/tcolorbox-vertically-center-title-box

[odow]

It's because paragraph and subparagraph don't create new paragraphs after themselves. I guess we need an explicit \indent. This would affect things other than admonitions, like tables:

\subparagraph{New subparagraph}

\begin{tabular}{| c | c |}
\hline
foo & bar \\
\hline
\end{tabular}

\subparagraph{New subparagraph with indent}\indent

\begin{tabular}{| c | c |}
\hline
foo & bar \\
\hline
\end{tabular}

[odow]

Okay, this is now:

I don't understand the centering of the titles. It looks like some interplay with how we're redefining paragraph spacing etc.

I'd be in favor of merging this as-is, and coming back to it as a second-order thing.