Small style tweaks to LaTeXWriter #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
added
Type: Enhancement
Format: LaTeX
|
LGTM, thanks @odow! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built the JuMP docs with the
masterbranch of Documenter (jump-dev/JuMP.jl#3094, https://jump.dev/JuMP.jl/previews/PR3094/JuMP.pdf), and I have a couple of small tweaks to PRs that went in.\midrulefrom the tables in Improve styling of tables in LaTeXWriter #1938. I think we intended to do this, but I forgot to update the PR again. I think I got a bit confused because we kept changing back and forward.I can split into two PRs if needed.
On the whole though, things are much better. The table resizing is great, the admonitions stand out a lot more, and the code cells are nicely highlighted.