-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubocop version #494
Conversation
The old version does not work with the Ruby LSP VS Code extension.
Codecov Report
@@ Coverage Diff @@
## mampf-next #494 +/- ##
===========================================
Coverage 66.64% 66.64%
===========================================
Files 311 311
Lines 9362 9362
===========================================
Hits 6239 6239
Misses 3123 3123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused that Gemfile.lock
is unchanged. It still lists
rubocop (0.93.1)
and other old rubocop dependencies. Did you run
bundle update rubocop
inside the docker container? It should update the Gemfile.lock
.
See also this article and the links there on why it is recommended to include Gemfile.lock
in the repository (it is by default in a new Rails app; it seems that the consensus is to include it, and hence, have it up to date).
Oh, good catch, I completely forgot about the lock file and instead updated the version number by hand. I ran
now, (conservative to ensure to not update any other unrelated gems and keep this change focused) and this updated the lockfile accordingly. |
Update rubocop version for use with the Ruby LSP VS Code extension (Language server that works hand in hand with a ruby formatter of your choice, in our case rubocop, and automatically detects rubocop settings).