Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop version #494

Merged
merged 3 commits into from
May 11, 2023
Merged

Update rubocop version #494

merged 3 commits into from
May 11, 2023

Conversation

Splines
Copy link
Member

@Splines Splines commented May 8, 2023

Update rubocop version for use with the Ruby LSP VS Code extension (Language server that works hand in hand with a ruby formatter of your choice, in our case rubocop, and automatically detects rubocop settings).

Splines added 2 commits May 9, 2023 00:03
The old version does not work with the Ruby LSP VS Code extension.
@Splines Splines added the dependencies Pull requests that update a dependency file label May 8, 2023
@Splines Splines self-assigned this May 8, 2023
@Splines Splines requested a review from fosterfarrell9 May 8, 2023 22:06
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #494 (4e09236) into mampf-next (b119ec9) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           mampf-next     #494   +/-   ##
===========================================
  Coverage       66.64%   66.64%           
===========================================
  Files             311      311           
  Lines            9362     9362           
===========================================
  Hits             6239     6239           
  Misses           3123     3123           

Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused that Gemfile.lock is unchanged. It still lists

rubocop (0.93.1)

and other old rubocop dependencies. Did you run

bundle update rubocop

inside the docker container? It should update the Gemfile.lock.
See also this article and the links there on why it is recommended to include Gemfile.lock in the repository (it is by default in a new Rails app; it seems that the consensus is to include it, and hence, have it up to date).

@Splines
Copy link
Member Author

Splines commented May 9, 2023

I am confused that Gemfile.lock is unchanged. It still lists

rubocop (0.93.1)

and other old rubocop dependencies.

Oh, good catch, I completely forgot about the lock file and instead updated the version number by hand. I ran

bundle update rubocop --conservative

now, (conservative to ensure to not update any other unrelated gems and keep this change focused) and this updated the lockfile accordingly.

@fosterfarrell9 fosterfarrell9 self-requested a review May 9, 2023 16:05
@Splines Splines merged commit d00d5af into mampf-next May 11, 2023
@Splines Splines deleted the deps/rubocop branch May 11, 2023 15:04
@Splines Splines mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants